Skip to:
Content

bbPress.org

{33} Commit Messages, Current Release (5922 matches)

Report designed to help manage the list of contributors.

Note: If you'd like a RSS feed of the changesets a they happen, Please use ​the timeline rss feed instead.

Results (701 - 800 of 5922)

← 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 →
Changeset Author Message
[8380] johnjamesjacoby Build: Prepare bbPress 2.6.22. Finalize the 2.6.22 changelog and upgrade notice, update package and runtime versions, and retain the existing WordPress, PHP, and database requirements. In branches/2.6, for 2.6.22.
[8379] johnjamesjacoby Tools: Hide smoke-test admin passwords. Suppress WP-CLI output from the disposable WordPress installation step because it echoes the generated admin password. Keep the command's exit status and the subsequent package checks intact. In branches/2.6, for 2.6.22.
[8378] johnjamesjacoby Topics: Defer reply walks during spam and unspam. Reuse the topic-scoped reply walker guard while spamming or unspamming a topic's replies, then refresh counts and last activity after the loop. Keep reply hooks and direct reply operations working as before. Save the reply restore list before trashing children and retain it when a restore fails, so interrupted transitions can retry. In branches/2.6, for 2.6.22. See #3203.
[8377] johnjamesjacoby Topics: Defer reply walks during spam and unspam. Reuse the topic-scoped reply walker guard while spamming or unspamming a topic's replies, then refresh counts and last activity after the loop. Keep reply hooks and direct reply operations working as before. Save the reply restore list before trashing children and retain it when a restore fails, so interrupted transitions can retry. In trunk, for 2.7. See #3203.
[8376] johnjamesjacoby Notifications: Split subscription email choices by type. Offer separate email preferences for each registered subscription subtype, including forums, topics, topic tags, and custom taxonomies. Show whether Default sends email while keeping explicit Send emails and No emails choices across bbPress, WordPress Admin, and BuddyPress profiles. Choose an enabled subscription before combining recipients. This keeps one email per person and gives overlapping subscriptions the correct receipt and unsubscribe link. Prime user caches in batches before checking preferences, and leave the normal subscriber query unchanged. In trunk, for 2.7. See #3792, #2989.
[8375] johnjamesjacoby Topics/Forums: Preserve trash restore lists. Save child IDs before cascading a topic or forum trash, and clear their restore lists only after all recorded children leave the Trash. Keep previously trashed children excluded and allow interrupted cascades to retry. In branches/2.6, for 2.6.22. See #3203.
[8374] johnjamesjacoby Topics/Forums: Preserve trash restore lists. Save child IDs before cascading a topic or forum trash, and clear their restore lists only after all recorded children leave the Trash. Keep previously trashed children excluded and allow interrupted cascades to retry. In trunk, for 2.7. See #3203.
[8373] johnjamesjacoby BuddyPress: Prefer current URL helpers. Use the BuddyPress 12.0 URL APIs when available, while retaining deprecated functions as compatibility fallbacks for earlier versions. In branches/2.6, for 2.6.22. See #3777.
[8372] johnjamesjacoby Topics: Defer reply walks during trash and restore. Reuse the topic-scoped reply walker guard while trashing or restoring a topic's replies, then refresh activity after the loop. Other reply callbacks and direct reply operations still run as before. In branches/2.6, for 2.6.22. See #3203.
[8371] johnjamesjacoby Topics: Defer reply walks during trash and restore. Reuse the topic-scoped reply walker guard while trashing or restoring a topic's replies, then refresh activity after the loop. Other reply callbacks and direct reply operations still run as before. In trunk, for 2.7. See #3203.
[8370] johnjamesjacoby Subscriptions: Enable AJAX toggles on term archives. Add a generic, filterable helper for checking whether an object supports an engagement. Use it to enqueue and localize the existing engagements script when the queried post or term supports subscriptions, enabling topic-tag and custom-taxonomy links to toggle without reloading. Keep toggle permissions generic and require an explicit object ID, while the template-facing subscription helper can infer the current queried object. Preserve supplied topic-tag IDs outside archives and cover topic tags, custom taxonomies, unsupported taxonomies, and forums. In trunk, for 2.7. See #2989.
[8369] johnjamesjacoby Topics/Forums: Avoid repeated deletion recounts. Suspend the core reply and topic walkers during enclosing permanent deletions, then refresh counts and last activity at the deletion boundary. Keep direct action calls and other callbacks working, and restore counts if deletion is interrupted. In branches/2.6, for 2.6.22. See #3203.
[8368] johnjamesjacoby Topics/Forums: Avoid repeated deletion recounts. Suspend the core reply and topic walkers during enclosing permanent deletions, then refresh counts and last activity at the deletion boundary. Keep direct action calls and other callbacks working, and restore counts if deletion is interrupted. In trunk, for 2.7. See #3203.
[8367] johnjamesjacoby Tests: Cover anonymous topics in group forums. Verify that anonymous topic creation follows BuddyPress community visibility while remaining available in forums open to visitors. In trunk, for 2.7.
[8366] johnjamesjacoby Topics: Require forum read access to create topics. Check the target forum's read capability for every topic submission. Keep the existing private and hidden forum errors while preventing creation in other unreadable forums. In branches/2.6, for 2.6.22.
[8365] johnjamesjacoby Notifications: Match native profile settings markup. Render bbPress preferences with the existing front-end form structure and BuddyPress notification table. Keep the permission and nonce checks close to the integration, and cover the BuddyPress markup, authorization, and saved Default, Yes, and No choices. In trunk, for 2.7. See #3792.
[8364] johnjamesjacoby Theme Compat: hide profile password controls by default. The 2.6 change in r7230 renamed the emitted body class to bbp-no-js. The trunk changeset in r7231 updated the CSS and script to use bbp-no-js and bbp-js but left the emitted class as no-js. Align trunk with 2.6 so profile password controls stay hidden until Generate Password is selected and the fields remain available without JavaScript. In trunk, for 2.7. See #3445.
[8363] johnjamesjacoby Notifications: Add user email preferences. Store mention and subscription email choices together in one global user-meta row. Default keeps mention emails off unless BuddyPress enables them, and keeps subscription emails on for users who subscribed. Show Default, Yes, and No on bbPress, WordPress Admin, and BuddyPress profiles. Filter subscription recipients before recording delivery so turning those emails off leaves subscriptions intact and does not suppress an enabled mention email. Keep unregistered notification types from dropping recipients. The previous mention-only preference has not shipped, so its old key needs no fallback. In trunk, for 2.7. Fixes #3792.
[8362] johnjamesjacoby Notifications: Keep line feeds outside translated strings. Translate each natural-language line separately and assemble plain-text email layouts in PHP. Preserve the rendered moderation, subscription, unsubscribe, and mention messages while avoiding escaped line feeds in translation entries. In trunk, for 2.7. See #2773, #2989, #3229, #3349.
[8361] johnjamesjacoby Notifications: Explain not to reply to emails. Adapt the existing WordPress.org Meta guidance for bbPress core. Tell subscription and mention email recipients to follow the included link when they want to reply, and clarify that replies sent directly to the notification address are ignored. Keep this guidance consistent across forum, topic, taxonomy, and mention notifications without changing existing filters or delivery behavior. In trunk, for 2.7. See #2773, #3229.
[8360] johnjamesjacoby Subscriptions: Identify notification sources. Generate each receipt from the exact forum, topic, or taxonomy term that caused the notification. Use registered singular labels and object names so integrations can support custom taxonomies without rebuilding completed messages. Include taxonomy subscribers in new-reply notifications, preserve deterministic post-subscription precedence when sources overlap, and retain topic contexts for recipients added by existing filters. Keep the compatibility helper for user-ID-only callers. Add regression coverage for built-in and custom taxonomy receipts, new-topic and new-reply delivery, overlapping sources, and filtered subscription contexts. In trunk, for 2.7. See #2989, #3229.
[8359] johnjamesjacoby Tools: Harden repair and upgrade batching. Preserve concurrent freshness activity with bounded reply scans and verified metadata snapshots. Recover missing or malformed scratch state without losing completed work, and validate related checkpoint fields before resuming. Centralize scratch cleanup, lock refreshes, run ownership, and failure handling. Keep Stop and Discard bounded across bulk queues while preserving full Dry Runs, safe retries, and automatic small-site upgrades. Add regression coverage for concurrency, malformed progress, filter limits, lock expiry, queue recovery, and multisite behavior. In trunk, for 2.7. See #3777.
[8358] johnjamesjacoby Subscriptions: Filter individual email contexts. Add a filterable per-recipient subscription context before assembling one-click emails. This allows integrations to select the correct subscription object without rewriting completed messages or headers. Reuse primed user caches when resolving recipient addresses to avoid redundant user queries while preserving batching, ID normalization, multisite behavior, and deduplication. In trunk, for 2.7. See #3229.
[8357] johnjamesjacoby Tools: Simplify batching validation. Use the shared typed preview-state validator for group-forum and reply-position checkpoints. Remove the unused metadata work estimate and its SQL aggregate while preserving change verification and bounded mutation planning. In trunk, for 2.7. See #3777.
[8356] johnjamesjacoby Tools: Version freshness checkpoints. Add an explicit checkpoint context version so incomplete freshness runs created before the forum-topic aggregate restart rather than resuming without required summary state. Add regression coverage for legacy checkpoints. In trunk, for 2.7. See #3777.
[8355] johnjamesjacoby Tools: Simplify Dry Run continuation. Remove the unused freshness checkpoint marker and derive synchronous Dry Run continuation directly from the existing asynchronous state. Avoid repeating that check inside each group-forum migration batch. In trunk, for 2.7. See #3777.
[8354] johnjamesjacoby Tools: Remove unused batching paths. Remove the unused forum recount status traversal, dead wrappers, and unneeded run-state fields. Reuse existing array normalization helpers where behavior is identical and preserve explicit empty status filters. In trunk, for 2.7. See #3777.
[8353] johnjamesjacoby Subscriptions: Prime recipient user caches. Prime subscriber user and user-meta caches in bounded batches before checking notification capabilities. This avoids per-recipient database queries for cold caches while preserving existing access checks, recipient order, and the shared chunk-size filter. In trunk, for 2.7. See #3229.
[8352] johnjamesjacoby Tools: Remove obsolete split run status state. Remove the unused split status options and schema compatibility layer introduced during batching development. Keep queue state and status in the single owner-checked run-state record. In trunk, for 2.7. See #3777.
[8351] johnjamesjacoby BuddyPress: Prefer current URL helpers. Use the BuddyPress 12.0 URL APIs when available, while retaining deprecated functions as compatibility fallbacks for earlier versions. In trunk, for 2.7. See #3777.
[8350] johnjamesjacoby Tools: Harden repair and upgrade batching. Bound freshness Dry Runs with per-forum topic summaries, preserve Run progress across batches, and make Stop and Discard remove owned checkpoint and scratch state without racing in-flight callbacks. Retry queue transitions, share the automatic-update time budget, cap synchronous Dry Run restarts, and clean temporary tool state on uninstall. Centralize callback invocation, result and failure normalization, preview persistence, and standard notice presentation. Refresh direct forum counts without restarting complete traversals, remove duplicate freshness reads, and add regression coverage for skewed data, failed writes, retries, cleanup, bulk queues, AJAX, multisite, and synchronous small-site automatic upgrades. In trunk, for 2.7. See #3777.
[8349] johnjamesjacoby Subscriptions: Add one-click unsubscribe. Send one subscription notification per recipient so each message can include a signed, expiring unsubscribe URL and RFC 8058 headers. Support forum, topic, and taxonomy subscriptions, preserve the deprecated recipient filter for compatibility, and add a configurable confirmation route through theme compatibility. Confirm normal link clicks before changing state, accept one-click POST requests, and keep repeated requests idempotent. Add regression coverage for notification delivery, deferred publication, rewrite routing, settings, templates, and public request state. In trunk, for 2.7. Fixes #3229.
[8348] johnjamesjacoby Tools: Finish procedural worker state cleanup. Apply the shared procedural lifecycle to mention Dry Run previews, legacy user-meta cleanup, user-role mapping, sticky-topic repairs, closed-topic repairs, and forum visibility repairs. Validate aggregate preview state and role plans. Preserve bounded work, staged visibility publication, verified writes, migration guards, safe retries, multisite isolation, and synchronous small-site automatic upgrades. In trunk, for 2.7. See #3777.
[8347] johnjamesjacoby Tools: Centralize legacy user-list worker state. Share legacy user-meta checkpoint validation, list parsing, row fingerprints, bounded source reads, typed Dry Run preview validation, and procedural lifecycle handling across favorites and subscription repairs and upgrades. Preserve the repair probe, migration planning, aggregate Dry Runs, bounded work, verified writes, safe retries, multisite isolation, and synchronous small-site automatic upgrades. Report shared semantic read, write, callback, and progress failures. In trunk, for 2.7. See #3777.
[8346] johnjamesjacoby Tools: Centralize user-engagement worker state. Apply the shared procedural lifecycle to user-engagement upgrades. Centralize result setup, checkpoints, Dry Run totals, continuation, preview validation, and failure reporting. Report semantic engagement read and write failures from the shared row reconciler. Preserve bounded work, verified writes, safe retries, multisite isolation, and synchronous small-site automatic upgrades. In trunk, for 2.7. See #3777.
[8345] johnjamesjacoby Tools: Centralize reply-position worker state. Apply the shared procedural lifecycle to reply-position repairs. Centralize result setup, checkpoints, Dry Run totals, continuation, and failure reporting. Preserve bounded work, verified writes, safe retries, multisite isolation, and synchronous small-site automatic upgrades. Restart legacy or malformed preview state safely. In trunk, for 2.7. See #3777.
[8344] johnjamesjacoby Theme Compat: Locate bbPress Block Templates. Pass the existing theme-compatibility hierarchy through WordPress's Block Template loader instead of reusing whichever Block Template WordPress selected first. Keep query-specific bbPress candidates first, fall back to the default canvas when none exist, and set up Loop globals before rendering the Post Content block. Expose the reusable hierarchy through bbp_get_theme_compat_template_hierarchy() and its filter, preserve the existing PHP-template wrapper, and add regression coverage for archive, page, and single-forum templates. In branches/2.6, for 2.6.22. See #3487.
[8343] johnjamesjacoby Theme Compat: Locate bbPress Block Templates. Pass the existing theme-compatibility hierarchy through WordPress's Block Template loader instead of reusing whichever Block Template WordPress selected first. Keep query-specific bbPress candidates first, fall back to the default canvas when none exist, and set up Loop globals before rendering the Post Content block. Expose the reusable hierarchy through bbp_get_theme_compat_template_hierarchy() and its filter, preserve the existing PHP-template wrapper, and add regression coverage for archive, page, and single-forum templates. In trunk, for 2.7. See #3487.
[8342] johnjamesjacoby Tools: Centralize post-reference worker state. Apply the shared procedural lifecycle to topic-reference and parent-forum-reference repairs. Centralize result initialization, checkpoint loading and saving, aggregate Dry Run state, continuation, and semantic failure reporting while preserving tool IDs, saved checkpoint keys, bounded metadata cleanup, safe retries, multisite isolation, and synchronous small-site automatic upgrades. Remove the parent-forum failure-code translation and add regression coverage for bounded browser Dry Runs across both reference types. In trunk, for 2.7. See #3777.
[8341] johnjamesjacoby Common: Normalize unique array values. Return consecutive numeric keys from bbp_get_unique_array_values() after removing empty and duplicate values. Preserve the existing values, order, filtering, duplicate comparison, and PHP 8 named-argument support. In branches/2.6, for 2.6.22. See #3791.
[8340] johnjamesjacoby Common: Normalize unique array values. Return consecutive numeric keys from bbp_get_unique_array_values() after removing empty and duplicate values. Preserve the existing values, order, filtering, duplicate comparison, and PHP 8 named-argument support. In trunk, for 2.7. Fixes #3791.
[8339] johnjamesjacoby Tools: Centralize procedural worker state. Add shared lifecycle helpers for procedural repair workers. Centralize result initialization, checkpoint loading and saving, Dry Run continuation, and first-failure reporting while preserving tool IDs, saved checkpoint keys, bounded work, aggregate Dry Runs, safe retries, multisite isolation, and synchronous small-site automatic upgrades. Apply the shared lifecycle to topic reply, topic voice, subforum, topic-tag, and user post recounts, with semantic failure reasons and regression coverage. In trunk, for 2.7. See #3777.
[8338] johnjamesjacoby Tools: Centralize repair and upgrade worker state. Add a shared base class for the class-based repair and upgrade workers. Centralize checkpoint persistence, callback status, and first-failure reporting while preserving tool IDs, saved checkpoint keys, batching, Dry Runs, safe retries, and synchronous small-site automatic upgrades. In trunk, for 2.7. See #3777.
[8337] johnjamesjacoby Topics: Improve topic-tag archive controls. Move the topic-tag subscription link into the shared topic archive content so it is available through theme compatibility as well as the bundled taxonomy template. Use concise Subscribe and Unsubscribe labels, and use the existing topic search form to keep searches scoped to the current tag. Place archive search forms below breadcrumbs and subscription controls, and add direct-child spacing that avoids changing nested profile, widget, or shortcode forms. In trunk, for 2.7. See #2989.
[8336] johnjamesjacoby Tools: Clarify repair and upgrade worker internals. Rename the group-forum upgrade worker and private traversal state to describe their roles more directly. This behavior-preserving cleanup leaves tool IDs, saved checkpoint keys, result shapes, batching, and automatic upgrades unchanged. In trunk, for 2.7. See #3777.
[8335] johnjamesjacoby Subscriptions: Add taxonomy term subscriptions. This change completes term subscriptions by adding taxonomy-scoped engagement queries, topic-tag and profile controls, and new-topic notifications. Topic tags work out of the box, and any topic taxonomy that opts in with `bbp_subscriptions` uses the same API and templates. Forum and term subscribers share the existing notification flow, with recipients deduplicated and notification text matched to their subscription source. Term queries remain isolated by taxonomy across engagement strategies. In trunk, for 2.7. Props jmdodd, netweb, obenland. Fixes #2989.
[8334] johnjamesjacoby Formatting: Centralize plain-text notification values. Add bbp_make_plain_text() and use it in moderation and subscription emails. Preserve the existing tag stripping and entity decoding order and output. In trunk, for 2.7. Fixes #3789.
[8333] johnjamesjacoby Tools: Document resumable repair workers. Add property and method documentation to the shared forum traversal, recount, freshness, and group-forum migration classes. Record each contract against the canonical revision that introduced it without changing runtime behavior. In trunk, for 2.7. See #3777.
[8332] johnjamesjacoby Tests: Stabilize topic description output. Use a fixed freshness value while comparing the topic description getter and output wrapper. This prevents a one-second clock tick from failing PHPUnit without changing runtime behavior. In trunk, for 2.7. Fixes #3788.
[8331] johnjamesjacoby Tools: Complete Dry Runs through bounded AJAX batches. Make repair and upgrade Dry Runs inspect complete operations without changing data or saved Run progress. Share bounded preview checkpoints, aggregate totals, estimated Run batches, pause/resume/stop recovery, and safe cleanup across the existing batched tools while preserving synchronous small-site automatic upgrades and retry-safe Run behavior. In trunk, for 2.7. See #3777.
[8330] johnjamesjacoby Users: Add per-subtype subscription controls. This change lets registered post types and taxonomies opt in to subscriptions with the `bbp_subscriptions` argument. Forums, topics, and topic tags opt in by default, and the forum settings screen can enable each registered subtype independently. Keep legacy scalar option values compatible while storing new per-subtype selections as arrays. Preserve temporarily unavailable selections, ignore stale values when deciding whether subscriptions are active, and keep the new subtype list filterable. Apply the selected subtype consistently to subscription links, forms, administration metaboxes, profile sections, and immediate and deferred notifications. Show subscribers on subscribed taxonomy term edit screens and provide a profile-template hook for custom subtype output. In trunk, for 2.7. See #3785, #2989.
[8329] johnjamesjacoby Forums: Exclude protected content from listings. Keep topics and replies beneath password-protected forums out of aggregate public queries, even after a forum password has been entered. Preserve direct access and child loops scoped to an unlocked forum or topic. Apply forum ancestry checks to affected get_posts() queries that otherwise suppress SQL filters, and keep REST collection permissions intact across supported WordPress versions. Stop forum-ancestor traversal when a parent forum is missing, avoiding a fatal error in malformed hierarchies. In branches/2.6, for 2.6.22.
[8328] johnjamesjacoby Forums: Exclude protected content from listings. Keep topics and replies beneath password-protected forums out of aggregate public queries, even after a forum password has been entered. Preserve direct access and child loops scoped to an unlocked forum or topic. Apply forum ancestry checks to affected get_posts() queries that otherwise suppress SQL filters, and keep REST collection permissions intact across supported WordPress versions. Stop forum-ancestor traversal when a parent forum is missing, avoiding a fatal error in malformed hierarchies. In trunk, for 2.7.
[8327] johnjamesjacoby Users: Check stored roles in auto-role test. A request-only forum capability can appear on the cached WP_User object without being saved. Inspect user metadata so this test verifies that request-only mapping does not persist the forum role on older WordPress versions. In trunk, for 2.7.
[8326] johnjamesjacoby Users: Prevent unrestricted engagement queries. Return an empty query for registered engagement types when a user has no related objects, instead of passing a zero ID that `WP_Term_Query` treats as unrestricted. Keep the legacy zero-ID fallback for unregistered post queries, and update the term-query test to skip empty queries. In trunk, for 2.7. See #3785, #2989.
[8325] johnjamesjacoby Attachments: Respect forum visibility in comment feeds. Remove comments on attachments to unreadable forums, topics, and replies from comment-feed queries, along with the attachment posts themselves. WordPress selects feed comments before their posts, so both are filtered: the RSS2 and Atom templates read the comments, and the legacy RSS and RDF templates read the posts. The check is bounded to the comments WordPress already selected, so filtered feeds may return fewer items than configured. Singular attachment feeds with nothing visible render empty, matching a missing attachment on older WordPress versions. Comments on other post types and comment editing are unchanged. In branches/2.6, for 2.6.22.
[8324] johnjamesjacoby Attachments: Respect forum visibility in comment feeds. Remove comments on attachments to unreadable forums, topics, and replies from comment-feed queries, along with the attachment posts themselves. WordPress selects feed comments before their posts, so both are filtered: the RSS2 and Atom templates read the comments, and the legacy RSS and RDF templates read the posts. The check is bounded to the comments WordPress already selected, so filtered feeds may return fewer items than configured. Singular attachment feeds with nothing visible render empty, matching a missing attachment on older WordPress versions. Comments on other post types and comment editing are unchanged. In trunk, for 2.7.
[8323] johnjamesjacoby Users: Register an engagement type for terms. This change adds `BBP_User_Engagements_Type_Term` and registers it as the `term` engagement type, so terms in opted-in taxonomies can be subscribed to through the engagements API with any strategy. Terms support subscriptions only when their taxonomy opts in with `bbp_subscriptions`. Topic tags opt in while they are allowed. Reading a term requires a viewable taxonomy and the `spectate` capability. Custom taxonomies use their term archive links, while topic tags keep `bbp_get_topic_tag_link()` and its filter. The default theme package's AJAX subscription handler now validates objects through their engagement type instead of `get_post()`, and passes the type along when adding or removing the subscription. Subscription nonces for objects other than posts now include the object type, so a nonce for one type cannot be used for another object with the same ID. Posts keep the original nonce for third-party theme packages. In trunk, for 2.7. See #3785, #2989.
[8322] johnjamesjacoby Formatting: Preserve code containing backticks. Keep code markup intact when its content includes the shorthand delimiter instead of converting it to ambiguous backtick syntax. Preserve entity-encoded content across forum, topic, and reply edit round trips while leaving ordinary code formatting unchanged. In branches/2.6, for 2.6.22.
[8321] johnjamesjacoby Formatting: Preserve code containing backticks. Keep code markup intact when its content includes the shorthand delimiter instead of converting it to ambiguous backtick syntax. Preserve entity-encoded content across forum, topic, and reply edit round trips while leaving ordinary code formatting unchanged. In trunk, for 2.7.
[8320] johnjamesjacoby Theme Compat: Disable WordPress adjacent-post navigation. Extend the existing adjacent-post removal path to cover direct queries and link output from themes and blocks. Keep WordPress post navigation disabled consistently on bbPress pages, leave ordinary WordPress posts unchanged, and preserve later filter overrides. In branches/2.6, for 2.6.22.
[8319] johnjamesjacoby Theme Compat: Disable WordPress adjacent-post navigation. Extend the existing adjacent-post removal path to cover direct queries and link output from themes and blocks. Keep WordPress post navigation disabled consistently on bbPress pages, leave ordinary WordPress posts unchanged, and preserve later filter overrides. In trunk, for 2.7.
[8318] johnjamesjacoby Users: Store and query engagements by registered type. This change keeps engagements with different types apart in every strategy, and lets the user and term strategies query objects that are not posts, so the same object ID can be engaged with as a post and as another type without the two colliding. The meta and term strategies already stored each type separately, in its own metadata table or its own taxonomy. The user strategy did not, so its option and cache names now include the type for anything other than posts, such as `_bbp_subscriptions_term`. Posts keep their 2.5 names. Strategies now ask `BBP_User_Engagements_Base::get_storage_key()` for the key a relationship is stored under. It returns the relationship key unchanged, and the new `bbp_get_engagement_storage_key` filter can change it, so a site can keep existing data under a different key without replacing its strategy. Engagement types now also describe their query arguments and whether they support `tax_query`, so the user and term strategies can limit `get_terms()` and other non-post queries to the right objects. When a registered type cannot limit a query, `bbp_get_user_object_query()` returns an empty array without filtering it, and `bbp_get_user_engagements()` and `bbp_get_user_mentions()` skip the query, like favorites and subscriptions already do. In trunk, for 2.7. See #3785, #2989.
[8317] johnjamesjacoby Common: Exclude protected content from sitemaps. Apply existing password and forum-ancestry checks to WordPress post sitemaps for bbPress forums, topics, and replies. Keep public discovery consistent across visitor roles while preserving ordinary WordPress post sitemaps and direct password access. In branches/2.6, for 2.6.22.
[8316] johnjamesjacoby Common: Exclude protected content from sitemaps. Apply existing password and forum-ancestry checks to WordPress post sitemaps for bbPress forums, topics, and replies. Keep public discovery consistent across visitor roles while preserving ordinary WordPress post sitemaps and direct password access. In trunk, for 2.7.
[8315] johnjamesjacoby Tools: Consolidate resumable repair infrastructure. Share checkpoint preparation, verified metadata writes, result formatting, and runner ownership checks across repair and upgrade tools. Preserve filtered views without changing stored bulk queues, retain interrupted work for safe retries, and keep small-site upgrades automatic. Process group-forum migration in bounded batches, make completion and work bounds explicit, and keep scratch cleanup scoped to each tool. Add regression coverage for failed AJAX callbacks and remove superseded helpers. In trunk, for 2.7. See #3777.
[8314] johnjamesjacoby Attachments: Respect forum visibility for comments. Use the existing attachment-parent visibility check when WordPress approves comments. Reject submissions to attachments whose bbPress parent cannot be viewed while preserving comments for authorized users and unrelated media. In branches/2.6, for 2.6.22.
[8313] johnjamesjacoby Attachments: Respect forum visibility for comments. Use the existing attachment-parent visibility check when WordPress approves comments. Reject submissions to attachments whose bbPress parent cannot be viewed while preserving comments for authorized users and unrelated media. In trunk, for 2.7.
[8312] johnjamesjacoby Appearance: Keep toolbar color scheme hover square. Paint top-level toolbar hover and focus backgrounds on the list item instead of the link. Clear older WordPress link backgrounds so Mint and Evergreen keep their colors while WordPress 7.2's rounded focus outline stays intact. In branches/2.6, for 2.6.22. Fixes #3787. See https://core.trac.wordpress.org/ticket/66626.
[8311] johnjamesjacoby Appearance: Keep toolbar color scheme hover square. Paint top-level toolbar hover and focus backgrounds on the list item instead of the link. Clear older WordPress link backgrounds so Mint and Evergreen keep their colors while WordPress 7.2's rounded focus outline stays intact. In trunk, for 2.7. See #3787. See https://core.trac.wordpress.org/ticket/66626.
[8310] johnjamesjacoby Tools: Keep submenu count bubbles visible on hover. Keep the pending Forums count colored while the Tools menu or another submenu link is hovered. Scope the override to submenu links so the parent Tools count keeps its existing styling. In branches/2.6, for 2.6.22. See #3775.
[8309] johnjamesjacoby Tools: Keep submenu count bubbles visible on hover. Keep the pending Forums count colored while the Tools menu or another submenu link is hovered. Scope the override to submenu links so the parent Tools count keeps its existing styling. In trunk, for 2.7. See #3775.
[8308] johnjamesjacoby BuddyPress: Scope group forum moderation capabilities. Require an explicit forum, topic, or reply before group staff receive moderation capabilities. Keep view=all queries, links, redirects, and pagination scoped to the relevant forum or topic while preserving site-wide moderator behavior. Add BuddyPress regression coverage for local and unrelated content. In 2.6, for 2.6.22.
[8307] johnjamesjacoby BuddyPress: Scope group forum moderation capabilities. Require an explicit forum, topic, or reply before group staff receive moderation capabilities. Keep view=all queries, links, redirects, and pagination scoped to the relevant forum or topic while preserving site-wide moderator behavior. Add BuddyPress regression coverage for local and unrelated content. In trunk, for 2.7.
[8306] johnjamesjacoby Users: Introduce registered engagement types. This change adds a registry of engagement types, so code that validates or links to an engagement asks the registered type about its object instead of assuming every object is a post. Types are registered with `bbp_register_engagement_type()` on the new `bbp_register_engagements` action, which can later register other engagement concepts too, using a name and an array of arguments whose `class` must be or extend `BBP_User_Engagements_Type`. The bundled `post` type holds the existing forum and topic rules, split into whether an object supports an engagement and whether the current user can read it. `bbp_current_user_can_toggle_engagement()` keeps its shared checks and the rule that existing engagements may be removed after visibility changes, and asks the registered type everything else. The subscriptions handler uses the type for its fallback redirect. Lookups are exact, so unregistered object types continue to fail closed. The engagements strategy class files are renamed with a `-strategy-` segment to make room for the type classes. Class names are unchanged, and `bbp_is_valid_engagements_strategy()` now rejects engagement type classes, which share the `BBP_User_Engagements_` prefix. In trunk, for 2.7. See #3785, #2989.
[8305] johnjamesjacoby Tools: Batch reply position repairs. Recalculate reply positions and remove self references in resumable batches. Inspect every reply, including incorrect unique positions, so partial repairs cannot skip remaining work. Share uncached checkpoint verification and reuse topic prefixes within each batch. Preserve native child ordering, read-only previews, safe retries, and synchronous automatic-runner compatibility. In trunk, for 2.7. See #3777.
[8304] johnjamesjacoby Tools: Batch forum visibility repairs. Rebuild private and hidden forum lists in resumable batches, preserving live lists during scans, read-only previews, safe retries, and synchronous automatic runs on small sites. Restart staged scans after forum membership changes. Share verified option writes and checkpoint deletion while preserving WordPress cache, filter, and autoload behavior. In trunk, for 2.7. See #3777.
[8303] johnjamesjacoby Tools: Batch sticky-topic assignment repairs. Repair sticky-topic assignments in resumable batches while preserving super stickies, source-list changes, read-only previews, safe retries, and synchronous automatic runs on small sites. Share verified metadata replacement and bounded duplicate cleanup across repairs. Preserve original list rows until replacements are verified, stop on failed deletions, and reuse safe exact-key rows after failed rollback. Remove checkpoint and scratch options through their shared namespace instead of maintaining a separate tool registry. In trunk, for 2.7. See #3777.
[8302] johnjamesjacoby Attachments: Preserve bbPress permissions with Gutenberg. Apply bbPress attachment permission checks when Gutenberg supplies the media REST controller. Preserve its media processing behavior and leave unrelated custom controllers alone. In branches/2.6, for 2.6.22.
[8301] johnjamesjacoby Attachments: Preserve bbPress permissions with Gutenberg. Apply bbPress attachment permission checks when Gutenberg supplies the media REST controller. Preserve its media processing behavior and leave unrelated custom controllers alone. In trunk, for 2.7.
[8300] johnjamesjacoby Users: Organize engagement code by responsibility. Move the engagement strategies into individual user class files, keep the shared relationship API in users/engagements.php, and separate favorites and subscriptions. Move the Mentions CLI command alongside the other user classes and update the explicit loaders without changing existing behavior. Isolate the profile engagement tests from notices left by earlier tests so their expectations do not depend on suite order. In trunk, for 2.7. See #2989.
[8299] johnjamesjacoby Tools: Batch topic and forum freshness repairs. Recalculate topic and forum activity in resumable batches, sharing hierarchy traversal with forum recounts while preserving existing date filters, child ordering, and count checkpoints. Bound orphan inspection and scratch cleanup, keep only the in-flight topic in its checkpoint, and verify metadata writes and source identities before advancing. Preserve read-only previews, safe retries, bulk sequencing, and synchronous automatic runs on small sites. In trunk, for 2.7. See #3777.
[8298] johnjamesjacoby Tools: Avoid null group-forum relationship lists. Skip current-marker parsing when stored BuddyPress group metadata is missing. This prevents PHP deprecation notices while preserving legacy-marker detection and stale relationship handling. In trunk, for 2.7. See #3035.
[8297] johnjamesjacoby Importers: Avoid null BBCode template lengths. Check optional template flags and enhanced tag defaults before measuring their lengths. This prevents PHP deprecation notices while preserving template expansion for empty, zero-like, and populated values. In branches/2.6, for 2.6.22. See #3727.
[8296] johnjamesjacoby Theme Compat: Accept excerpt-only filter calls. Make the post argument optional for the get_the_excerpt callback. Some integrations pass only the excerpt, causing an ArgumentCountError on requests outside bbPress views. Preserve the incoming excerpt without a post and keep generated theme-compat content when WordPress supplies the current synthetic post. In branches/2.6, for 2.6.22. Props joaquinferrero. Fixes #3784. See #3431.
[8295] johnjamesjacoby Importers: Avoid null BBCode template lengths. Check optional template flags and enhanced tag defaults before measuring their lengths. This prevents PHP deprecation notices while preserving template expansion for empty, zero-like, and populated values. In trunk, for 2.7. See #3727.
[8294] johnjamesjacoby Theme Compat: Accept excerpt-only filter calls. Make the post argument optional for the get_the_excerpt callback. Some integrations pass only the excerpt, causing an ArgumentCountError on requests outside bbPress views. Preserve the incoming excerpt without a post and keep generated theme-compat content when WordPress supplies the current synthetic post. In trunk, for 2.7. Props joaquinferrero. See #3784. See #3431.
[8293] johnjamesjacoby Tests: Reset metadata before role read failures. Explicitly clear the user metadata cache when preparing the role-batching read-failure fixtures. WordPress versions before 6.2 do not clear it through clean_user_cache(), allowing cached capabilities to bypass the intended database failure and leaving early-failure cache assertions dependent on the WordPress version. In trunk, for 2.7. See #3777.
[8292] johnjamesjacoby General: Avoid PHP 8.6 type-check deprecations. Use `is_int()` after successful front-end profile updates, preserving existing edit and redirect behavior. Use `instanceof` for fixed-class object checks, preserving existing validation behavior without passing strings to `is_a()`. Guard mixed global values before dynamic `is_a()` checks, preserving fallback behavior for invalid globals. In branches/2.6, for 2.6.22. Fixes #3783.
[8291] johnjamesjacoby General: Avoid PHP 8.6 type-check deprecations. Use `is_int()` after successful front-end profile updates, preserving existing edit and redirect behavior. Use `instanceof` for fixed-class object checks, preserving existing validation behavior without passing strings to `is_a()`. Guard mixed global values before dynamic `is_a()` checks, preserving fallback behavior for invalid globals. In trunk, for 2.7. See #3783.
[8290] johnjamesjacoby Tests: Add PHP 8.6 coverage. Add an experimental PHP 8.6 and WordPress trunk combination to the PHPUnit matrix. This exposes compatibility issues without blocking required test results while PHP 8.6 remains in development. In branches/2.6, for 2.6.22. Fixes #3782.
[8289] johnjamesjacoby Tests: Add PHP 8.6 coverage. Add an experimental PHP 8.6 and WordPress trunk combination to the PHPUnit matrix. This exposes compatibility issues without blocking required test results while PHP 8.6 remains in development. In trunk, for 2.7. See #3782.
[8288] johnjamesjacoby Tools: Batch user forum role repairs. Remap forum roles in resumable batches while preserving WordPress role order, filtered mappings, Blocked exclusivity, and membership on the current site. Bound duplicate metadata matches without forcing DISTINCT queries to scan all remaining rows. Verify capability changes and checkpoints before advancing, preserve previews without writes, and keep synchronous automatic runs working on small sites. In trunk, for 2.7. See #3777.
[8287] johnjamesjacoby Tests: Expect unformatted user ID output. Compare user-ID template output with the raw ID string rather than formatting it as a display count. Preserve the existing helper contract and keep these assertions correct when fixtures allocate IDs above 999. In trunk, for 2.7. See #3777.
[8286] johnjamesjacoby Tools: Batch legacy user metadata repairs. Repair legacy favorites and subscriptions with one resumable worker, preserving valid source rows, bounded work, read-only previews, and safe retries. Share verified per-row metadata writes with the three legacy-data cleanup upgrades. Keep unfinished migrations protected by their existing locks and pending state, and prevent cleanup while user metadata remains active engagement storage. Preserve legacy strategy cache invalidation, document per-row cleanup hooks, and keep synchronous small-site automatic upgrades working. In trunk, for 2.7. See #3777.
[8285] johnjamesjacoby Tools: Load forum recounts with the admin includes. Load the shared forum recount worker through the normal admin includes and add its standard direct-access guard. Remove duplicate callback-level includes and relative parent paths. In trunk, for 2.7. See #3777.
[8284] johnjamesjacoby Tools: Batch recursive forum recounts. Recount forum topics, public replies, and non-public replies with one resumable post-order worker. Preserve hierarchy and count filters, bound metadata cleanup, retain canonical rows, and keep interrupted progress safe to retry. Publish restart checkpoints before removing old state, keep previews consistent with Run, and clean up temporary option-cache entries. Share verified state writes with existing checkpoints and preserve synchronous small-site automatic upgrades. In trunk, for 2.7. See #3777.
[8283] johnjamesjacoby Attachments: Require parent access for REST media writes. Require access to an attachment's current bbPress parent before REST updates, deletion, and media processing. Require visibility and edit capability on a new bbPress parent while preserving ordinary WordPress media and unchanged parent values. In branches/2.6, for 2.6.22.
[8282] johnjamesjacoby Attachments: Require parent access for REST media writes. Require access to an attachment's current bbPress parent before REST updates, deletion, and media processing. Require visibility and edit capability on a new bbPress parent while preserving ordinary WordPress media and unchanged parent values. In trunk, for 2.7.
[8281] johnjamesjacoby Tools: Batch topic engagement repairs. Reconcile topic engagements and voice counts in resumable batches with a shared work budget, fixed bounds, and verified checkpoints. Preserve existing source rules, valid relationships, read-only previews, and safe retries. Share relationship queries and row reconciliation with the engagement upgrade. Verify reported metadata writes, calculate voice totals once per batch, and preserve synchronous small-site automatic upgrades. In trunk, for 2.7. See #3777.
← 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 →
Note: See TracReports for help on using and creating reports.