| [6209]
|
xknown
|
branch 1.2: Fix infinite loop when create a new WP_User instance.
See #3033
|
| [6208]
|
xknown
|
branch 1.1: Avoid infinite recursion loop when creating a new WP_User instance.
See #3303
|
| [6207]
|
xknown
|
branch 1.2: Fix PHP 7 compat issues w.r.t. the use of func_get_arg().
func_get_arg() returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
See #3033
|
| [6206]
|
xknown
|
branch 0.9: Fix PHP 7 compat issues w.r.t. the use of func_get_arg().
func_get_arg() returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
See #3033
|
| [6205]
|
xknown
|
branch 1.1: Fix PHP 7 compat issues w.r.t. the use of func_get_arg().
func_get_arg() returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
See #3033
|
| [6204]
|
netweb
|
Unit Tests: Don't run BuddyPress PHPUnit tests on versions less than PHP 5.3.0
BuddyPress 2.8 has dropped support for PHP 5.2.x, this changeset updates the BuddyPress PHPUnit configuration to only run the tests on PHP versions greater than `5.3.0`
See also https://bpdevel.wordpress.com/2016/07/21/php-5-2-bp-2-8-and-php-support-guidelines/
Fixes #3037.
|
| [6203]
|
netweb
|
Build Tools: Add Travis CI cache for installed apt packages.
See #2980.
|
| [6202]
|
netweb
|
Accessibility: Bump headings for BuddyPress group forums.
Props mercime.
Fixes #2968.
|
| [6201]
|
netweb
|
Build Tools: Remove unsupported WordPress versions from Travis CI build job matrix.
This changeset removes all WordPress versions previous to 4.7 as this is now bbPress' minimum required version.
|
| [6200]
|
netweb
|
Metaboxes: Update `@since` revisions for functions introduced in r6197.
See #2959.
|
| [6199]
|
johnjamesjacoby
|
Strings: Add `view_items` text for forums, topics, replies, and topic-tags.
This adds support for a label that is new to WordPress 4.7.
|
| [6198]
|
johnjamesjacoby
|
Users: Use existing WordPress core functions where possible.
* `get_users()` for per-forum moderator setting & getting
* `count_user_posts()` for raw topic & reply counts
* General code clean-up around these parts
|
| [6197]
|
johnjamesjacoby
|
Metaboxes: Add metaboxes for viewing favorites & subscriptions of topics & replies.
* New functions for outputting avatars of users who have favved or subbed
* Use the `$post` parameter that's passed in, rather than using `get_the_ID()` again
* Use `require_once` as a language construct vs. `include_once()` as a function
* Pass `$post` object through to metabox subsequent filters vs just the ID
See #2959.
|
| [6196]
|
johnjamesjacoby
|
Breathing room for all `!is_` usages.
|
| [6195]
|
netweb
|
Converter: Give `!` usages some breathing room.
|
| [6194]
|
netweb
|
Tests: Add favorite, topic subscriptions, and forum subscription upgrade tool tests.
* `BBP_Tests_Admin_Tools::test_bbp_admin_upgrade_user_favorites`
* `BBP_Tests_Admin_Tools::test_bbp_admin_upgrade_user_topic_subscriptions`
* `BBP_Tests_Admin_Tools::test_bbp_admin_upgrade_user_forum_subscriptions`
See #2959.
|
| [6193]
|
netweb
|
Tools: Add an upgrade tool for forum subscriptions.
* Adds `bbp_admin_upgrade_user_forum_subscriptions()`
* Renames `bbp_admin_upgrade_user_subscriptions()` to `bbp_admin_upgrade_user_topic_subscriptions()`
* Updated inline docs
Previously in r6174 upgrade tools were added for favorites and subscriptions, support for migrating forums subscriptions meta `_bbp_forum_subscriptions` wasn't included, rather than adding extra overhead to the existing topic subscriptions upgrade tool another upgrade tool was added for forum subscriptions.
See #2959.
|
| [6192]
|
johnjamesjacoby
|
Fix formatting of query in `bbp_get_user_closed_topic_count()`, introduced in r6191.
|
| [6191]
|
johnjamesjacoby
|
Audit direct query and `prepare()` usages, and more tightly adhere to best practices.
* No quotes around directives
* Avoid concatenation, prefer variable parsing in double-quoted strings
* Covers converters, helper functions, and tools
|
| [6190]
|
netweb
|
Admin: Add missing `@since` revisions from r6186.
|
| [6189]
|
johnjamesjacoby
|
Tools: Use `get_results()`, and don't delete usermeta.
(Maybe we should have a separate clean-up tool once it's confirmed to be OK.)
See #2959.
|
| [6188]
|
johnjamesjacoby
|
Tools: Avoid duplicate entries for favorites & subscriptions.
This fixes a bug in the 2.6.0 upgrade routine where running the tool multiple times could add duplicate metadata.
See #2959.
|
| [6187]
|
johnjamesjacoby
|
Admin: Add missing `@param`'s from r6186.
|
| [6186]
|
johnjamesjacoby
|
Admin: Implement new loading sequence for major admin components.
* Introduce new `bbp_current_screen` sub-action
* Hook forums/topics/replies into `bbp_current_screen`
* Remove various `bail()` methods, which were fragile and terrible anyways
* Revert r6178, thanks to order-of-operation issues with `get_current_screen()`
* Remove Comments & Discussion metaboxes if `comments` is not explicitly supported
See #2959.
|
| [6185]
|
johnjamesjacoby
|
Labels: Prefer "Add New" over "New Thing".
|
| [6184]
|
johnjamesjacoby
|
Converter: Convert favorites & subscriptions to `postmeta` vs. `usermeta`.
* Update table names
* Support for comma-separated string values
* Use strict comparisons where it makes sense to
See #2959, #2668.
|
| [6183]
|
johnjamesjacoby
|
Core: Upgrade routine for favorites & subscriptions in 2.6.0.
* Use the new upgrade tools
* Bump the DB version to `260`
* Improve inline docs in upgrade tool functions
See #2959.
|
| [6182]
|
johnjamesjacoby
|
Tools: Explicitly pass `false` into `add_post_meta()`'s `$unique` parameter.
Though it's the default, we can't make any mistake that meta-key's to be non-unique for this to function correctly.
See #2959.
|
| [6181]
|
johnjamesjacoby
|
Tools: Use `explode()` instead of `maybe_unserialize()`.
User-meta values were strings to enable `FIND_IN_SET()` usages.
See #2959.
|
| [6180]
|
johnjamesjacoby
|
Extend: Consolidate some BuddyPress hooks to the top of each file.
|
| [6179]
|
netweb
|
Build Tools: `.jshintrc` is a JSON file, indentation should use spaces, not tabs, and lastly have `.editorconfig` treat `jshintrc` as a JSON file.
|
| [6178]
|
johnjamesjacoby
|
Tools: Update forum/topic/reply admin classes to avoid screens without `post_type` parameters.
Fixes edge-case debug notices when tools pages for third-party plugins are doing advanced things.
See #2959.
|
| [6177]
|
johnjamesjacoby
|
Tools: Update tools text to include favorites & subscriptions.
See #2959.
|
| [6176]
|
johnjamesjacoby
|
Tools: Massize clean-up
* Add missing function documentation blocks
* Rename `_migrate_` function to `_upgrade_`
* More typo fixes
* Make `overhead` values clickable in list table rows
* Refactor `overhead` to work more like `components`, using keys instead of literal strings
See #2959.
|
| [6175]
|
johnjamesjacoby
|
Tools: Use `$total` count in `bbp_admin_migrate_user_favorites()`.
Also update revision number in function docs.
See #2959.
|
| [6174]
|
johnjamesjacoby
|
Tools: First pass at upgrade tools for favorites & subscriptions.
* Registers 2 new repair tools
* Includes basic looping patterns for user-meta to post-meta
Needs testing and scrutiny.
See #2959.
|
| [6173]
|
johnjamesjacoby
|
Tools: Add classes & data attributes to improve responsiveness.
|
| [6172]
|
johnjamesjacoby
|
Extend: Fix a typo in docs.
|
| [6171]
|
xknown
|
branch 0.9: Silence signature mismatch notices.
In PHP 7.0, they are reported as warnings http://php.net/manual/fr/migration70.incompatible.php#migration70.incompatible.error-handling.strict
See #3033
|
| [6170]
|
xknown
|
branch 0.9: Silence signature mismatch notices.
In PHP 7.0, they are reported as warnings http://php.net/manual/fr/migration70.incompatible.php#migration70.incompatible.error-handling.strict
See #3033
|
| [6169]
|
johnjamesjacoby
|
Tag bbPress 1.2.1 which adds some basic PHP7 compatibility. See #3033
|
| [6168]
|
xknown
|
Update the backpress svn external to http://backpress.svn.wordpress.org/tags/backpress-1.2.1-bbpress/
See #3033
|
| [6167]
|
xknown
|
Branch 1.2: Fix PHP 7 compat issues w.r.t. the use of `func_get_arg()`.
`func_get_arg()` returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
See #3033
|
| [6166]
|
xknown
|
Fix PHP7 parse error.
The result of `new` can't be longer assigned by reference.
See #3033
|
| [6165]
|
xknown
|
Branch 1.2: Fix PHP 7 compat issue.
- `func_get_arg()` returns the current (modified) value of the given argument.
- Add also PHP 5.x style constructors.
See #3033
|
| [6164]
|
xknown
|
Add PHP 5.x style constructors.
Keep also the PHP 4.x style constructors to avoid breaking code that depends on these methods.
See #3033
|
| [6163]
|
xknown
|
Branch 1.2: Fix parse errors in PHP 7
The result of new can't be longer assigned by reference.
See #3033
|
| [6162]
|
xknown
|
Branch 0.9: Remove all the expressions that use the `preg_replace` function with the `e` modifier.
The `e`(val) modifier is not longer supported in PHP7, use `preg_replace_callback` instead.
See #3033
|
| [6161]
|
xknown
|
Branch 0.9: Use `preg_match` instead of `ereg`
See #3033
|
| [6160]
|
xknown
|
Branch 0.9: Fix PHP 7 compat issues w.r.t. the use of `func_get_arg()` and PHP 5.x constructors.
- `func_get_arg()` returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
- Add PHP 5.x style constructors.
- Use `preg_match` instead of `eregi`
See #3033
|
| [6159]
|
xknown
|
Branch 0.9: Fix PHP 7 compat issues w.r.t. the use of `func_get_arg()`.
`func_get_arg()` returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
See #3033
|
| [6158]
|
xknown
|
Branch 0.9: use a more recent version of add_query_arg which reduces the use of `func_get_arg`.
See #3033
|
| [6157]
|
xknown
|
Add PHP 5.x style constructors.
Keep also the PHP 4.x style constructors to avoid breaking code that depends on these methods.
See #3033
|
| [6156]
|
xknown
|
Fix PHP 7 compat issues w.r.t. the use of `func_get_arg()`.
`func_get_arg()` returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
See #3033
|
| [6155]
|
xknown
|
Fix PHP7 parse error.
The result of `new` can't be longer assigned by reference.
See #3033
|
| [6154]
|
xknown
|
Fix PHP 7 compat issue.
- `func_get_arg()` returns the current (modified) value of the given argument. Let's make sure the code is compatible with older PHP versions.
- Add also PHP 5.x style constructors.
See #3033
|
| [6153]
|
xknown
|
Add PHP 5.x style constructors.
Keep also the PHP 4.x style constructors to avoid breaking code that depends on these methods.
See #3033
|
| [6152]
|
xknown
|
Fix parse errors in PHP 7
The result of `new` can't be longer assigned by reference.
|
| [6151]
|
johnjamesjacoby
|
Update trunk readme.txt with updated version & changelog for 2.5.12.
|
| [6150]
|
johnjamesjacoby
|
Tag 2.5.12.
|
| [6149]
|
johnjamesjacoby
|
bbPress 2.5.12 requires WordPress 4.7, as will bbPress 2.6 and higher.
|
| [6148]
|
johnjamesjacoby
|
Bump to 2.5.12.
|
| [6147]
|
johnjamesjacoby
|
Roles: Port `bbp_roles_init()` from trunk to 2.5 branch. See: #3028.
|
| [6146]
|
netweb
|
Moderation: Add some missing PHPDoc `@since` revisions
See #3032.
|
| [6145]
|
netweb
|
Build Tools: Travis CI: Only test PHP 7.1 against WordPress 4.7 or greater
This changeset updates the Travis CI test matrix to match WordPress' PHP 7.1 compatability, which was only added in version 4.7.
|
| [6144]
|
johnjamesjacoby
|
Whitespace removal.
|
| [6143]
|
johnjamesjacoby
|
Topics: Break apart some lengthy inline conditions. See #3032.
|
| [6142]
|
johnjamesjacoby
|
Moderation: First pass at improved topic toggle actions:
* Allow custom toggles, or replacement of existing toggles with new procedures
* Introduce a handful of actions & filters to enable the above
* Separate functionality into smaller, more manageable parts.
See #3032. (Forums @todo)
|
| [6141]
|
johnjamesjacoby
|
Even less shouting, plus a grammar sweep.
* Remove contractions
* Update weird sounding English phrases (like "the permissions" to "permission")
* Simplify some phrases to be less wordy
* Update "permission" error codes to all use "permission" instead of also "permissions"
* Add comma to "Oh bother!". See: https://www.youtube.com/watch?v=Fhl4oKvxphs
|
| [6140]
|
johnjamesjacoby
|
Stop shouting at everyone!
|
| [6139]
|
johnjamesjacoby
|
Moderation: /s/exists/missing
See #3032.
|
| [6138]
|
johnjamesjacoby
|
Moderation: Add error message if reply could not be found or no longer exists.
See #3032.
|
| [6137]
|
johnjamesjacoby
|
Moderation: Pass `$reply_id` into `bbp_get_reply_toggles()` so the exacty reply ID can be referenced directly at the time of the filter.
See #3032.
|
| [6136]
|
johnjamesjacoby
|
Moderation: Move `sub_action` query var into a passable argument, so all actions can have reliable sub-action usage.
See #3032.
|
| [6135]
|
johnjamesjacoby
|
Tools: Fix undeclared variables and incorrect variable types, for improved PHP 7.1 compatibility.
This will quiet down most of our continuous integration noise.
Props hellofromTonya. Fixes #3031.
|
| [6134]
|
johnjamesjacoby
|
Moderation: Rename function to `bbp_get_reply_toggles()` to better match existing naming scheme.
See #3032.
|
| [6133]
|
johnjamesjacoby
|
Moderation: First pass at improved reply toggle actions:
* Allow custom toggles, or replacement of existing toggles with new procedures
* Introduce a handful of actions & filters to enable the above
* Separate functionality into smaller, more manageable parts.
See #3032. (Forums & Topics @todo)
|
| [6132]
|
netweb
|
Build Tools: Add PHP 7.1 to the Travis CI job matrix and remove from `allow_failures` list
|
| [6131]
|
netweb
|
Build Tools: Add WordPress 4.7 to Travis CI build matrix
|
| [6130]
|
johnjamesjacoby
|
Converter: Set maximum key index length to 191.
Fixes bug where table would not be created because `utf8mb4` character sets do not have room for that many bytes.
(Also, pass query as an array into `dbDelta()` so it doesn't need to do the work for us anymore.)
See #3026. (2.5 branch, for 2.5.12)
|
| [6129]
|
johnjamesjacoby
|
Converter: Set maximum key index length to 191.
Fixes bug where table would not be created because `utf8mb4` character sets do not have room for that many bytes.
(Also, pass query as an array into `dbDelta()` so it doesn't need to do the work for us anymore.)
See #3026. (Trunk, for 2.6)
|
| [6128]
|
johnjamesjacoby
|
Whitespace for "Screenshots" section of readme.txt.
|
| [6127]
|
johnjamesjacoby
|
Update trunk readme.txt for 2.5.11 release.
|
| [6126]
|
johnjamesjacoby
|
Tag bbPress 2.5.11.
|
| [6125]
|
johnjamesjacoby
|
Shh... I meant `bbp_translate_user_role()`.
See r6121.
|
| [6124]
|
johnjamesjacoby
|
Use new `bbp_translate_role_name()` function in `bbp_get_dynamic_role_name()`. For 2.5 branch (2.5.11)
|
| [6123]
|
johnjamesjacoby
|
Update `bbpress.pot` for 2.5 branch (for 2.5.11)
|
| [6122]
|
johnjamesjacoby
|
Bump 2.5 branch to 2.5.11.
Also add changelog to readme.txt.
|
| [6121]
|
johnjamesjacoby
|
Reference correct hook name in docs. Props netweb. See r5945.
|
| [6120]
|
johnjamesjacoby
|
Roles: Fix infinite loops from load order changes in WordPress 4.7.
* Do not translate "role names" which are actually role IDs
* Add dummy function so literal role names are part of the pomo dictionary
* Introduce `common/locale.php` for future localization code
* Introduce `bbp_translate_user_role()` to help with outputting literal role names in the proper language
See #3017. 2.5 branch (for 2.5.11)
|
| [6119]
|
johnjamesjacoby
|
Theme Compat: Support `WP_Hook` class in 2.5 branch.
See #2871, r5945.
|
| [6118]
|
johnjamesjacoby
|
Roles: Fix infinite loops from load order changes in WordPress 4.7.
* Do not translate "role names" which are actually role IDs
* Add dummy function so literal role names are part of the pomo dictionary
* Introduce `common/locale.php` for future localization code
* Introduce `roles` variable to main bbPress class, and store loaded roles there
* Introduce `bbp_translate_user_role()` to help with outputting literal role names in the proper language
See #3017. For trunk (2.6)
|
| [6117]
|
netweb
|
Build Tools: Update `grunt-contrib-uglify`.
Update uglify-js to v2.7.0. `screwIE8` is enabled by default.
See https://github.com/gruntjs/grunt-contrib-uglify/compare/v1.0.2...v2.0.0
|
| [6116]
|
johnjamesjacoby
|
Roles: Remove overzealous usages of `bbp_add_forums_roles()`.
Now that the `wp_roles_init` action exists, we can rely on bbPress roles being registered an available, and no longer need to re-reinitalize them before trying to interact with them.
See: #2959.
|
| [6115]
|
netweb
|
Indentation fixes, tabs, not spaces.
|
| [6114]
|
netweb
|
Users: Include users closed topic counts in `bbp_get_user_topic_count_raw()`
This changeset works around an issue where the lack of custom post statuses support upstream in #WP12706 prevents us from including users closed topics counts in a users raw topic count. See also #meta1870
Props netweb.
Fixes #2978.
|
| [6113]
|
netweb
|
General: Set the default return to an empty array in `$posts_query->get()` in `bbp_pre_get_posts_normalize_forum_visibility()`
This changeset fixes PHP 7.1 warnings `[] operator not supported for strings` due to `WP_Query:get()` defaulting to returning an empty string if the requested key isn't set. However, you can pass a default return value. This commit sets the default return to an empty array.
Props thebrandonallen.
Fixes #2987.
|
| [6112]
|
netweb
|
Theme Compatibility: Parameter `$in_footer` in `bbp_enqueue_script()` should be boolean.
This changeset updates copy-pasta introduced in [5181], `bbp_enqueue_script()` is a wrapper for `wp_enqueue_script()`, `$in_footer` boolean parameter introduced in wp:changeset:10367. Whether on purpose, or inadvertently, our scripts where being added in the footer, this commit explicitly maintains this behavior.
Props thebrandonallen.
Fixes #3013.
|
| [6111]
|
netweb
|
Users: Update PHPDoc's for user functions and capabilities.
See #2959.
|
| [6110]
|
netweb
|
Tests: Use `assertEqualSets()` instead of `assertEquals()` in favorites and subscriptions tests.
This changeset improves array comparisons where arrays may not be in the same order.
See #2959.
|