Skip to:

{33} Commit Messages, Current Release (4440 matches)

Report designed to help manage the list of contributors.

Note: If you'd like a RSS feed of the changesets a they happen, Please use the timeline rss feed instead.

Results (301 - 400 of 4440)

1 2 3 4 5 6 7 8 9 10 11 12 13 14
Changeset Author Message
[6603] johnjamesjacoby Admin: buzz & swoop.
[6602] johnjamesjacoby Admin: Remove obscure 'About bbPress' admin-bar link. Nobody ever really used it, and less is more in this case.
[6601] johnjamesjacoby Admin/Converter: Lazy load admin & converter as needed. * Move admin class into its own file * Remove `admin.php` * Introduce `_setup_` functions to make loading them on the fly easier * Simplify converter logic for smoother starting/stopping * Improved UI for timer/status updates * Remove double-duty variables from `BBP_Converter` and response data * Switch from text-only response value to JSON object for improved flexibility This allows the converter to return more data, and makes it easier to work with that data. Todo: * Error responses * Check that starts are bumping correctly inside of steps * Better utilize JSON responses
[6600] johnjamesjacoby Converter: Add `halt` setting for stopping the importer when an error occurs. Next: implement in Converter.
[6599] johnjamesjacoby Converter: Default values to `0` so converter starts correctly.
[6598] johnjamesjacoby Styling: No border on forums links. An increasing number of themes are putting borders on links by default to simulate an underline, which causes every link in the forums to be styled in unanticipated ways. This changeset ensures that links in the entry-content section in forums do not have faux-underlines or excessive attention drawn to them.
[6597] johnjamesjacoby Tag 2.6 RC 4.
[6596] johnjamesjacoby Bump to 2.6 RC 4.
[6595] johnjamesjacoby Bump the asset version to latest revision.
[6594] johnjamesjacoby Users: Offer the login form in place of topic/reply forms if user is logged out.
[6593] johnjamesjacoby Tools: Use `delete_metadata()` to remove favs & subs without a `foreach` loop.
[6592] johnjamesjacoby Users: Add `user_url`, `user_registered`, and last-active to profiles. Also divide profile page up into 2 sections: Profile & Forums.
[6591] johnjamesjacoby Authors: Rejig author link functions. * Allow for easier filtering of link sections * Update default arguments to remove no-break space and `<br>`, and rely on styling instead * Surrounding code clean-up * Add escaping to display names in links
[6590] johnjamesjacoby Styling: No text shadow on editor buttons.
[6589] johnjamesjacoby Styling: Bump assets version & remove prefixes from default.css. Prefixes are put back during build.
[6588] johnjamesjacoby Styling: Clean-up default styling to pass style linting rules.
[6587] johnjamesjacoby Styling: Flatten the editor buttons, and force fieldset legend width & border. This improves default theme compatibility.
[6586] johnjamesjacoby 404: Use `! empty()` over `isset()` to only account for `true` values in `bbp_is_404`. This fixes broken `/edit/` theme-side URLs, that will redirect otherwise.
[6585] johnjamesjacoby Cache: make `bbp_clean_post_cache()` an action-only function. Instead of calling `bbp_clean_post_cache()` directly, we'll call `clean_post_cache()` as per normal and hook `bbp_clean_post_cache()` to the end of it. This reduces a bunch of superfluous cache invalidation from occurring back-to-back. We'll also only ever update the `last_changed` cache key when we've reached the forum-root. This makes sure that subsequent recursive calls up the `post_parent` tree are dealing with the same `last_changed` value until the end. This change will reduce the number of cache invalidation calls by a large amount, improving functional performance for database writes to the post & postmeta tables.
[6584] johnjamesjacoby Tests: Remove debug cruft from r6583.
[6583] johnjamesjacoby Better 404 handling: * Introduce `bbp_is_404` query var, and set this in places where the default 404 condition needs to be overridden * Introduce `bbp_set_200()` for cases where a default of 404 needs to be set to a 200 * Introduce `bbp_get_wp_query()` helper for getting the `$wp_query` global * Update `bbp_set_404()` to accept a `$query` parameter to make passing the query around easier * Update child-ids queries to use the `last_changed` cache to reduce the amount of cache churn when cleaning Fixes #3047. See #1973.
[6582] johnjamesjacoby Globals: Use `bbp_get_global_object()` instead of touching `$wp_query` directly in template functions.
[6581] johnjamesjacoby Ajax: in `bbp_do_ajax()` use `wp_die()` instead of `die()` so any custom handlers are used.
[6580] johnjamesjacoby Documentation: Typo fixes in users functions.
[6579] netweb Humans: I like tacos 🌮
[6578] johnjamesjacoby Theme: Put back vendor prefixes in default template pack styling.
[6577] netweb Build Tools: Update Autoprefixer supported browser matrix. Following WordPress' implementation this new version hard codes IE 11 as a minimum, otherwise specifies either last 2 or last 1 based on
[6576] johnjamesjacoby Forums: Use `bbp_get_forum_subforum_count()` in `bbp_forum_get_subforums()`. This performance optimization will result in 1 less query per forum in the forums list that does not have subforums, by checking the subforum meta-data before trying to query for subforums that do not exist anyways. This is less of an issue with a persistent object cache, but those without that luxury can now save those database queries for when they really matter.
[6575] johnjamesjacoby Super Moderators: prefer `edit_user` with an ID over `edit_users` without one. This change makes sure we know exactly which user ID the user is trying to edit. In cases where there is no ID available, we'll try to guess at the displayed user ID, and if that's empty too, we'll do nothing. This allows the "User Role" template part to load properly for Super Moderators.
[6574] johnjamesjacoby Super Moderators: Compare the user ID to `$args[0]` instead. This change makes sure the proper user IDs are compared, and also prevents super moderators from editing Keymasters (demotions can't come from users with a less capable role than their own.)
[6573] johnjamesjacoby Documentation: Remove all `@uses` usages. Per the WordPress inline documentation standards: > the @uses tag is not recommended to be used to indicate a used-by relationship, as this information can be derived through other means. These tags also are very likely to become out-of-date as our functions change over time.
[6572] johnjamesjacoby Super Moderators: First pass at mapping the meta-capabilities. This change hooks-up the ability for moderators to edit other users if the super moderator ability is allowed. <3
[6571] johnjamesjacoby Capabilities: Logic improvements to help with per-forum moderation. * Introduce `moderate_forum` capability check, used to check if a user has the ability to moderate a specific forum * Limit number of direct `keep_gate` checks, and use `bbp_is_user_keymaster()` where possible * Make `bbp_is_user_forum_moderator()` check the new `moderate_forum` mapped capability * Have the `moderate` mapped capability check `moderate_forum` if the `$args[0]` can be bubbled up to being a forum ID * Map admin post-type areas to their appropriate `edit_` capabilities – they are now properly handled via other mapped conditions This change (along with r6567 & r6569) allows private & hidden forums to appear in forums queries for users who can moderate them.
[6570] johnjamesjacoby Tests: Update forum visibility tests to use both approaches: * Forum was created with a private/hidden status * Forum was created public, but later changed to private/hidden See r6569.
[6569] johnjamesjacoby Tests: Update private/hidden options on `bbp_insert_forum()` calls. This makes sure that tests pass when creating & toggling forum visibilities, fixing some tests related to private & hidden forum IDs and counts.
[6568] johnjamesjacoby Revert part of r6567, and instead skip the page condition completely. This makes sure that forms are made available to moderators regardless of the page condition, and fixes a situation where per-forum moderators couldn't publish to forums or topics that were closed.
[6567] johnjamesjacoby Users: Check for ability to edit before falling back to `publish`. This change prioritizes a user's ability to edit a forum/topic/reply over the fallback to the ability to publish, allowing per-forum moderators the ability to access the relative theme-side forms.
[6566] johnjamesjacoby Adimn: Fix some formatting in PHPDoc blocks.
[6565] johnjamesjacoby Authors: Use `bbp_get_fallback_display_name()` instead of "Anonymous". This change uses the new function introduced in r6562 to allow the fallback display name to be filtered, and passes the relative topic or reply ID in for additional context.
[6564] johnjamesjacoby Settings: Use `$this->minimum_capability` in options page filter method. This change keeps the filter inline with the mapped meta caps, should the minimum capability be renamed or changed.
[6563] johnjamesjacoby Moderators: Introduce "Super Moderators" setting. This change introduces the option (and default off value), admin setting and UI for toggling it on and off. A "Super Moderator" is a moderator with the ability to also edit users, a commonly requested and popular feature in other forum software. The use-case is that user accounts may be spammers and need to be moderated beyond just their topics & replies, but the `edit_users` capability is reserved for Administrators (or Super Admins in multisite.) This setting will act as the global on/off to the deeper implementation of this feature.
[6562] johnjamesjacoby Users: Audit user template functions. * Additional late escaping on meta-data return values where they are surrounded by HTML markup * Introduce helper function for filtering & returning the 'Anonymous' fallback display name (we'll use this through-out the existing author name fallbacks) * Use more internal helpers & handlers where they are available
[6561] johnjamesjacoby Capabilities: Skip double checks in `bbp_is_user_inactive()`, and use `bbp_get_user_id()` in `bbp_is_user_keymaster()`. This change cleans up a few user capability functions, to use internal handlers and allow filters (like `bbp_get_user_id`) to be applied as expected in the given context.
[6560] johnjamesjacoby Docs: Update inline documentation of `bbp_get_global_object()`. The conditions in this function do not result in an early return, so remove "Bail" references.
[6559] johnjamesjacoby Forums: Use `edit_forum` instead of `keep_gate` in the admin toggle/row methods. This change trusts the `edit_forum` meta capability to serve it's intended purpose. It also allows more flexibility with things like BuddyPress Group Forums or custom forum-ownership style extensions.
[6558] johnjamesjacoby Passwords: Upgrade the user-edit experience to use the new'ish password generator. * Introduces new `form-user-passwords.php` template part to encapsulate the more-elaborate password mark-up * Removes `user.js` from the default scripts, and enqueues `user-profiles` instead * Requires tweaks to the default template pack styling to accommodate the password generator being theme-side This change will also allow bbPress to more easily keep-up with changes to the password generator code that comes with WordPress going forward. Huzzah!
[6557] johnjamesjacoby Forms: Add `maxlength` attribute to the appropriate form fields. Fields like `user_login`, `user_url`, and `user_email` have upper boundaries that cannot be extended via meta-data or other means, so let's make sure users aren't (easily) able to go over them. For the anonymous user fields, set them up to match comment field lengths (even though they are stored in `postmeta`.)
[6556] johnjamesjacoby Forms: formally update password change text. It was accidentally partially changed in r6555.
[6555] johnjamesjacoby Forms: Add `autocomplete` attribute to user related form fields. `autocomplete="new-password"` is new, and browser support is gaining, but it's also not any worse than `autocomplete="off"` (where most browsers & password managers have a hard time respecting the etiquitte anyways.)
[6554] johnjamesjacoby General: Introduce `bbp_pre_handle_404()` to handle 404 overrides. This only introduces the function for now. I'll go through and check all of the conditions next. See #3047.
[6553] johnjamesjacoby Replies: Do not update term cache in `bbp_has_replies()`. This change removes 2 unnecessary database queries from single topic pages. In situations where the leading topic is gathered as part of the `bbp_has_replies()` loop, this still functions as anticipated, and the original topic loop query will handle updating the term cache appropriately.
[6552] johnjamesjacoby Pass `$type` into favs & subs link arguments. Missed in r6551.
[6551] johnjamesjacoby Theme Compat: Improve loading & support for external template packs. * Better error handling if tempate pack is broken, unloaded, or missing * Consolidate favs & subs code to use the same central handlers, by passing an `object_id` and `object_type` around (for future support of term subscriptions) * Rename data addtributes from previous BuddyPress favs & subs fixes * Adjust load order of template pack setup so that it's as late as possible, allowing template pack authors more time to get registered * Automatically add the current template pack to the template stack (multiple packs can still be layered, and this improves support for that) * Merge `topic.js` and `forum.js` in "bbPress Default" template pack to use the same `engagements.js` script, which simplifies localization & uses 1 less script between pages This change puts the finishing touches on favs & subs consolidation for 2.6, and updates several related & surrounding functions to better support the necessary mark-up changes.
[6550] johnjamesjacoby BuddyPress: Remove favs & subs from correct `bbp_get_request` action.
[6549] johnjamesjacoby Theme Compat: Update `bbp_get_query_template()` to work a bit more simply. This change removes using the returned results from the stash functions, and uses the local variables instead.
[6548] netweb Build Tools: Bump slow tests threshold for multisite to 250 for now, and we can continue to bring this value down as test performance is improved.
[6547] johnjamesjacoby Statuses: Update `Closed` status arguments in `register_post_status()` call. This makes sure posts with a closed status appear in the status and all listings.
[6546] johnjamesjacoby Replies: Add `single_row()` method to replies list table when editing a topic. This lets us use `get_post_class()` on the table rows, so statuses like `pending` or `spam` can be properly in the list for users who have the capability to see them. See #2587.
[6545] johnjamesjacoby Forums: Use `no_found_rows` by default in `bbp_has_forums()` Forums do not currently support pagination, so the total number of rows is not traditionally useful for this loop. In cases where it is, it can be explicitly overloaded in the `$args` array. This results in 1 less database query per page where a forums list is shown, and a speed improvement overall.
[6544] johnjamesjacoby Performance: Last pass at 2.6 performance tuning. * Keep a local cache of non-options that aren't in the database, to avoid multiple database misses for options we know aren't in the database after `wp_load_alloptions()` is called * Stop getting all favorite IDs and subscription IDs when checking if a user has favorited or subscribed to something, because these queries are expensive joins that are difficult to cache & invalidate * Consolidate forum/topic favorites & subscriptions logic back into central routers, to make it easier to handle taxonomy term subscriptions in the future, and remove nested filter calls that make the call-stack confusing * Informally deprecate some forum & topic specific fav/sub functions * Rename one of the engagements remove functions to better match existing naming pattern * Typo fixes & general code quality improvements * Bump slow tests threshold up to `500` for now, and we can bring back down later (my 12" MacBook runs this pretty slowly, so I'd like to play with this more) * Unit tests are all passing, and more quickly, maybe surprisingly This should result in around 20 fewer database hits on non-persistent-cache sites, on average. When viewing single topics & replies, this will result in more than 25 fewer database hits.
[6543] johnjamesjacoby Statistics: Define the `$statistics` array. This change prevents debug notices, particularly in higher PHP versions (+7.0) See #2770.
[6542] johnjamesjacoby Statistics: Improvements to "At a Glance" integration. * Prefer `bbp_get_total_users()` over `count_users()` to speed up loading * Don't include empty array values * Don't link to areas the current user cannot access * Skip if current user cannot at least spectate (blocked or no access) Fixes #2770.
[6541] johnjamesjacoby BuddyPress: Continuation of r6538. * Prefer data attributes * Stop passing around localized nonces Props r-a-y. Fixes #3114.
[6540] johnjamesjacoby Update recent JavaScript formatting changes so they comply with our JSHint rules.
[6539] netweb Updated admin base SCSS styles: * `_admin.scss` via WP:changeset:40576 * `_mixins.scss` via WP:changeset:38501 See #2583
[6538] johnjamesjacoby BuddyPress: Favorites & Subscriptions AJAX improvements * Pass a data attribute along with links * Sanitize `action` key when passed into AJAX action hook * Send a `200` response code This commit allows favorite & subscription links to work with AJAX in BuddyPress group forums pages. Props r-a-y. Fixes #3114
[6537] johnjamesjacoby Tools: Improvements to repair, upgrade, and converter tools. * Use escaped gettext equivalent functions where appropriate * Rename `description` to `title` so that more descriptive descriptions can be used per-tool in a future version * Register all scripts, and properly enqueue them only a needed * Reorder & re-title some tools to better match each other
[6536] johnjamesjacoby Tag 2.6 RC 3. (RC 2 is a private/internal pre-release)
[6535] johnjamesjacoby Bump trunk to 2.6 Release Candidate 3.
[6534] johnjamesjacoby Engagements: Revert part of r6525, and adjust some actions. * Engagements will need to be "public only" for 2.6, and we can reconsider what private/hidden engagements look like later * Make sure that engagements are saved before voice counts are done * Use new `is_public` style wrapper function for topics & replies where appropriate * Remove a few `current_filter()` checks that should no longer be necessary with current action hook implementation * There may be more clean-up necessary here, but this is required to bring all unit-tests back to passing as they've been written, specifically things hooked to the `bbp_insert_topic` and `bbp_insert_reply` hooks See #3068. Hat-tip netweb.
[6533] johnjamesjacoby Update phpdoc block of `bbp_is_topic_public()`. Include reference to new `bbp_get_public_topic_statuses()` function.
[6532] johnjamesjacoby Fix accidentally inverted inline doc from r6531.
[6531] johnjamesjacoby Core: Register, then enqueue, both scripts and styles. This commit makes sure that theme compatibility styles & scripts are properly registered & enqueued. Props r-a-y. Fixes #3115.
[6530] johnjamesjacoby Engagements: Update topic engagements when they are manually inserted. This brings the `_insert_` functions up to date with the `_new_` equivalents. See: #3068. Props netweb & unit-tests for catching this.
[6529] johnjamesjacoby Engagements: Keep topic engagement counts up-to-date. This changes the way the old 'voice count' works with the new engagements API in the following ways: * Introduce new function to update voice count meta when necessary * Modify recalculation function with a `$force` parameter, and only recalculate the counts when the engagements have changed by default * Hook the above functions in where appropriate, largely when deleting replies (this is a unique case where a fully deleted reply needs to check if the author of the current reply has a previously public reply in that same topic already, which should not trigger a recalculation.) * We are silently moving the `bbp_delete_` actions onto the `before_delete_post` hook, so that all term & meta-data is available to them (which helps with race conditions mentioned in r6528) Engagements are now hooked in and listening in the most efficient way possible, at least until a common & shared walker is introduced for the entire tree. See: #3068.
[6528] johnjamesjacoby Hierarchy: Use `post_parent` when not empty, and fallback to meta-data. This fixes a few weird inconsistencies with how deleting content works, because `delete_` hooks fire after meta & terms have already been deleted from the database, `deleted_` hooks fire after the post itself is deleted from the database, but the post object cache has not yet been cleaned (even though term & meta caches have.) We also call a few functions like `bbp_is_reply()` on the deleted `$postid`, and even though the state of the object-cache should not be relied on, it has not been purged yet. Relatedly, updates to forum & topic descriptions can more reliably identify their state, so this commit adjusts some logic there also.
[6527] johnjamesjacoby Styling: Improve theme compatibility of avatars & content areas in default themes. This makes sure that avatars in forum & topic descriptions are always horizontally centered, are not accidentally turned into block-elements by parent-theme `img` styling, and that content areas always occupy the full width of their parent element.
[6526] johnjamesjacoby Documentation: Don't use `reply's`, because it looks weird and is poor English grammar. Prefer more descriptive documentation instead.
[6525] johnjamesjacoby Engagements: Tracking is not just for public or closed topics. This commit updates the engagement upgrade tool and recalculation helper functions to not be limited to public & closed post statuses. Engagements can happen on private or hidden topics also, including trash, spam, and so on. The non-visible topics that a user is engaged in should be filtered out as needed when queried based on `post_status` or other various meta-data. See #3068.
[6524] netweb Tests: Use updated filename `upgrade.php` following renamed file in [6500]
[6523] johnjamesjacoby Tools: Audit repair & upgrade tools. * Use escaped gettext variant functions where applicable * Use Query/Prepared/Results paradigm for direct database queries for easier step-through debugging * Fix a few small bugs in the engagements upgrade functions (none that affect 2.5 or beta/RC users) * General code formatting improvements and typo fixes
[6522] johnjamesjacoby Engagements: Introduce 2 new functions for recalculating engagements. * `bbp_get_topic_engagements_raw()` to efficiently query for users who have engaged in a topic * `bbp_recalculate_topic_engagements()` to update all of the related meta-data See #3068.
[6521] johnjamesjacoby Engagements: Update phpdoc for `bbp_add_user_to_object()`. * Replace `add_post_meta()` with `add_metadata()` See #3068.
[6520] johnjamesjacoby Engagements: Updates to phpdoc & helper functions. * New function to remove all users from an object * New function to remove all users from all objects * Remove references to taxonomy term storage (from original implementation) * Update phpdoc with more accurate descriptions of intended parameter usages See #3068.
[6519] johnjamesjacoby Moderators: Add an `$object_type` parameter to add/remove/delete functions. In a future release, this will more easily allow objects like taxonomy-terms to have their own moderators, and is also necessary for future enhancements to the support forums where custom taxonomies are used for prevalently than in bbPress core currently. See #3068, #459.
[6518] johnjamesjacoby Engagements: Update `bbp_add_user_object()`. * New phpdoc description * Add `$unique` parameter and default to `true` (this differs from the normal `false` default of `add_metadata()` because, by default, this API assumes no 1 user can have multiple relationships with the same object) * Pass `$unique` into `apply_filters()` See #3068.
[6517] johnjamesjacoby Engagements: Introduce `bbp_remove_user_from_all_objects()`. This is useful for when a user is permanently deleted, or when all of their relationship(s) (of a certain type) need to be removed. See #3068.
[6516] johnjamesjacoby Engagements: Update `bbp_update_topic_voice_count()` to only count the number of existing engagements. Recalculating the entire engagement tree for each topic is costly, should be done in its own dedicated function, and then only hooked in or executed when absolutely necessary. This is easier to do with the engagements API that's new in 2.6. Recalculation function imminent. See #3068.
[6515] johnjamesjacoby Engagements: Remove duplicate type castings from return values. This removes `(bool)` usages where there is no way the return value would ever not be a boolean.
[6514] johnjamesjacoby Converter: Port changes proposed for 2.7 in for 2.6: * Add a timer UI to show the count down until the next step * Move converter settings into the normal options & settings arrays * Update fields, sections, & pages as needed * Update `converter.js` version to use `bbp_get_version()` * Make connection & options persistent across requests whenever possible, and trust the settings if settings change * Split steps up into private methods, out of the massive `do_steps()` method
[6513] johnjamesjacoby Tools: Use escaping gettext functions in admin area Reset Tool.
[6512] johnjamesjacoby Users: Sanitize name, email, and website in `bbp_filter_anonymous_post_data()`. 2.5 branch, for 2.5.13.
[6511] johnjamesjacoby Tag 2.6 RC 1.
[6510] johnjamesjacoby RC 1, not 3. See r6509.
[6509] johnjamesjacoby Bump trunk to 2.6 Release Candidate 1! 🐝
[6508] johnjamesjacoby Rename `base_dir` to `basepath` for consistency.
[6507] johnjamesjacoby Languages: Deprecate custom bbPress `/languages/bbpress/` directory. * It's still supported if it exists, otherwise it's skipped. * Introduce new `base` property to the `bbPress` class to help with targeting the global directory. This results in 1 fewer call to `load_textdomain()` and 2 fewer if the old directory is not in place.
[6506] johnjamesjacoby Widgets: Audit all widget classes: * Use escaping GetText functions * Fix typos * Use more efficient queries for forum/topic/reply meta-boxes Needs testing. See #3070.
[6505] johnjamesjacoby Users: Bail if editing a user in wp-admin. This is a theme-side only handler.
[6504] johnjamesjacoby Topics: Redirect to forum when trashing a topic and the user cannot view trash. Fixes #3111. Props mattrabe.
1 2 3 4 5 6 7 8 9 10 11 12 13 14
Note: See TracReports for help on using and creating reports.