Skip to:
Content

bbPress.org

{33} Commit Messages, Current Release (4500 matches)

Report designed to help manage the list of contributors.

Note: If you'd like a RSS feed of the changesets a they happen, Please use the timeline rss feed instead.

Results (1 - 100 of 4500)

1 2 3 4 5 6 7 8 9 10 11
Changeset Author Message
[6963] netweb Theme Compat: Remove duplicate `border-radius` added in [6952] See #3281. For 2.7, trunk.
[6962] netweb Build Tools: Cache `node_modules` folder in Travis CI Fixes #2885.
[6961] johnjamesjacoby Reduce number of tags in readme.txt.
[6960] johnjamesjacoby Reduce number of tags in readme.txt.
[6959] johnjamesjacoby Replace extensive changelog with a single link to the Codex. Props casiepa (for trunk)
[6958] johnjamesjacoby Replace extensive changelog with a single link to the Codex. Props casiepa.
[6957] johnjamesjacoby Tag 2.6.1.
[6956] johnjamesjacoby Theme Compat: Fix CSS overlapping border-radius from r6951. Also bump package-lock.json.
[6955] johnjamesjacoby Settings: revert accidental string change from r6485. Fixes #3279. Props SergeyBiryukov. For 2.6.1, branches/2.6.
[6954] johnjamesjacoby Settings: revert accidental string change from r6485. Fixes #3279. Props SergeyBiryukov. For 2.7, trunk.
[6953] johnjamesjacoby Author Links: remove default non-breaking space. This commit fixes an inconsistency with author links, causing whitespace in some places but not others. See #3281. For 2.7, trunk.
[6952] johnjamesjacoby Theme Compat: resolve a number of issues brought up after 2.6 was released. This commit does the following: * Sets min and max heights on img.avatar elements to avoid them being super huge in Twenty Twenty * Restores text-underline styling for topic & reply content for Twenty Seventeen * Removes text-underline for revisions * Fixes padding & margins on small screens across all themes See #3281. For 2.7, trunk.
[6951] johnjamesjacoby Theme Compat: resolve a number of issues brought up after 2.6 was released. This commit does the following: * Sets min and max heights on img.avatar elements to avoid them being super huge in Twenty Twenty * Restores text-underline styling for topic & reply content for Twenty Seventeen * Removes text-underline for revisions * Fixes padding & margins on small screens across all themes See #3281. For 2.6.1, branches/2.6.
[6950] johnjamesjacoby Author Links: remove default non-breaking space. This commit fixes an inconsistency with author links, causing whitespace in some places but not others. See #3281. For 2.6.1, branches/2.6
[6949] johnjamesjacoby Meta Registration: add `auth_callback` to count meta arguments. This commit fixes a conflict with plugins that use the WordPress REST API in add/edit page/post screens. Item count meta keys start with underscores so they would be hidden from view in the Custom Fields meta-box, but that also means they are flagged as protected in the REST API, and without an explicit `auth_callback` argument `__return_false` is assumed to be on the safe side. This change explicitly allows all item count meta keys to be updated or deleted by all users, while still retaining their invisibility as protected meta data. It also adds more verbose inline documentation to each argument, for improved clarity and future reference. Fixes #3280. Props pdvwp, rtsbeacon, jufdaniellevideos for their helpful feedback in the forums. For 2.6.1, branches/2.6.
[6948] johnjamesjacoby Meta Registration: add `auth_callback` to count meta arguments. This commit fixes a conflict with plugins that use the WordPress REST API in add/edit page/post screens. Item count meta keys start with underscores so they would be hidden from view in the Custom Fields meta-box, but that also means they are flagged as protected in the REST API, and without an explicit `auth_callback` argument `__return_false` is assumed to be on the safe side. This change explicitly allows all item count meta keys to be updated or deleted by all users, while still retaining their invisibility as protected meta data. It also adds more verbose inline documentation to each argument, for improved clarity and future reference. Fixes #3280. Props pdvwp, rtsbeacon, jufdaniellevideos for their helpful feedback in the forums. For 2.7, trunk.
[6947] netweb Build Tools: Use Node.js 8.x
[6946] netweb Build Tools: Disable PHPUnit Speed Tester
[6945] netweb Build Tools: Update SASS Node.js modules
[6944] johnjamesjacoby Bump trunk to 2.7.0-alpha-1.
[6943] johnjamesjacoby Bump 2.6 branch to 2.6.1.
[6942] johnjamesjacoby Subforums: use the default forum ID when listing subforums. This commit fixes a regression causing subforums not be listed in forum indexes. Fixes #3232. Props scmsteve. For 2.6.1, branches/2.6.
[6941] johnjamesjacoby Subforums: use the default forum ID when listing subforums. This commit fixes a regression causing subforums not be listed in forum indexes. Fixes #3232. Props scmsteve. For 2.7, trunk.
[6940] johnjamesjacoby Tag 2.6.0.
[6939] johnjamesjacoby Create 2.6 branch (from trunk)
[6938] johnjamesjacoby Bump everything, including the version (to 2.6.0!)
[6937] johnjamesjacoby Fix Sergey's avatar. <3
[6936] johnjamesjacoby Retro TV styling for contributor avatars. 📺
[6935] johnjamesjacoby Tools: reduce the number of calls to `bbp_is_large_install()`. This commit refactors the update code to only call `bbp_is_large_install()` once, a function which ironically enough is costly to call on very large installations, so calling it 3 times defeats the purpose, but calling it one time is the minimum requirement to defer upgrades & repairs for keymaster interaction. See #3052.
[6934] johnjamesjacoby Tools: allow repairs to also be pending. This commit makes Repairs work like Upgrades, allowing for repair tools to also be pending. It adds a $type parameter to a few functions to allow grouping or separating, depending on the count context. See #3052.
[6933] johnjamesjacoby Repair Tools: rename forum reply hidden count function, and fix default sort order. This commit makes sure that the priority is respected with repair tools, and renames a newly introduced function to match it's existing cohort.
[6932] johnjamesjacoby Accessibility: improve contrast of admin/moderation links. This commit darkens the text used by the links in topics & replies, making them easier to see. Fixes #3003. Props mercime, thebrandonallen.
[6931] johnjamesjacoby Topics/Replies: improved support for replies without topics. This commit removes an assumptive call to `bbp_get_topic()` and avoids a debug notice when a reply is orphaned. See #3226.
[6930] johnjamesjacoby Topic Views: pass view ID into body class. This commit does a quick audit of Topic View API functions, and ensures their return values are as documented. This allows for safely adding the Topic View ID as a class to the body element of the page when viewing a single Topic View. Fixes #3278. Props Clorith.
[6929] johnjamesjacoby Importer: remove byref usade in parser.php. This commit removes an old byref in the bbCode parser. It wasn't really necessary, and was causing problems with certain PHP versions. Fixes #3257. Props webmaigcz.
[6928] johnjamesjacoby Importer: make inside meta-box contents a bit more squared. This change fixes a padding issue with the inner meta-box content, causing there to be more space on the bottom than on the top.
[6927] johnjamesjacoby Tools: wrap routine descriptions in a description paragraph tag. This commit ensures that the descriptive text used to highlight what a specific tool does does not blend in with the title above it. Fixes #3277. Props JarretC.
[6926] johnjamesjacoby Upgrades: Link to pending upgrades, if there are any. This commit modifies the "Upgrade Forums" page by adding Statuses to filter by, specifically for pending upgrades. This allows bbPress to link directly to the upgrades that need doing, rather than the generic page itself. Along with this commit are accompanying styling tweaks and helper functions to make this functionality possible. Fixes #3244.
[6925] johnjamesjacoby Tools: Make a few columns sortable. This commit adds a small UX improvement to the Repair and Upgrade tools pages, allowing for these lengthy lists to be sorted. See #3244.
[6924] johnjamesjacoby Docs: add missing project names after recently added @since's.
[6923] johnjamesjacoby Counts (meta-data): full audit of forum/topic/reply, public/non-public counts. This commit is the result of a full count audit, exposing multiple inconsistencies and voids in relation to how public and non-public counts are (re)calculated. For instance, hidden forum replies are not counted at all, until now. By introducing a new Repair tool, hidden forum reply counts are now counted. In addition, there were multiple bugs with topic & reply moderation, where the act of approving or unapproving topics or replies would cause the numbers to be inaccurate, or where topics & replies being caught in moderation were still increasing public counts. It was also possible to, as a Key Master, publicly reply to unapproved topics, which was a completely unanticipated side-effect of allowing Key Masters to do pretty much anything. Going forward, the default reply status is the topic status, but is still beholden to all existing moderation settings and user role capabilities. This results in a more sane user experience, and prevents the unusual circumstance of there being "0 topics and 30 replies" in public-facing forums. Certain count increase/decrease actions have been reprioritized to avoid collisions and race conditions, proving once again that ya gotta get up to get down. See #2838. Fixes #1799.
[6922] johnjamesjacoby Statuses: normalize status related functions across post types. This commit adds 2 missing functions for forum statuses, and relocates all of them to the correct functions.php files for their post types.
[6921] johnjamesjacoby Moderation: make sure pending topics (for moderation reasons) are accessible to authors. This commit updates the logic inside of the topic & reply map-meta-cap implementations, restricting edit-lock checks to actual "Edit" screens, and using the "edit_others_posts" capability in non-"Edit" screens, ensuring that both scenarios are covered. It also adds an explicit condition for Pending Topics to both the Topic Description and Topic Notices, alerting users as to why they are seeing what they are seeing. Fixes #3253 (again!) See also #3164 for other related discussion & details.
[6920] johnjamesjacoby Edit Locking: Remove redundant $minutes check in `bbp_past_edit_lock()`. This commit is just a small bit of cleanup from researching #3164. See #3222.
[6919] johnjamesjacoby Emails: chunk notification emails into 40 Bcc'd recipients. This commit introduces the `bbp_mail` subfilter, used to target bbPress specific emails in conjunction with `bbp_get_email_header()` to help identify emails that came specifically from bbPress actions. The purpose of this change is to help forum owners avoid their outbound emails being marked as spam, due to the high number of users that can be subscribed to any given forum or topic. This change (combined with r6725) goes a long way towards improving the success of subscription emails reaching their intended recipients. Fixes #3260. Props danielbachhuber.
[6918] johnjamesjacoby Subscriptions: clean up code comparisons and documentation. This commit adds some inline documentation to provide a bit more clarity around what subnscriptions checks and actions are being taken, and adds parenthesis to nested comparisons to improve code readability. See #3235.
[6917] johnjamesjacoby Anonymous: delete meta key if value is empty. This commit ensures that editing a non-anonymous topic via WordPress Admin does not erroneously add empty anonymous author keys to post meta.
[6916] johnjamesjacoby Subscriptions: pass additional IDs into user ID filters. This commit adds forum, topic, and reply IDs to the filters commonly used to filter the user IDs that emails are being sent to, providing a quick opportunity to peek at them easily and make decisions based on what they are at the time. Fixes #3249. Props satollo.
[6915] johnjamesjacoby Stickies: make sure unapproved topics are unstuck also. This commit removes a hard coded call to `bbp_unstick_topic()` and hooks into the neighboring `bbp_stick_topic` action, while also hooking into the `bbp_unapprove_topic` action. A small bit of code clean-up and inline documentation additions accompany this commit, to improve a bit of the surrounding relevant code. Fixes #3246.
[6914] johnjamesjacoby Engagements: always show user avatars in subscription/favorite metaboxes. This commit introduces a helper function (to reduce code duplication) responsible for looping through queried users and outputting avatars and profile links. A developers note is included in the function docs discouraging third-party plugin developers from using it, as future iterations of bbPress may modify its output without notice. Fixes #3272.
[6913] johnjamesjacoby Admin: Correctly register scripts & styles before enqueing them. This commit moves style/script registration to dedicated admin-area actions, separating them from their relative enqueing actions. It also deprecates the singular (incorrectly named) "bbp_register_admin_style" action and replaces it with the correctly named plural "bbp_register_admin_styles".
[6912] netweb Styling: Updade styles and stylelint config per latest coding standards
[6911] johnjamesjacoby Bump dev dependencies.
[6910] johnjamesjacoby Appearance: Use right-to-left suffix in default template pack. Fixes #3263. Props GDragoN.
[6909] johnjamesjacoby Tools/Repair: add missing `MAX()` in `bbp_admin_repair_freshness()`. This commit allows the freshness repair tool to correctly query for the maximum topic ID. Fixes #3261. Props GDragoN. For 2.5.x.
[6908] johnjamesjacoby Tools/Repair: add missing `MAX()` in `bbp_admin_repair_freshness()`. This commit allows the freshness repair tool to correctly query for the maximum topic ID. Fixes #3261. Props GDragoN. For 2.6 (trunk.)
[6907] netweb Coding Standards: Add missing trailing semi-colon from [6893]
[6906] johnjamesjacoby Tools/Repair: add missing apostrophe in `bbp_admin_repair_user_favorites()`. This commit allows the favorites repair tool to correctly query for chunked results. Fixes #3259. Props GDragoN. For 2.5.x.
[6905] johnjamesjacoby Tools/Repair: add missing apostrophe in `bbp_admin_repair_user_favorites()`. This commit allows the favorites repair tool to correctly query for chunked results. See #3259. Props GDragoN. For 2.6/trunk.
[6904] johnjamesjacoby Subscriptions: ensure special characters in author names are encoded properly. This commit copies the approach used on the content, and applies `wp_specialchars_decode()` and `strip_tags()` to author names in subscription emails. (HTML tags are not usually allowed in usernames, but we strip them anyways in the event a filter allowed them. Better to keep emails legible than include unintended tags?) Fixes #3256.
[6903] johnjamesjacoby Search: add support for `fs` query-arg to search forums list: * Introduces `bbp_sanitize_search_request()` to encapsulate duplicate code across forums/topics/replies * Introduces `bbp_get_search_type_ids()` to stub out future enhancements (tags, users, etc...) * Use these new functions where intended * Update `bbp_get_search_terms()` to loop through known search-type IDs This commit also fixes debug notices that would happen when these query arguments were not explicitly strings. Fixes #3245.
[6902] johnjamesjacoby Locale: update post type labels to include recent additions to WordPress. This commit adds several new label keys to the arrays for the Forum/Topic/Reply post types. It also removes some duplicated keys that have slipped in over time. Props GDragoN. Fixes #3250.
[6901] johnjamesjacoby Upgrades: add `empty()` checks to untrusted variable values to avoid debug notices. This change ensures that menu manipulations are not attempted via admin-area requests where they are not necessary (AJAX, shortinit, etc...) and fixes debug notices under those circumstances.
[6900] netweb Docs: Correct descriptions for various admin settings.
[6899] SergeyBiryukov Docs: Correct description for `_bbp_topics_per_page` setting.
[6898] johnjamesjacoby Subscriptions: do not send subscription emails during WordPress imports. This change adds checks to the `WP_IMPORTING` global constant inside of forum & topic subscription notification functions, to prevent sending emails during the import process. Because hooks still fire during imports, this sanity check avoids a potentially hugely annoying situation for users during forum migrations by any import tool that obeys the use of this core constant. Fixes #3248. Props danielbachhuber.
[6897] johnjamesjacoby Upgrades: append upgrade count to "Tools" if there are pending upgrades * Add function and method to tweak the `$menu` global * Add styling for count in `nav-tab-wrapper` UI This change adds a `span.awaiting-mod` wrapper around the pending upgrade count in a few strategic locations around the WordPress Admin UI. See #3244.
[6896] johnjamesjacoby Upgrades: change skipped upgrades to pending upgrade * Add functions for managing pending upgrades * Use IDs instead of strings for active tools tab * Add classes and `hr` for related H1's * Update registered option key name * Add skipped upgrades to pending upgrades array * Add `span` to allowed tags in notices These changes are necessary to bring adimn pages up to speed with WordPress Admin UI mark-up, in relation to the database upgrade notice. See #3244.
[6895] johnjamesjacoby Upgrades: add "Version" column to upgrades list table. See #3244.
[6894] johnjamesjacoby Upgrades: add support for "Version" filter & links in list table. * Adds functions for outputting in a table row and select dropdown * Adds a function to allow special translating of version numbers * Adds numerous improvements for PHP 7.3 compat * Adds escaping and formatting in several places where it was previously omitted * Adds `&mdash;` to empty columns * Adds functions for getting the current page ID See #3244.
[6893] johnjamesjacoby Upgrades: add column width styling to tools list tables. This ensures that columns are usually wide enough to fit their anticipated contents. See #3244.
[6892] johnjamesjacoby Upgrades: add `version` and update strings to repair tools. This change adds a version property to the relevant upgrades, and removes some redundant information from each description. See #3244.
[6891] johnjamesjacoby Upgrades: remove duplicate `wp_cache_flush()` call. From `bbp_admin_repair_reply_menu_order()`, since repair tools flush the caches anyways, this is not necessary here. Found during work on #3244.
[6890] johnjamesjacoby Upgrades: add support for `version` key in repair tool registration. This will get used by individual tools, to provide a UI for routines that need to be run between version upgrades. See #3244.
[6889] johnjamesjacoby Rewrites: use `property_exists()` on `$wp_rewrite` global touches. This makes sure that bbPress defaults are preferred, and avoids fatal errors if class properties are unset. Also relocate `bbp_use_pretty_urls()` to better group it together with other `bbp_rewrite()` wrappers.
[6888] johnjamesjacoby Parser: revert error control operator change from r6887. See also r6633 for original change.
[6887] johnjamesjacoby Parser: Fix PHP 7.3 warning ("continue" in "switch" is equal to "break") Fixes #3242.
[6886] johnjamesjacoby Subscriptions: Do not add or remove subscriptions when editing via WordPress admin. This change passes the current post ID through to `bbp_is_user_subscribed()`, ensuring that admin area subscriptions are saved to the correct topic ID (not revisions, etc...) while also not changing the subscriptions status. Fixes #3235.
[6885] johnjamesjacoby Formatting: update `bbp_make_clickable()` to better handle spaces in `href` attributes. This change updates the included regular expression to avoid returning broken (or at least unexpected) HTML and allows spaces in `href` attributes to be encoded as expected. Props dd32. Fixes #3237.
[6884] johnjamesjacoby Topic Tags: remove extraneous `span` tag from topic-tag titles when theme-compat is employed. This change removes a `span` tag that was originally required before support for topic-tag-edit templates was added. Props mechter. Fixes #3236.
[6883] johnjamesjacoby Styling: Remove unused `row-actions` CSS. This used to be necessary for BuddyPress theme compatibility, but is no longer. See #3238, for trunk (2.6)
[6882] johnjamesjacoby Tools: update npm package dependencies.
[6881] johnjamesjacoby Titles: add comment about `8bit` mode usage of `mb_strlen()` to provide extra context. (After looking at this again, I wasn't confident it was correct. It seems to be, given how it's being used.) See #3189.
[6880] johnjamesjacoby Subscriptions: replace hard-coded, single-use strings with `no-forums` template part.
[6879] johnjamesjacoby Tag 2.6 RC 7.
[6878] johnjamesjacoby Bump trunk to 2.6-rc7.
[6877] johnjamesjacoby Engagements: demystify strategy sanitization. This change ensures that invalid/unavailable strategies are never used, and also allows for custom strategies to exist (custom table, etc...) without requiring strategy registration. See #3211.
[6876] johnjamesjacoby Engagements: next pass at back-compat for pre-2.6 `user` strategy. * Renames `BBP_User_Engagements_Back_Compat` to `BBP_User_Engagements_User` so the approach is more clear. * Fill in `get_query()` method, left todo from r6844. * Move active strategy into a preloaded option, default to `meta` * Set active strategy to `user` on failed auto-upgrade to 2.6 to maintain backwards compatibility * Introduces sub-actions to assist with abstracting the engagement strategy setup Fixes #3211.
[6875] johnjamesjacoby Forums: protect against a missing/malformed `forum_id` value when listing subforums. Fixes #3232.
[6874] johnjamesjacoby Akismet: allow "trusted" users to bypass spam `post_status` enforcement. * Adds `bbp_bypass_check_for_spam` filter ahead of the HTTP request * Adds `bbp_bypass_spam_enforcement` filter ahead of `post_status` switch * Adds `current_user_can( 'moderate' )` check to bypass spam enforcement * Adds `parse_response()` method to `BBP_Akismet` class for future abstraction This allows for 2 different ways to short-circuit Akismet: * Before the HTTP request happens * After the HTTP request, but before the status change bbPress will now trust users that pass the `moderator` capability check (including per-forum moderators) even if Akismet thinks the content is spammy. The Akismet history will still reflect the catch; the status will just not be enforced. This addresses issues we've seen on WordPress.org, BuddyPress.org, and bbPress.org, where trusted moderator posts would be caught in the spam queue, even when they have privileges to enter the queue and unspam their own posts. Fixes #2917. Props tharsheblows for the original patch!
[6873] netweb Styling: Use double quotes Fixes #3228. Props jrf.
[6872] johnjamesjacoby Forums: revert part of r6860. Go back to `ul` and `li` to avoid breaking CSS for existing installs, and use a CSS separator instead to address the original invalid markup issues. This might show an extra separator in circumstances where filters or template-overrides are targeting very specific things, but that's better than breaking mark-up changes. See #3217.
[6871] johnjamesjacoby AJAX: always use `defined()` before setting an environmental constant. This avoids a notice/warning if something has already set the the `DOING_AJAX` constant.
[6870] johnjamesjacoby Update function docs for functions introduced in r6869.
[6869] johnjamesjacoby Edit Locking Improvements: * Refactor to avoid doing unnecessary computations * Invert default return value from false to true, requiring time to pass validation as opposed to assuming * Improve obviousness of math computations for easier debuggability * Update variables passed into the end return filter * Add 6 unit tests for before/on/after, plus support for "0" as infinite * Fix bug causing "0" values to return the opposite value * Ensure only gmt/utc values are compared * Add optional flag to use WordPress time instead * Improve inline and function documentation Fixes #3222. Props wpdennis.
[6868] johnjamesjacoby Accessibility: Avoid back-to-back author links. This change ensures that avatar and display-name links are wrapped in a shared anchor, instead of each with their own. Includes a few test changes to better suit our intentions of verifying valid & accessible HTML output. Fixes #3220. Props dcavins.
[6867] johnjamesjacoby Akismet: send sanitized string values for referer and user-agent. Avoids issues with huge/invalid strings. and ensures that `_wp_http_referer` is used.
[6866] johnjamesjacoby General: unslash IP and user agent strings. These are only used in ways where slashed values are undesirable.
[6865] johnjamesjacoby Templates: call `bbp_get_post_types()` when parsing query args and setting template args. Fixes #3221. Props scmsteve.
[6864] johnjamesjacoby General: update `bbp_get_post_types()` to accept arguments to parse before calling `get_post_types()`. This avoids other manual calls to `get_post_types()` in other places. See #3221.
1 2 3 4 5 6 7 8 9 10 11
Note: See TracReports for help on using and creating reports.