Changeset 7379 for trunk/src/includes/replies/functions.php

Timestamp:

11/24/2025 07:23:06 PM (6 months ago)

Author:

johnjamesjacoby

Message:

Tools - Code Improvement: stop ignoring these PHPCS sniffs:

• PEAR.Files.IncludingFile.UseRequire
• PSR2.ControlStructures.SwitchDeclaration.BodyOnNextLineDEFAULT
• PSR2.Methods.FunctionClosingBrace.SpacingBeforeClose
• Squiz.ControlStructures.ControlSignature.NewlineAfterOpenBrace
• Squiz.PHP.DisallowMultipleAssignments.FoundInControlStructure
• Squiz.PHP.EmbeddedPhp.MultipleStatements
• Squiz.PHP.NonExecutableCode.Unreachable
• Universal.Arrays.DuplicateArrayKey.Found
• Universal.ControlStructures.DisallowLonelyIf.Found
• WordPress.PHP.NoSilencedErrors.Discouraged

This commit includes code formatting changes for the above sniffs.

See #3658.

File:

• trunk/src/includes/replies/functions.php (modified) (3 diffs)

trunk/src/includes/replies/functions.php

@@ -571 +571 @@
         return;
 
-    // Reply exists
+    // Check users ability to create new reply
+    } elseif ( ! bbp_is_reply_anonymous( $reply_id ) ) {
+
+        // User cannot edit this reply
+        if ( ! current_user_can( 'edit_reply', $reply_id ) ) {
+            bbp_add_error( 'bbp_edit_reply_permission', __( '<strong>Error</strong>: You do not have permission to edit that reply.', 'bbpress' ) );
+            return;
+        }
+
+        // Set reply author
+        $reply_author = bbp_get_reply_author_id( $reply_id );
+
+    // It is an anonymous post
     } else {
 
-        // Check users ability to create new reply
-        if ( ! bbp_is_reply_anonymous( $reply_id ) ) {
-
-            // User cannot edit this reply
-            if ( ! current_user_can( 'edit_reply', $reply_id ) ) {
-                bbp_add_error( 'bbp_edit_reply_permission', __( '<strong>Error</strong>: You do not have permission to edit that reply.', 'bbpress' ) );
-                return;
-            }
-
-            // Set reply author
-            $reply_author = bbp_get_reply_author_id( $reply_id );
-
-        // It is an anonymous post
-        } else {
-
-            // Filter anonymous data
-            $anonymous_data = bbp_filter_anonymous_post_data();
-        }
+        // Filter anonymous data
+        $anonymous_data = bbp_filter_anonymous_post_data();
     }
 
@@ -1400 +1396 @@
             case 'topic' :
             default :
-
                 // User needs to be able to publish topics
                 if ( current_user_can( 'publish_topics' ) ) {
@@ -2320 +2315 @@
 
         <?php if ( bbp_has_replies( $replies_query ) ) : ?>
-            <?php while ( bbp_replies() ) : bbp_the_reply(); ?>
+            <?php while ( bbp_replies() ) :
+
+                bbp_the_reply(); ?>
 
                 <item>