Changeset 7379 for trunk/src/includes/common/locks.php

Timestamp:

11/24/2025 07:23:06 PM (6 months ago)

Author:

johnjamesjacoby

Message:

Tools - Code Improvement: stop ignoring these PHPCS sniffs:

• PEAR.Files.IncludingFile.UseRequire
• PSR2.ControlStructures.SwitchDeclaration.BodyOnNextLineDEFAULT
• PSR2.Methods.FunctionClosingBrace.SpacingBeforeClose
• Squiz.ControlStructures.ControlSignature.NewlineAfterOpenBrace
• Squiz.PHP.DisallowMultipleAssignments.FoundInControlStructure
• Squiz.PHP.EmbeddedPhp.MultipleStatements
• Squiz.PHP.NonExecutableCode.Unreachable
• Universal.Arrays.DuplicateArrayKey.Found
• Universal.ControlStructures.DisallowLonelyIf.Found
• WordPress.PHP.NoSilencedErrors.Discouraged

This commit includes code formatting changes for the above sniffs.

See #3658.

File:

• trunk/src/includes/common/locks.php (modified) (2 diffs)

trunk/src/includes/common/locks.php

@@ -24 +24 @@
 
     // Bail if no post
-    if ( ! $post = get_post( $post_id ) ) {
+    $post = get_post( $post_id );
+    if ( empty( $post ) ) {
         return false;
     }
 
     // Bail if no lock
-    if ( ! $lock = get_post_meta( $post->ID, '_edit_lock', true ) ) {
+    $lock = get_post_meta( $post->ID, '_edit_lock', true );
+    if ( empty( $lock ) ) {
         return false;
     }
@@ -63 +65 @@
 
     // Bail if no post
-    if ( ! $post = get_post( $post_id ) ) {
+    $post = get_post( $post_id );
+    if ( empty( $post ) ) {
         return false;
     }
 
     // Bail if no user
-    if ( 0 === ( $user_id = get_current_user_id() ) ) {
+    $user_id = get_current_user_id();
+    if ( empty( $user_id ) ) {
         return false;
     }