Changeset 7379 for trunk/src/includes/common/functions.php

Timestamp:

11/24/2025 07:23:06 PM (6 months ago)

Author:

johnjamesjacoby

Message:

Tools - Code Improvement: stop ignoring these PHPCS sniffs:

• PEAR.Files.IncludingFile.UseRequire
• PSR2.ControlStructures.SwitchDeclaration.BodyOnNextLineDEFAULT
• PSR2.Methods.FunctionClosingBrace.SpacingBeforeClose
• Squiz.ControlStructures.ControlSignature.NewlineAfterOpenBrace
• Squiz.PHP.DisallowMultipleAssignments.FoundInControlStructure
• Squiz.PHP.EmbeddedPhp.MultipleStatements
• Squiz.PHP.NonExecutableCode.Unreachable
• Universal.Arrays.DuplicateArrayKey.Found
• Universal.ControlStructures.DisallowLonelyIf.Found
• WordPress.PHP.NoSilencedErrors.Discouraged

This commit includes code formatting changes for the above sniffs.

See #3658.

File:

• trunk/src/includes/common/functions.php (modified) (3 diffs)

trunk/src/includes/common/functions.php

@@ -1717 +1717 @@
  * @global WP $wp
  * @param string $where
- * @param WP_Query $object
+ * @param WP_Query $query
  * @return string
  */
-function bbp_query_post_parent__in( $where, $object = '' ) {
+function bbp_query_post_parent__in( $where, $query = '' ) {
     global $wp;
 
@@ -1729 +1729 @@
 
     // Bail if no object passed
-    if ( empty( $object ) ) {
+    if ( empty( $query ) ) {
         return $where;
     }
 
     // Only 1 post_parent so return $where
-    if ( is_numeric( $object->query_vars['post_parent'] ) ) {
+    if ( is_numeric( $query->query_vars['post_parent'] ) ) {
         return $where;
     }
@@ -1742 +1742 @@
 
     // Including specific post_parent's
-    if ( ! empty( $object->query_vars['post_parent__in'] ) ) {
-        $ids    = implode( ',', wp_parse_id_list( $object->query_vars['post_parent__in'] ) );
+    if ( ! empty( $query->query_vars['post_parent__in'] ) ) {
+        $ids    = implode( ',', wp_parse_id_list( $query->query_vars['post_parent__in'] ) );
         $where .= " AND {$bbp_db->posts}.post_parent IN ($ids)";
 
     // Excluding specific post_parent's
-    } elseif ( ! empty( $object->query_vars['post_parent__not_in'] ) ) {
-        $ids    = implode( ',', wp_parse_id_list( $object->query_vars['post_parent__not_in'] ) );
+    } elseif ( ! empty( $query->query_vars['post_parent__not_in'] ) ) {
+        $ids    = implode( ',', wp_parse_id_list( $query->query_vars['post_parent__not_in'] ) );
         $where .= " AND {$bbp_db->posts}.post_parent NOT IN ($ids)";
     }