Skip to:
Content

bbPress.org


Ignore:
Timestamp:
11/22/2025 06:05:25 AM (6 months ago)
Author:
johnjamesjacoby
Message:

Tools - Code Improvement: stop ignoring these PHPCS sniffs:

  • Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition
  • Generic.CodeAnalysis.EmptyStatement.DetectedElseif
  • Generic.CodeAnalysis.EmptyStatement.DetectedIf
  • Generic.CodeAnalysis.UselessOverridingMethod.Found
  • Generic.ControlStructures.InlineControlStructure.NotAllowed
  • Generic.Files.LineEndings.InvalidEOLChar
  • Generic.Formatting.DisallowMultipleStatements.SameLine
  • Generic.Formatting.SpaceAfterCast.TooMuchSpace
  • Generic.Functions.OpeningFunctionBraceKernighanRitchie.ContentAfterBrace
  • Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
  • NormalizedArrays.Arrays.ArrayBraceSpacing.SpaceAfterArrayOpenerMultiLine
  • NormalizedArrays.Arrays.ArrayBraceSpacing.SpaceAfterArrayOpenerSingleLine
  • NormalizedArrays.Arrays.ArrayBraceSpacing.SpaceBeforeArrayCloserMultiLine
  • NormalizedArrays.Arrays.CommaAfterLast.MissingMultiLineCloserSameLine
  • PEAR.Functions.FunctionCallSignature.CloseBracketLine
  • PEAR.Functions.FunctionCallSignature.EmptyLine
  • PEAR.Functions.FunctionCallSignature.Indent
  • PEAR.Functions.FunctionCallSignature.MultipleArguments
  • PHPCompatibility.FunctionUse.ArgumentFunctionsReportCurrentValue.NeedsInspection
  • PHPCompatibility.Syntax.RemovedCurlyBraceArrayAccess.Found
  • PSR2.Classes.ClassDeclaration.CloseBraceAfterBody
  • PSR2.Classes.PropertyDeclaration.ScopeMissing
  • PSR2.Classes.PropertyDeclaration.Underscore
  • PSR2.Classes.PropertyDeclaration.VarUsed
  • PSR2.ControlStructures.ElseIfDeclaration.NotAllowed
  • PSR2.ControlStructures.SwitchDeclaration.BreakIndent
  • PSR2.Methods.MethodDeclaration.Underscore
  • Squiz.ControlStructures.ControlSignature.SpaceAfterCloseBrace
  • Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterOpen
  • Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBeforeClose
  • Squiz.Functions.MultiLineFunctionDeclaration.ContentAfterBrace
  • Squiz.PHP.DisallowSizeFunctionsInLoops.Found
  • Squiz.Scope.MethodScope.Missing
  • Squiz.WhiteSpace.SuperfluousWhitespace.EndLine
  • Universal.NamingConventions.NoReservedKeywordParameterNames.arrayFound
  • Universal.NamingConventions.NoReservedKeywordParameterNames.echoFound
  • Universal.NamingConventions.NoReservedKeywordParameterNames.parentFound
  • Universal.Operators.DisallowStandalonePostIncrementDecrement.PostDecrementFound
  • Universal.Operators.DisallowStandalonePostIncrementDecrement.PostIncrementFound
  • Universal.Operators.StrictComparisons.LooseEqual
  • Universal.Operators.StrictComparisons.LooseNotEqual
  • WordPress.Arrays.ArrayKeySpacingRestrictions.TooMuchSpaceAfterKey
  • WordPress.DateTime.CurrentTimeTimestamp.Requested
  • WordPress.DateTime.RestrictedFunctions.date_date
  • WordPress.Files.FileName.NotHyphenatedLowercase
  • WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedClassFound
  • WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedConstantFound
  • WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedFunctionFound
  • WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound
  • WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
  • WordPress.NamingConventions.ValidVariableName.VariableNotSnakeCase
  • WordPress.PHP.IniSet.Risky
  • WordPress.PHP.PregQuoteDelimiter.Missing
  • WordPress.PHP.StrictInArray.MissingTrueStrict
  • WordPress.WP.AlternativeFunctions.parse_url_parse_url
  • WordPress.WP.AlternativeFunctions.rand_mt_rand
  • WordPress.WP.AlternativeFunctions.strip_tags_strip_tag
  • WordPress.WP.AlternativeFunctions.strip_tags_strip_tags
  • WordPress.WP.Capabilities.Unknown
  • WordPress.WP.DeprecatedParameters.Get_termsParam2Found
  • WordPress.WP.DeprecatedParameters.Wp_count_termsParam2Found
  • WordPress.WP.DiscouragedFunctions.query_posts_query_posts
  • WordPress.WP.DiscouragedFunctions.wp_reset_query_wp_reset_query
  • WordPress.WP.EnqueuedResourceParameters.NotInFooter
  • WordPress.WP.GlobalVariablesOverride.Prohibited
  • WordPress.WP.I18n.LowLevelTranslationFunction

This commit includes code formatting changes for the above sniffs.

See #3658.

File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/src/includes/extend/buddypress/activity.php

    r7360 r7378  
    213213
    214214        // Default activity args
    215         $activity = bbp_parse_args( $args, array(
    216             'id'                => null,
    217             'user_id'           => bbp_get_current_user_id(),
    218             'type'              => '',
    219             'action'            => '',
    220             'item_id'           => '',
    221             'secondary_item_id' => '',
    222             'content'           => '',
    223             'primary_link'      => '',
    224             'component'         => $this->component,
    225             'recorded_time'     => bp_core_current_time(),
    226             'hide_sitewide'     => false
    227         ), 'record_activity' );
     215        $activity = bbp_parse_args(
     216            $args,
     217            array(
     218                'id'                => null,
     219                'user_id'           => bbp_get_current_user_id(),
     220                'type'              => '',
     221                'action'            => '',
     222                'item_id'           => '',
     223                'secondary_item_id' => '',
     224                'content'           => '',
     225                'primary_link'      => '',
     226                'component'         => $this->component,
     227                'recorded_time'     => bp_core_current_time(),
     228                'hide_sitewide'     => false
     229            ),
     230            'record_activity'
     231        );
    228232
    229233        // Add the activity
    … …  
    243247
    244248        // Default activity args
    245         $activity = bbp_parse_args( $args, array(
    246             'item_id'           => false,
    247             'component'         => $this->component,
    248             'type'              => false,
    249             'user_id'           => false,
    250             'secondary_item_id' => false
    251         ), 'delete_activity' );
     249        $activity = bbp_parse_args(
     250            $args,
     251            array(
     252                'item_id'           => false,
     253                'component'         => $this->component,
     254                'type'              => false,
     255                'user_id'           => false,
     256                'secondary_item_id' => false
     257            ),
     258            'delete_activity'
     259        );
    252260
    253261        // Delete the activity
    … …  
    410418
    411419        // Compile and record the activity stream results
    412         $activity_id = $this->record_activity( array(
    413             'id'                => $this->get_activity_id( $topic_id ),
    414             'user_id'           => $user_id,
    415             'action'            => $activity_action,
    416             'content'           => $activity_content,
    417             'primary_link'      => $topic_permalink,
    418             'type'              => $this->topic_create,
    419             'item_id'           => $topic_id,
    420             'secondary_item_id' => $forum_id,
    421             'recorded_time'     => get_post_time( 'Y-m-d H:i:s', true, $topic_id ),
    422             'hide_sitewide'     => ! bbp_is_forum_public( $forum_id, false )
    423         ) );
     420        $activity_id = $this->record_activity(
     421            array(
     422                'id'                => $this->get_activity_id( $topic_id ),
     423                'user_id'           => $user_id,
     424                'action'            => $activity_action,
     425                'content'           => $activity_content,
     426                'primary_link'      => $topic_permalink,
     427                'type'              => $this->topic_create,
     428                'item_id'           => $topic_id,
     429                'secondary_item_id' => $forum_id,
     430                'recorded_time'     => get_post_time( 'Y-m-d H:i:s', true, $topic_id ),
     431                'hide_sitewide'     => ! bbp_is_forum_public( $forum_id, false )
     432            )
     433        );
    424434
    425435        // Add the activity entry ID as a meta value to the topic
    … …  
    554564
    555565        // Compile and record the activity stream results
    556         $activity_id = $this->record_activity( array(
    557             'id'                => $this->get_activity_id( $reply_id ),
    558             'user_id'           => $user_id,
    559             'action'            => $activity_action,
    560             'content'           => $activity_content,
    561             'primary_link'      => $reply_url,
    562             'type'              => $this->reply_create,
    563             'item_id'           => $reply_id,
    564             'secondary_item_id' => $topic_id,
    565             'recorded_time'     => get_post_time( 'Y-m-d H:i:s', true, $reply_id ),
    566             'hide_sitewide'     => ! bbp_is_forum_public( $forum_id, false )
    567         ) );
     566        $activity_id = $this->record_activity(
     567            array(
     568                'id'                => $this->get_activity_id( $reply_id ),
     569                'user_id'           => $user_id,
     570                'action'            => $activity_action,
     571                'content'           => $activity_content,
     572                'primary_link'      => $reply_url,
     573                'type'              => $this->reply_create,
     574                'item_id'           => $reply_id,
     575                'secondary_item_id' => $topic_id,
     576                'recorded_time'     => get_post_time( 'Y-m-d H:i:s', true, $reply_id ),
     577                'hide_sitewide'     => ! bbp_is_forum_public( $forum_id, false )
     578            )
     579        );
    568580
    569581        // Add the activity entry ID as a meta value to the reply
Note: See TracChangeset for help on using the changeset viewer.