Changeset 7368 for trunk/src/includes/common/formatting.php

Timestamp:

11/17/2025 06:31:41 PM (5 months ago)

Author:

johnjamesjacoby

Message:

Tools - Unit Tests: allow mentions after '[' and '(' chars.

This commit fixes the suite of user-mentions unit tests, so that they no longer require an empty "class" attribute, and also so that mentions inside of common wrappers ((), [] ) are allowed.

See #3657.

File:

• trunk/src/includes/common/formatting.php (modified) (3 diffs)

trunk/src/includes/common/formatting.php

@@ -455 +455 @@
  * Make mentions clickable in content areas
  *
+ * Allows ' ', '>', '[', and '(' before as '@' username mention
+ *
  * @since 2.6.0 bbPress (r6014)
  *
@@ -463 +465 @@
  */
 function bbp_make_mentions_clickable( $text = '' ) {
-    return preg_replace_callback( '#([\s>])@([0-9a-zA-Z-_]+)#i', 'bbp_make_mentions_clickable_callback', $text );
+    return preg_replace_callback(
+        '#([\s>\[\(])\@([0-9a-zA-Z\-_]+)#i',
+        'bbp_make_mentions_clickable_callback',
+        $text
+    );
 }
 
@@ -508 +514 @@
 
     // Create the link to the user's profile
-    $html   = '<a href="%1$s"' . $class . '>%2$s</a>';
-    $url    = bbp_get_user_profile_url( $user->ID );
-    $anchor = sprintf( $html, esc_url( $url ), esc_html( $matches[0] ) );
+    $html    = '<a href="%1$s"%2$s>%3$s</a>';
+    $url     = bbp_get_user_profile_url( $user->ID );
+    $mention = '@' . $matches[2];
+    $anchor  = sprintf( $html, esc_url( $url ), $class, esc_html( $mention ) );
 
     // Prevent this link from being followed by bots