Changeset 7352 for trunk/src/includes/admin/forums.php

Timestamp:

11/14/2025 04:17:43 PM (4 months ago)

Author:

johnjamesjacoby

Message:

Tools - Build: Clean-up PHPCS, and enforce Yoda conditionals.

This commit includes changes to various PHP files, Composer requirements, and PHPCS config, to confirm that the WordPress.PHP.YodaConditions code sniff passes.

Props sirlouen.

In trunk, for 2.7.

Fixes #3613.

File:

• trunk/src/includes/admin/forums.php (modified) (3 diffs)

trunk/src/includes/admin/forums.php

@@ -448 +448 @@
         switch ( $notice ) {
             case 'opened' :
-                $message = ( $is_failure === true )
+                $message = ( true === $is_failure )
                     ? sprintf( esc_html__( 'There was a problem opening the forum "%1$s".', 'bbpress' ), $forum_title )
                     : sprintf( esc_html__( 'Forum "%1$s" successfully opened.',             'bbpress' ), $forum_title );
@@ -454 +454 @@
 
             case 'closed' :
-                $message = ( $is_failure === true )
+                $message = ( true === $is_failure )
                     ? sprintf( esc_html__( 'There was a problem closing the forum "%1$s".', 'bbpress' ), $forum_title )
                     : sprintf( esc_html__( 'Forum "%1$s" successfully closed.',             'bbpress' ), $forum_title );
@@ -462 +462 @@
         // Do additional forum toggle notice filters (admin side)
         $message = apply_filters( 'bbp_toggle_forum_notice_admin', $message, $forum_id, $notice, $is_failure );
-        $class   = ( $is_failure === true )
+        $class   = ( true === $is_failure )
             ? 'error'
             : 'updated';