Changeset 7352 for trunk/src/includes/admin/converters/Kunena1.php

Timestamp:

11/14/2025 04:17:43 PM (6 months ago)

Author:

johnjamesjacoby

Message:

Tools - Build: Clean-up PHPCS, and enforce Yoda conditionals.

This commit includes changes to various PHP files, Composer requirements, and PHPCS config, to confirm that the WordPress.PHP.YodaConditions code sniff passes.

Props sirlouen.

In trunk, for 2.7.

Fixes #3613.

File:

• trunk/src/includes/admin/converters/Kunena1.php (modified) (2 diffs)

trunk/src/includes/admin/converters/Kunena1.php

@@ -464 +464 @@
     public function authenticate_pass($password, $serialized_pass) {
         $pass_array = unserialize($serialized_pass);
-        return ( $pass_array['hash'] == md5(md5($password) . $pass_array['salt']) );
+        return ( md5(md5($password) . $pass_array['salt']) == $pass_array['hash'] );
     }
 
@@ -474 +474 @@
      */
     public function callback_forum_type( $status = 0 ) {
-        if ( $status == 0 ) {
+        if ( 0 == $status ) {
             $status = 'category';
         } else {