Changeset 7341 for trunk/src/includes/forums/functions.php

Timestamp:

07/24/2025 12:27:11 AM (4 months ago)

Author:

johnjamesjacoby

Message:

Forums: prevent PHP warnings on singular bbPress pages when post ID's are not set.

This change adds checks for empty $wp_query->post->ID before using it inside of bbp_forum_enforce_private() and bbp_forum_enforce_hidden().

In trunk, for 2.7.

Fixes #3644.

File:

• trunk/src/includes/forums/functions.php (modified) (4 diffs)

trunk/src/includes/forums/functions.php

@@ -2463 +2463 @@
     $forum_id = 0;
     $wp_query = bbp_get_wp_query();
+    $post_id  = ! empty( $wp_query->post->ID )
+        ? $wp_query->post->ID
+        : 0;
 
     // Check post type
@@ -2469 +2472 @@
         // Forum
         case bbp_get_forum_post_type() :
-            $forum_id = bbp_get_forum_id( $wp_query->post->ID );
+            $forum_id = bbp_get_forum_id( $post_id );
             break;
 
         // Topic
         case bbp_get_topic_post_type() :
-            $forum_id = bbp_get_topic_forum_id( $wp_query->post->ID );
+            $forum_id = bbp_get_topic_forum_id( $post_id );
             break;
 
         // Reply
         case bbp_get_reply_post_type() :
-            $forum_id = bbp_get_reply_forum_id( $wp_query->post->ID );
+            $forum_id = bbp_get_reply_forum_id( $post_id );
             break;
     }
@@ -2505 +2508 @@
     $forum_id = 0;
     $wp_query = bbp_get_wp_query();
+    $post_id  = ! empty( $wp_query->post->ID )
+        ? $wp_query->post->ID
+        : 0;
 
     // Check post type
@@ -2511 +2517 @@
         // Forum
         case bbp_get_forum_post_type() :
-            $forum_id = bbp_get_forum_id( $wp_query->post->ID );
+            $forum_id = bbp_get_forum_id( $post_id );
             break;
 
         // Topic
         case bbp_get_topic_post_type() :
-            $forum_id = bbp_get_topic_forum_id( $wp_query->post->ID );
+            $forum_id = bbp_get_topic_forum_id( $post_id );
             break;
 
         // Reply
         case bbp_get_reply_post_type() :
-            $forum_id = bbp_get_reply_forum_id( $wp_query->post->ID );
+            $forum_id = bbp_get_reply_forum_id( $post_id );
             break;
-
     }