Changeset 7325

Timestamp:

06/30/2025 06:27:22 PM (7 months ago)

Author:

johnjamesjacoby

Message:

Extend - Akismet: avoid timeouts in the delete_orphaned_spam_meta() method.

This change modifies the SQL used to query for Akismet post-meta keys, such that it will only retrieve rows where meta_key is like akismet_.

This results in a less-optimized database query, but circumvents a bug where unnecessary rows were being looped through in a way that would never finish.

Props terresquall.

In trunk, for 2.7.

Fixes #3580.

File:

• trunk/src/includes/extend/akismet.php (modified) (1 diff)

trunk/src/includes/extend/akismet.php

@@ -1196 +1196 @@
 
         // Setup the query
-        $sql = "SELECT m.meta_id, m.post_id, m.meta_key FROM {$wpdb->postmeta} as m LEFT JOIN {$wpdb->posts} as p ON m.post_id = p.ID WHERE p.ID IS NULL AND m.meta_id > %d ORDER BY m.meta_id LIMIT %d";
+        $sql = "SELECT m.meta_id, m.post_id, m.meta_key"
+            . " FROM {$wpdb->postmeta} as m"
+            . " LEFT JOIN {$wpdb->posts} as p"
+            . " ON m.post_id = p.ID"
+            . " WHERE p.ID IS NULL"
+            . " AND m.meta_id > %d"
+            . " AND m.meta_key LIKE 'akismet\\_%'"
+            . " ORDER BY m.meta_id"
+            . " LIMIT %d";
 
         // Query loop of topic & reply IDs