Changeset 7315 for trunk/src/includes/common/functions.php

Timestamp:

06/26/2025 01:18:20 AM (5 months ago)

Author:

johnjamesjacoby

Message:

Common: fix incorrect return type of bbp_pre_handle_404().

This change ensures that true is always returned when overriding the 404 status.

Props ethitter.

In trunk, for 2.7.

Fixes #3626.

File:

• trunk/src/includes/common/functions.php (modified) (1 diff)

trunk/src/includes/common/functions.php

@@ -2617 +2617 @@
 
         // Either force a 404 when 200, or a 200 when 404
-        $override = ( true === $wp_query->bbp_is_404 )
-            ? bbp_set_404( $wp_query )
-            : bbp_set_200();
+        if ( true === $wp_query->bbp_is_404 ) {
+            bbp_set_404( $wp_query );
+        } else {
+            bbp_set_200();
+        }
+
+        // Overridden
+        $override = true;
     }