Changeset 7277

Timestamp:

07/02/2024 05:36:41 PM (9 months ago)

Author:

johnjamesjacoby

Message:

Breadcrumbs: prevent duplicate root crumb on Forum Archive subpages

This change prevents the Forum Archive page from appearing a second time in the breadcrumb trail when using pages, shortcodes, and/or subpages for forum setup.

It does this by keeping track of a previous match of a page by path to the Forum Archive, and skipping that page ID in the subsequent ancestors loop.

In trunk, for 2.7.

File:

• trunk/src/includes/common/template.php (modified) (3 diffs)

trunk/src/includes/common/template.php

@@ -2263 +2263 @@
 
         // Define variables
-        $front_id         = $root_id                                 = 0;
+        $front_id         = $root_id          = $remove_root_id      = 0;
         $ancestors        = $crumbs           = $tag_data            = array();
         $pre_root_text    = $pre_front_text   = $pre_current_text    = '';
@@ -2418 +2418 @@
             $page = bbp_get_page_by_path( bbp_get_root_slug() );
             if ( ! empty( $page ) ) {
-                $root_url = get_permalink( $page->ID );
+                $root_url       = get_permalink( $page->ID );
+                $remove_root_id = $page->ID;
 
             // Use the root slug
@@ -2440 +2441 @@
                 // Skip parent if empty or error
                 if ( empty( $parent ) || is_wp_error( $parent ) ) {
+                    continue;
+                }
+
+                // Skip to prevent duplicate root on subpages
+                if ( ! empty( $remove_root_id ) && ( $parent->ID === $remove_root_id ) ) {
                     continue;
                 }