Changeset 7276 for trunk/src/includes/topics/template.php

Timestamp:

07/02/2024 04:11:29 PM (20 months ago)

Author:

johnjamesjacoby

Message:

Posts: strip "Protected/Private" for bbPress post types

This change prevents post title hints from being prepended to titles of Forums, Topics, or Replies, which was happening as a consequence of calling get_the_title() which assumes every protected/private post title needs it.

It does this by including the following code changes:

• introduce the bbp_no_title_status_hints() filter function, which hooks into 2 WordPress filters and maybe overrides the return value
• replace a few get_the_title() calls with get_post_field( 'post_title' ) to bypass the above filters when they would never be desirable

Committer note: this could be considered a small back-compat break (because it alters long-standing theme-side output) but ultimately it is a design decision to output all of the forum content as it was saved by the community members. Forums that prefer the old behavior can unhook bbp_no_title_status_hints and continue to customize child template parts to insert custom forum status hints.

Fixes #3602.

File:

• trunk/src/includes/topics/template.php (modified) (1 diff)

trunk/src/includes/topics/template.php

@@ -601 +601 @@
     function bbp_get_topic_title( $topic_id = 0 ) {
         $topic_id = bbp_get_topic_id( $topic_id );
-        $title    = get_the_title( $topic_id );
+        $title    = get_post_field( 'post_title', $topic_id );
+        $title    = apply_filters( 'the_title', $title, $topic_id );
 
         // Filter & return