Changeset 7262 for branches/2.6/src/includes/search/template.php

Timestamp:

06/28/2024 06:06:30 PM (22 months ago)

Author:

johnjamesjacoby

Message:

Search: prevent hidden forums from appearing in results.

This change includes the following changes:

• Removes readable perm check from bbp_has_search_results() and replaces it with public topic statuses by default, while conditionally adding private & hidden statuses if user is capable
• Tweaks the logic inside of bbp_pre_get_posts_normalize_forum_visibility() to always handle both of its internal conditions (forum query, or any query that includes forums/topics/replies connected via meta data)
• Tweaks output of content-search.php template part to not show the "Oh bother" error when visiting a search page for the first time
• Adds a string feedback-no-search.php template part to address both "no results" and "no terms" conditions

These changes address some faulty search logic that was allowing hidden forums to appear in global search results to users who should not have been able to see them, while also improving the search page experience itself.

Fixes #3473.

Props wpsolr, robin-w.

In branches/2.6, for 2.6.10.

File:

• branches/2.6/src/includes/search/template.php (modified) (1 diff)

branches/2.6/src/includes/search/template.php

@@ -47 +47 @@
     }
 
-    // What are the default allowed statuses (based on user caps)
-    if ( bbp_get_view_all() ) {
-
-        // Default view=all statuses
-        $post_statuses = array_keys( bbp_get_topic_statuses() );
-
-        // Add support for private status
-        if ( current_user_can( 'read_private_topics' ) ) {
-            $post_statuses[] = bbp_get_private_status_id();
-        }
-
-        // Join post statuses together
-        $default['post_status'] = $post_statuses;
-
-    // Lean on the 'perm' query var value of 'readable' to provide statuses
-    } else {
-        $default['perm'] = 'readable';
-    }
+    // Default public statuses (topics coincidentally cover all post types)
+    $post_statuses = array_keys( bbp_get_public_topic_statuses() );
+
+    // Add support for private status
+    if ( current_user_can( 'read_private_topics' ) ) {
+        $post_statuses[] = bbp_get_private_status_id();
+    }
+
+    // Add support for hidden status
+    if ( current_user_can( 'read_hidden_topics' ) ) {
+        $post_statuses[] = bbp_get_hidden_status_id();
+    }
+
+    // Join post statuses together
+    $default['post_status'] = $post_statuses;
 
     /** Setup *****************************************************************/