Changeset 7190 for trunk/src/includes/core/functions.php

Timestamp:

02/18/2021 05:35:00 AM (5 years ago)

Author:

johnjamesjacoby

Message:

Users: Improve UX of form-user-passwords.php template part.

This change makes sure that the "Generate Password" UI is hidden by default if the browser has JavaScript enabled, and that the traditional UI is visible if JavaScript is not enabled.

It also includes the following related improvements:

• Introduce bbp_doing_script_debug() and bbp_doing_autosave() helpers, and use them where needed
• Introduce bbp_asset_version() and bbp_get_asset_version() to bust asset cache when debugging
• Update forum-user-passwords.php template part to swap out body class and add missing element ID
• Update password form styling in bbpress.css default theme compat CSS

In trunk for 2.7.0. Fixes #3421.

File:

• trunk/src/includes/core/functions.php (modified) (2 diffs)

trunk/src/includes/core/functions.php

@@ -33 +33 @@
 
 /**
+ * Output the bbPress asset version
+ *
+ * @since 2.6.7 bbPress (r7188)
+ */
+function bbp_asset_version() {
+    echo bbp_get_asset_version();
+}
+    /**
+     * Return the bbPress asset version
+     *
+     * @since 2.6.7 bbPress (r7188)
+     *
+     * @retrun string The bbPress asset version
+     */
+    function bbp_get_asset_version() {
+        return bbp_doing_script_debug()
+            ? (string) time()
+            : bbp_get_version();
+    }
+
+/**
  * Output the bbPress database version
  *
@@ -656 +677 @@
     exit();
 }
+
+/** Global Helpers ************************************************************/
+
+/**
+ * Return if debugging scripts or not
+ *
+ * @since 2.6.7 (r7188)
+ *
+ * @return bool True if debugging scripts. False if not debugging scripts.
+ */
+function bbp_doing_script_debug() {
+    return defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG;
+}
+
+/**
+ * Return if auto-saving or not
+ *
+ * @since 2.6.7 (r7188)
+ *
+ * @return bool True if mid auto-save. False if not mid auto-save.
+ */
+function bbp_doing_autosave() {
+    return defined( 'DOING_AUTOSAVE' ) && DOING_AUTOSAVE;
+}