Changeset 7190 for trunk/src/includes/admin/classes/class-bbp-admin.php

Timestamp:

02/18/2021 05:35:00 AM (5 years ago)

Author:

johnjamesjacoby

Message:

Users: Improve UX of form-user-passwords.php template part.

This change makes sure that the "Generate Password" UI is hidden by default if the browser has JavaScript enabled, and that the traditional UI is visible if JavaScript is not enabled.

It also includes the following related improvements:

• Introduce bbp_doing_script_debug() and bbp_doing_autosave() helpers, and use them where needed
• Introduce bbp_asset_version() and bbp_get_asset_version() to bust asset cache when debugging
• Update forum-user-passwords.php template part to swap out body class and add missing element ID
• Update password form styling in bbpress.css default theme compat CSS

In trunk for 2.7.0. Fixes #3421.

File:

• trunk/src/includes/admin/classes/class-bbp-admin.php (modified) (2 diffs)

trunk/src/includes/admin/classes/class-bbp-admin.php

@@ -816 +816 @@
         // RTL and/or minified
         $suffix  = is_rtl() ? '-rtl' : '';
-        $suffix .= defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ? '' : '.min';
+        $suffix .= bbp_doing_script_debug() ? '' : '.min';
 
         // Get the version to use for JS
-        $version = bbp_get_version();
+        $version = bbp_get_asset_version();
 
         // Register admin CSS with dashicons dependency
@@ -860 +860 @@
 
         // Minified
-        $suffix  = defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ? '' : '.min';
+        $suffix  = bbp_doing_script_debug() ? '' : '.min';
 
         // Get the version to use for JS
-        $version = bbp_get_version();
+        $version = bbp_get_asset_version();
 
         // Header JS