Changeset 7111

Timestamp:

08/03/2020 01:33:59 PM (3 years ago)

Author:

xknown

Message:

PHP 7.4 Compat: Remove the create_function calls.

They are deprecated, and they seem to be removed in PHP 8.0.

Location:

branches/1.1

Files:

• bb-admin/includes/functions.bb-admin.php (modified) (2 diffs)
• bb-admin/options-discussion.php (modified) (1 diff)
• bb-admin/options-wordpress.php (modified) (1 diff)
• search.php (modified) (1 diff)

branches/1.1/bb-admin/includes/functions.bb-admin.php

@@ -38 +38 @@
 
     $message = '<div id="message" class="' . esc_attr( $class ) . '">' . $message . '</div>';
-    $message = str_replace( "'", "\'", $message );
-    $lambda = create_function( '', "echo '$message';" );
+    $lambda = function() use( $message ) { echo $message; };
     add_action( 'bb_admin_notices', $lambda );
     return $lambda;
@@ -153 +152 @@
 
                 // Get an array of all plugin added keys
-                $plugin_menu_keys = array_filter( $menu_keys, create_function( '$v', 'if ($v >= ' . $lower . ' && $v < ' . $upper . ') { return $v; }' ) );
+                $plugin_menu_keys = array_filter( $menu_keys, function( $v ) use ( $lower, $upper ) { if ( $v >= $lower && $v < $upper ) { return $v; } } );
 
                 // If there is an array of keys

branches/1.1/bb-admin/options-discussion.php

@@ -73 +73 @@
 );
 
-$bb_get_option_avatars_show = create_function( '$a', 'return 1;' );
+$bb_get_option_avatars_show = function( $a ) { return 1; };
 add_filter( 'bb_get_option_avatars_show', $bb_get_option_avatars_show );
 $avatar_options = array(

branches/1.1/bb-admin/options-wordpress.php

@@ -53 +53 @@
 
 $bb_role_names[''] = _c( 'none|no bbPress role' );
-$bb_role_names = array_merge( $bb_role_names, array_map( create_function( '$a', 'return sprintf( _c( "bbPress %s|bbPress role" ), $a );' ), $wp_roles->get_names() ) );
+$bb_role_names = array_merge( $bb_role_names, array_map( function( $a ) { return sprintf( _c( "bbPress %s|bbPress role" ), $a ); }, $wp_roles->get_names() ) );
 
 $wpRoles = array(

branches/1.1/search.php

@@ -11 +11 @@
     
     /* Recent */
-    add_filter( 'bb_recent_search_fields',   create_function( '$f', 'return $f . ", MAX(post_time) AS post_time";' ) );
-    add_filter( 'bb_recent_search_group_by', create_function( '', 'return "t.topic_id";' ) );
+    add_filter( 'bb_recent_search_fields',   function( $f ) { return $f . ", MAX(post_time) AS post_time"; } );
+    add_filter( 'bb_recent_search_group_by', function() { return "t.topic_id"; } );
     $bb_query_form->BB_Query_Form( 'post', array(), array( 'order_by' => 'p.post_time', 'count' => true, 'per_page' => $per_page, 'post_status' => 0, 'topic_status' => 0, 'post_text' => $q, 'forum_id', 'tag', 'topic_author', 'post_author' ), 'bb_recent_search' );
     $recent = $bb_query_form->results;