Changeset 7110

Timestamp:

08/03/2020 01:20:09 PM (4 years ago)

Author:

xknown

Message:

PHP 7.4 Compat: Use square brackets and remove create_function calls.

Location:

branches/1.1

Files:

• bb-admin/export.php (modified) (2 diffs)
• bb-includes/class.bb-dir-map.php (modified) (1 diff)
• bb-includes/functions.bb-core.php (modified) (1 diff)
• bb-includes/functions.bb-deprecated.php (modified) (1 diff)
• bb-includes/functions.bb-template.php (modified) (2 diffs)
• topic.php (modified) (1 diff)

branches/1.1/bb-admin/export.php

@@ -46 +46 @@
                 $data .= str_repeat("\t", $tabs + 1) . "<meta key='$mk'><![CDATA[$mv]]></meta>\n";
         } else {
-            if ( '!' == $k{0} ) {
+            if ( '!' == $k[0] ) {
                 $k = substr($k, 1);
                 $v = "<![CDATA[$v]]>";
@@ -66 +66 @@
     $r = array();
     foreach ( $translate as $prop => $export ) {
-        if ( '?' == $export{0} ) {
+        if ( '?' == $export[0] ) {
             $export = substr($export, 1);
             if ( !$data[$prop] ) {

branches/1.1/bb-includes/class.bb-dir-map.php

@@ -74 +74 @@
             if ( in_array($this->_current_file, array('.', '..')) )
                 continue;
-            if ( !$this->dots && '.' == $this->_current_file{0} )
+            if ( !$this->dots && '.' == $this->_current_file[0] )
                 continue;
 

branches/1.1/bb-includes/functions.bb-core.php

@@ -1432 +1432 @@
         if ( $themes_dir = @dir( $_data['dir'] ) ) {
             while( ( $theme_dir = $themes_dir->read() ) !== false ) {
-                if ( is_file( $_data['dir'] . $theme_dir . '/style.css' ) && is_readable( $_data['dir'] . $theme_dir . '/style.css' ) && '.' != $theme_dir{0} ) {
+                if ( is_file( $_data['dir'] . $theme_dir . '/style.css' ) && is_readable( $_data['dir'] . $theme_dir . '/style.css' ) && '.' != $theme_dir[0] ) {
                     $r[$_name . '#' . $theme_dir] = $_name . '#' . $theme_dir;
                 }

branches/1.1/bb-includes/functions.bb-deprecated.php

@@ -552 +552 @@
 function bb_convert_path_base( $path, $from_base, $to_base ) {
     bb_log_deprecated('function', __FUNCTION__, 'no alternative');
-    $last_char = $path{strlen($path)-1};
+    $last_char = $path[strlen($path)-1];
     if ( '/' != $last_char && '\\' != $last_char )
         $last_char = '';

branches/1.1/bb-includes/functions.bb-template.php

@@ -3258 +3258 @@
 
     foreach ( (array) $tags as $tag ) {
-        $counts{$tag->raw_tag} = $tag->tag_count;
-        $taglinks{$tag->raw_tag} = bb_get_tag_link( $tag );
+        $counts[$tag->raw_tag] = $tag->tag_count;
+        $taglinks[$tag->raw_tag] = bb_get_tag_link( $tag );
     }
 
@@ -3276 +3276 @@
 
     foreach ( $counts as $tag => $count ) {
-        $taglink = esc_attr($taglinks{$tag});
+        $taglink = esc_attr($taglinks[$tag]);
         $tag = str_replace(' ', ' ', esc_html( $tag ));
         $fontsize = round( $smallest + ( ( $count - $min_count ) * $fontstep ), 1 );

branches/1.1/topic.php

@@ -15 +15 @@
 
 if ( $view_deleted ) {
-    add_filter('get_thread_where', create_function('', 'return "p.topic_id = ' . $topic_id . '";'));
-    add_filter('get_thread_post_ids', create_function('', 'return "p.topic_id = ' . $topic_id . '";'));
+    add_filter('get_thread_where', function() use ($topic_id) { return "p.topic_id = " . intval( $topic_id ); });
+    add_filter('get_thread_post_ids', function() use ($topic_id) { return "p.topic_id = " . intval( $topic_id ); });
     add_filter('post_edit_uri', 'bb_make_link_view_all');
 }