Changeset 7105

Timestamp:

06/05/2020 08:59:46 PM (6 years ago)

Author:

johnjamesjacoby

Message:

Users: Correctly calculate offset in User Profile > Last Activity.

Previous to this, Last Activity was being saved with time() but then using the site offset on display. For negative timezones, this would cause "sometime ago" type output in screens like User Profiles.

Also correctly update Last Activity when posting new Topics and Replies, and add expiration to transients for anonymous users to prevent them from being autoloaded while also never expiring.

In trunk, for 2.7.0.

Fixes #3378.

Location:

trunk/src

Files:

• includes/replies/functions.php (modified) (2 diffs)
• includes/topics/functions.php (modified) (2 diffs)
• templates/default/bbpress/user-profile.php (modified) (1 diff)

trunk/src/includes/replies/functions.php

@@ -820 +820 @@
         // Set transient for throttle check (only on new, not edit)
         if ( empty( $is_edit ) ) {
-            set_transient( '_bbp_' . bbp_current_author_ip() . '_last_posted', time() );
-        }
-
-    // If not anonymous, then
-    } else {
-        if ( empty( $is_edit ) && ! current_user_can( 'throttle' ) ) {
-            bbp_update_user_last_posted( $author_id );
+            set_transient( '_bbp_' . bbp_current_author_ip() . '_last_posted', time(), HOUR_IN_SECONDS );
         }
     }
@@ -859 +853 @@
     if ( empty( $is_edit ) ) {
 
-        // Update poster IP if not editing
+        // Update poster activity time
+        bbp_update_user_last_posted( $author_id );
+
+        // Update poster IP
         update_post_meta( $reply_id, '_bbp_author_ip', bbp_current_author_ip(), false );
 

trunk/src/includes/topics/functions.php

@@ -787 +787 @@
         // Set transient for throttle check (only on new, not edit)
         if ( empty( $is_edit ) ) {
-            set_transient( '_bbp_' . bbp_current_author_ip() . '_last_posted', time() );
-        }
-
-    // If not anonymous, then
-    } else {
-        if ( empty( $is_edit ) && ! current_user_can( 'throttle' ) ) {
-            bbp_update_user_last_posted( $author_id );
+            set_transient( '_bbp_' . bbp_current_author_ip() . '_last_posted', time(), HOUR_IN_SECONDS );
         }
     }
@@ -821 +815 @@
     if ( empty( $is_edit ) ) {
 
-        // Update poster IP if not editing
+        // Update poster activity time
+        bbp_update_user_last_posted( $author_id );
+
+        // Update poster IP
         update_post_meta( $topic_id, '_bbp_author_ip', bbp_current_author_ip(), false );
 

trunk/src/templates/default/bbpress/user-profile.php

@@ -36 +36 @@
         <?php if ( bbp_get_user_last_posted() ) : ?>
 
-            <p class="bbp-user-topic-count"><?php printf( esc_html__( 'Last Activity: %s',  'bbpress' ), bbp_get_time_since( bbp_get_user_last_posted() ) ); ?></p>
+            <p class="bbp-user-topic-count"><?php printf( esc_html__( 'Last Activity: %s',  'bbpress' ), bbp_get_time_since( bbp_get_user_last_posted(), false, true ) ); ?></p>
 
         <?php endif; ?>