Changeset 7070
- Timestamp:
- 02/09/2020 07:49:50 PM (5 years ago)
- Location:
- trunk/src/includes/admin
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/src/includes/admin/assets/js/common.js
r6472 r7070 6 6 bbp_author_id.data( 'ajax-url' ), 7 7 { 8 minchars: 1, // Allow single-digit user IDs 8 9 onSelect: function() { 9 10 var value = this.value; -
trunk/src/includes/admin/classes/class-bbp-admin.php
r7006 r7070 892 892 public function suggest_topic() { 893 893 894 // Bail early if no request 895 if ( empty( $_REQUEST['q'] ) ) { 896 wp_die( '0' ); 894 // Do some very basic request checking 895 $request = ! empty( $_REQUEST['q'] ) 896 ? trim( $_REQUEST['q'] ) 897 : ''; 898 899 // Bail early if empty request 900 if ( empty( $request ) ) { 901 wp_die(); 897 902 } 898 903 899 904 // Bail if user cannot moderate - only moderators can change hierarchy 900 905 if ( ! current_user_can( 'moderate' ) ) { 901 wp_die( '0');906 wp_die(); 902 907 } 903 908 … … 905 910 check_ajax_referer( 'bbp_suggest_topic_nonce' ); 906 911 912 // Allow the maximum number of results to be filtered 913 $number = (int) apply_filters( 'bbp_suggest_topic_count', 10 ); 914 907 915 // Try to get some topics 908 916 $topics = get_posts( array( 909 's' => bbp_db()->esc_like( $_REQUEST['q'] ), 910 'post_type' => bbp_get_topic_post_type() 917 's' => bbp_db()->esc_like( $request ), 918 'post_type' => bbp_get_topic_post_type(), 919 'posts_per_page' => $number, 920 921 // Performance 922 'nopaging' => true, 923 'suppress_filters' => true, 924 'update_post_term_cache' => false, 925 'update_post_meta_cache' => false, 926 'ignore_sticky_posts' => true, 927 'no_found_rows' => true 911 928 ) ); 912 929 … … 927 944 public function suggest_user() { 928 945 929 // Bail early if no request 930 if ( empty( $_REQUEST['q'] ) ) { 931 wp_die( '0' ); 932 } 933 934 // Bail if user cannot moderate - only moderators can change authorship 946 // Do some very basic request checking 947 $request = ! empty( $_REQUEST['q'] ) 948 ? trim( $_REQUEST['q'] ) 949 : ''; 950 951 // Bail early if empty request 952 if ( empty( $request ) ) { 953 wp_die(); 954 } 955 956 // Bail if user cannot moderate 935 957 if ( ! current_user_can( 'moderate' ) ) { 936 wp_die( '0');958 wp_die(); 937 959 } 938 960 … … 940 962 check_ajax_referer( 'bbp_suggest_user_nonce' ); 941 963 942 // Try to get some users 964 // Fields to retrieve & search by 965 $fields = $search = array( 'ID', 'user_nicename' ); 966 967 // Keymasters & Super-Mods can also search by email 968 if ( current_user_can( 'keep_gate' ) || bbp_allow_super_mods() ) { 969 970 // Add user_email to searchable columns 971 array_push( $search, 'user_email' ); 972 973 // Unstrict to also allow some email characters 974 $strict = false; 975 976 // Strict sanitizing if not Keymaster or Super-Mod 977 } else { 978 $strict = true; 979 } 980 981 // Sanitize the request value (possibly not strictly) 982 $suggest = sanitize_user( $request, $strict ); 983 984 // Bail if searching for invalid user string 985 if ( empty( $suggest ) ) { 986 wp_die(); 987 } 988 989 // These single characters should not trigger a user query 990 $disallowed_single_chars = array( '@', '.', '_', '-', '+', '!', '#', '$', '%', '&', '\\', '*', '+', '/', '=', '?', '^', '`', '{', '|', '}', '~' ); 991 992 // Bail if request is only for the above single characters 993 if ( in_array( $suggest, $disallowed_single_chars, true ) ) { 994 wp_die(); 995 } 996 997 // Allow the maximum number of results to be filtered 998 $number = (int) apply_filters( 'bbp_suggest_user_count', 10 ); 999 1000 // Query database for users based on above criteria 943 1001 $users_query = new WP_User_Query( array( 944 'search' => '*' . bbp_db()->esc_like( $_REQUEST['q'] ) . '*', 945 'fields' => array( 'ID', 'user_nicename' ), 946 'search_columns' => array( 'ID', 'user_nicename', 'user_email' ), 947 'orderby' => 'ID' 1002 'search' => '*' . bbp_db()->esc_like( $suggest ) . '*', 1003 'fields' => $fields, 1004 'search_columns' => $search, 1005 'orderby' => 'ID', 1006 'number' => $number, 1007 'count_total' => false 948 1008 ) ); 949 1009 950 // If we found some users, loop through and display them1010 // If we found some users, loop through and output them to the AJAX 951 1011 if ( ! empty( $users_query->results ) ) { 952 1012 foreach ( (array) $users_query->results as $user ) {
Note: See TracChangeset
for help on using the changeset viewer.