Changeset 7067

Timestamp:

02/07/2020 05:36:00 PM (4 years ago)

Author:

johnjamesjacoby

Message:

Templates: avoid possible fatal error in is_bbpress().

This commit confirms that the $wp_query global has been invoked before attempting to make comparisons against it. It also uses _doing_it_wrong() to alert developers to what is going on.

Props r-a-y. Fixes #3334. For 2.6.15, branches/2.6.

File:

• branches/2.6/src/includes/common/template.php (modified) (1 diff)

branches/2.6/src/includes/common/template.php

@@ -1103 +1103 @@
 function is_bbpress() {
 
-    // Defalt to false
-    $retval = false;
+    // Default to false
+    $retval = false;
+
+    // Bail if main query has not been populated.
+    if ( ! bbp_get_wp_query() ) {
+        _doing_it_wrong( __FUNCTION__, esc_html__( 'Conditional query tags do not work before the query is run. Before then, they always return false.', 'bbpress' ), '2.7.0' );
+        return $retval;
+    }
 
     /** Archives **************************************************************/