Changeset 7025 for trunk/src/includes/common/engagements.php

Timestamp:

12/12/2019 05:49:08 PM (6 years ago)

Author:

johnjamesjacoby

Message:

Engagements: update cache groups in User strategy.

This commit makes all cache groups the same, and adds an inline comment about zero value object IDs. It also fixes a performance issue with pre-2.6 non-upgraded databases causing FIND_IN_SET queries not to be retrieved from cache correctly.

See #3292. For 2.7, trunk.

File:

• trunk/src/includes/common/engagements.php (modified) (4 diffs)

trunk/src/includes/common/engagements.php

@@ -612 +612 @@
     private function get_cache_key( $meta_key = '', $object_id = 0 ) {
 
-        // No negative numbers in cache keys
+        // No negative numbers in cache keys (zero is weird, but not disallowed)
         $object_id = absint( $object_id );
 
@@ -664 +664 @@
         $cache_key = $this->get_cache_key( $meta_key, $object_id );
 
-        return wp_cache_get( $cache_key, 'bbpress_posts' );
+        return wp_cache_get( $cache_key, 'bbpress_engagements' );
     }
 
@@ -684 +684 @@
         $user_ids  = $this->parse_comma_list( $user_ids );
 
-        return wp_cache_set( $cache_key, $user_ids, 'bbpress_users' );
+        return wp_cache_set( $cache_key, $user_ids, 'bbpress_engagements' );
     }
 
@@ -703 +703 @@
         $cache_key = $this->get_cache_key( $meta_key, $object_id );
 
-        return wp_cache_delete( $cache_key, 'bbpress_users' );
+        return wp_cache_delete( $cache_key, 'bbpress_engagements' );
     }