Changeset 7011

Timestamp:

12/10/2019 02:50:08 PM (6 years ago)

Author:

johnjamesjacoby

Message:

Replies: avoid stomping t in Reply JavaScript.

This commit fixes a bug causing the adminbar to become undefined, resulting in a JavaScript error that caused hierarchical replies not to work correctly.

Props Kipperlenny. Fixes #3301. For 2.6.3, branches/2.6.

File:

• branches/2.6/src/templates/default/js/reply.js (modified) (6 diffs)

branches/2.6/src/templates/default/js/reply.js

@@ -63 +63 @@
          */
         cancel.onclick = function () {
-            var t       = addReply,
-                temp    = t.getElement( 'bbp-temp-form-div' ),
-                respond = t.getElement( t.respondId );
-
-            t.removeEditor();
+            var r       = addReply,
+                temp    = r.getElement( 'bbp-temp-form-div' ),
+                respond = r.getElement( r.respondId );
+
+            r.removeEditor();
 
             if ( ! temp || ! respond ) {
@@ -73 +73 @@
             }
 
-            t.getElement( 'bbp_reply_to' ).value = '0';
+            r.getElement( 'bbp_reply_to' ).value = '0';
 
             temp.parentNode.insertBefore( respond, temp );
@@ -81 +81 @@
             this.onclick       = null;
 
-            t.addEditor();
+            r.addEditor();
         };
 
-        t.scrollToForm(t);
+        t.scrollToForm();
 
         return false;
@@ -93 +93 @@
      *
      * @since 2.6.2
-     * @param {HTMLElement} t The HTML element.
      * @return {void}
      */
-    scrollToForm: function(t) {
+    scrollToForm: function() {
 
         /* Get initial variables to start computing boundaries */
-        var form        = t.getElement( 'new-post' ),
+        var t           = this,
+            form        = t.getElement( 'new-post' ),
             elemRect    = form.getBoundingClientRect(),
             position    = (window.pageYOffset || document.scrollTop)  - (document.clientTop || 0),
@@ -185 +185 @@
 
         /* Bail to avoid error */
-        if ( typeof (tinyMCE) === 'undefined' ) {
+        if ( typeof ( tinyMCE ) === 'undefined' ) {
             return;
         }
@@ -209 +209 @@
 
         /* Bail to avoid error */
-        if ( typeof (tinyMCE) === 'undefined' ) {
+        if ( typeof ( tinyMCE ) === 'undefined' ) {
             return;
         }