Changeset 7006 for trunk/src/includes/admin/settings.php

Timestamp:

11/24/2019 01:38:37 PM (5 years ago)

Author:

netweb

Message:

Build Tools: Add PHPCS with custom bbPress ruleset

• This changeset adds an initial bbPress PHPCS ruleset
• Future iteration of the rules in the ruleset can follow later
• To run the PHPCS check run `grunt phpcs

Fixes #3294.

File:

• trunk/src/includes/admin/settings.php (modified) (6 diffs)

trunk/src/includes/admin/settings.php

@@ -969 +969 @@
     if ( ! empty( $theme_options ) ) : ?>
 
-        <select name="_bbp_theme_package_id" id="_bbp_theme_package_id" <?php bbp_maybe_admin_setting_disabled( '_bbp_theme_package_id' ); ?>><?php echo $theme_options ?></select>
+        <select name="_bbp_theme_package_id" id="_bbp_theme_package_id" <?php bbp_maybe_admin_setting_disabled( '_bbp_theme_package_id' ); ?>><?php echo $theme_options; ?></select>
         <label for="_bbp_theme_package_id"><?php esc_html_e( 'will serve all bbPress templates', 'bbpress' ); ?></label>
 
@@ -1465 +1465 @@
         // Button & text
         $button = '<a href="' . esc_url( $new_url ) . '">' . esc_html__( 'create a new one', 'bbpress' ) . '</a>';
-        $text   = esc_html__( 'Use %s to contain your group forums, or %s', 'bbpress' );
+        $text   = esc_html__( 'Use %s to contain your group forums, or %s', 'bbpress' ); //phpcs:ignore
     } else {
         $text = esc_html__( 'Use %s to contain your group forums', 'bbpress' );
@@ -1518 +1518 @@
 
     <div class="wrap">
-        <h1 class="wp-heading-inline"><?php esc_html_e( 'Forums Settings', 'bbpress' ) ?></h1>
+        <h1 class="wp-heading-inline"><?php esc_html_e( 'Forums Settings', 'bbpress' ); ?></h1>
         <hr class="wp-header-end">
 
@@ -1568 +1568 @@
     } ?>
 
-    <select name="_bbp_converter_platform" id="_bbp_converter_platform"><?php echo $options ?></select>
+    <select name="_bbp_converter_platform" id="_bbp_converter_platform"><?php echo $options; ?></select>
     <p class="description"><?php esc_html_e( 'The previous forum software', 'bbpress' ); ?></p>
 
@@ -1793 +1793 @@
     // Starting or continuing?
     $progress_text = ! empty( $step )
-        ? sprintf( esc_html__( 'Previously stopped at step %d of %d', 'bbpress' ), $step, $max )
+        ? sprintf( esc_html__( 'Previously stopped at step %1$d of %2$d', 'bbpress' ), $step, $max )
         : esc_html__( 'Ready to go.', 'bbpress' ); ?>
 
@@ -1958 +1958 @@
  * @param bool $slug
  */
-function bbp_form_option( $option, $default = '' , $slug = false ) {
+function bbp_form_option( $option, $default = '', $slug = false ) {
     echo bbp_get_form_option( $option, $default, $slug );
 }