Changeset 7005

Timestamp:

11/24/2019 04:49:50 AM (5 years ago)

Author:

johnjamesjacoby

Message:

Engagements: explicitly query for -1 posts if no objects are known to exist.

This commit fixes an issue with the 2.5 User Engagements strategy that will cause all topics to be queried instead of none of them.

Revert r7002 and use a different syntax to avoid debug notices.

File:

• trunk/src/includes/common/engagements.php (modified) (1 diff)

trunk/src/includes/common/engagements.php

@@ -945 +945 @@
         $object_ids = $this->parse_comma_list( get_user_option( $option_key, $user_id ) );
 
+        // Maybe trick WP_Query into ".ID IN ()"
+        if ( empty( $object_ids ) ) {
+            $object_ids = array( 0 );
+        }
+
         // Maybe include these post IDs
-        if ( ! empty( $object_ids ) ) {
-            $args = array(
-                'post__in' => $object_ids
-            );
-
-        // Or maybe include nothing
-        } else {
-            $args = array(
-                'post__in' => -1 // Tricks WP_Query into ".ID IN ()"
-            );
-        }
+        $args = array(
+            'post__in' => $object_ids
+        );
 
         // Parse arguments