Changeset 6968

Timestamp:

11/19/2019 06:02:24 PM (6 years ago)

Author:

johnjamesjacoby

Message:

Default Styling: Optionally support an RTL variant of bbpress.css.

This commit allows for either/or bbpress.css or bbpress-rtl.css to exist and be enqueued as styling in the template stack, fixing a regression from 2.6.0 where the RTL CSS was expected to be appended to the end of the file.

This allows for both files to be included if they both exist, or one of them if only one does, effectively covering all bases for 2.5 and 2.6 support.

Props scmsteve for persistence. Fixes #3218. For 2.7, trunk.

File:

• trunk/src/templates/default/bbpress-functions.php (modified) (1 diff)

trunk/src/templates/default/bbpress-functions.php

@@ -119 +119 @@
     public function enqueue_styles() {
 
-        // RTL and/or minified
-        $suffix  = is_rtl() ? '-rtl' : '';
-
-        // Get and filter the bbp-default style
-        $styles = apply_filters( 'bbp_default_styles', array(
+        // Setup the default styling
+        $defaults = array(
             'bbp-default' => array(
-                'file'         => 'css/bbpress' . $suffix . '.css',
+                'file'         => 'css/bbpress.css',
                 'dependencies' => array()
             )
-        ) );
+        );
+
+        // Optionally support an RTL variant
+        if ( is_rtl() ) {
+            $defaults['bbp-default-rtl'] = array(
+                'file'         => 'css/bbpress-rtl.css',
+                'dependencies' => array()
+            );
+        }
+
+        // Get and filter the bbp-default style
+        $styles = apply_filters( 'bbp_default_styles', $defaults );
 
         // Enqueue the styles