Changeset 6931 for trunk/src/includes/replies/template.php

Timestamp:

11/09/2019 06:36:26 PM (5 years ago)

Author:

johnjamesjacoby

Message:

Topics/Replies: improved support for replies without topics.

This commit removes an assumptive call to bbp_get_topic() and avoids a debug notice when a reply is orphaned.

See #3226.

File:

• trunk/src/includes/replies/template.php (modified) (2 diffs)

trunk/src/includes/replies/template.php

@@ -441 +441 @@
         if ( bbp_is_reply( $reply_id ) ) {
             $topic_id = bbp_get_reply_topic_id( $reply_id );
+            $topic    = bbp_get_topic( $topic_id );
         } elseif ( bbp_is_topic( $reply_id ) ) {
             $topic_id = bbp_get_topic_id( $reply_id );
+            $topic    = bbp_get_topic( $topic_id );
             $reply_id = $topic_id;
         }
@@ -461 +463 @@
 
         // Get vars needed to support pending topics with unpretty links
-        $has_slug   = bbp_get_topic( $topic_id )->post_name;
+        $has_slug   = ! empty( $topic ) ? $topic->post_name : '';
         $pretty     = bbp_use_pretty_urls();
         $published  = ! bbp_is_topic_pending( $topic_id );