Changeset 6885

Timestamp:

12/20/2018 08:40:00 PM (6 years ago)

Author:

johnjamesjacoby

Message:

Formatting: update bbp_make_clickable() to better handle spaces in href attributes.

This change updates the included regular expression to avoid returning broken (or at least unexpected) HTML and allows spaces in href attributes to be encoded as expected.

Props dd32. Fixes #3237.

File:

• trunk/src/includes/common/formatting.php (modified) (1 diff)

trunk/src/includes/common/formatting.php

@@ -393 +393 @@
 
     // Cleanup of accidental links within links
-    return preg_replace( '#(<a([ \r\n\t]+[^>]+?>|>))<a [^>]+?>([^>]+?)</a></a>#i', "$1$3</a>", $r );
+    return preg_replace( '#(<a([ \r\n\t]+[^>]+?>|>))<a [^>]+?>([^>]+?)</a>([^<]*)</a>#i', "$1$3$4</a>", $r );
 }