Changeset 6868 for trunk/tests/phpunit/testcases/users/template/user.php

Timestamp:

10/08/2018 09:33:31 PM (8 years ago)

Author:

johnjamesjacoby

Message:

Accessibility: Avoid back-to-back author links.

This change ensures that avatar and display-name links are wrapped in a shared anchor, instead of each with their own.

Includes a few test changes to better suit our intentions of verifying valid & accessible HTML output.

Fixes #3220. Props dcavins.

File:

• trunk/tests/phpunit/testcases/users/template/user.php (modified) (2 diffs)

trunk/tests/phpunit/testcases/users/template/user.php

@@ -711 +711 @@
                 // Pretty permalinks
                 $this->set_permalink_structure( '/%postname%/' );
-                $author_link = '<a href="http://' . WP_TESTS_DOMAIN . '/forums/users/' . $this->keymaster_userdata->user_nicename . '/" title="View ' . $display_name .
-                        '&#039;s profile" class="bbp-author-avatar">' . $wp_avatar .
-                        '</a>&nbsp;<a href="http://' . WP_TESTS_DOMAIN . '/forums/users/' . $this->keymaster_userdata->user_nicename . '/" title="View ' . $display_name .
-                        '&#039;s profile" class="bbp-author-name">' . $display_name . '</a>';
+                $author_link = '<a href="http://' . WP_TESTS_DOMAIN . '/forums/users/' . $this->keymaster_userdata->user_nicename . '/" title="View ' . $display_name . '&#039;s profile" class="bbp-author-link"><span class="bbp-author-avatar">' . $wp_avatar .
+                        '</span>&nbsp;<span class="bbp-author-name">' . $display_name . '</span></a>';
 
                 // String.
@@ -728 +726 @@
                 $this->set_permalink_structure();
                 $author_link = '<a href="http://' . WP_TESTS_DOMAIN . '/?bbp_user=' . $this->keymaster_id . '" title="View ' . $display_name .
-                        '&#039;s profile" class="bbp-author-avatar">' . $wp_avatar .
-                        '</a>&nbsp;<a href="http://' . WP_TESTS_DOMAIN . '/?bbp_user=' . $this->keymaster_id . '" title="View ' . $display_name .
-                        '&#039;s profile" class="bbp-author-name">' . $display_name . '</a>';
+                        '&#039;s profile" class="bbp-author-link"><span class="bbp-author-avatar">' . $wp_avatar .
+                        '</span>&nbsp;<span class="bbp-author-name">' . $display_name . '</span></a>';
 
                 // String.