Changeset 6848 for trunk/tests/phpunit/testcases/forums/functions/counts.php

Timestamp:

08/09/2018 07:53:28 PM (6 years ago)

Author:

johnjamesjacoby

Message:

Tests: get all post type/status counts using bbp_get_child_counts().

• Fix a broken test, and improve a few others
• Update several count() instances that were doing expensive _ids() counts
• Strategically bust the bbpress_posts query cache group on updates

This change improves general performance and count reliability by ensuring the accuracy of forum/topic/reply relationship totals.

File:

• trunk/tests/phpunit/testcases/forums/functions/counts.php (modified) (2 diffs)

trunk/tests/phpunit/testcases/forums/functions/counts.php

@@ -415 +415 @@
         $f1 = $this->factory->forum->create();
 
+        $count = bbp_get_forum_subforum_count( $f1, true );
+        $this->assertSame( 0, $count );
+
         $f2 = $this->factory->forum->create_many( 3, array(
             'post_parent' => $f1,
@@ -420 +423 @@
 
         $count = bbp_get_forum_subforum_count( $f1, true );
-        $this->assertSame( 0, $count );
+        $this->assertSame( 3, $count );
+
+        bbp_update_forum_subforum_count( $f1, 10 );
+
+        $count = bbp_get_forum_subforum_count( $f1, true );
+        $this->assertSame( 10, $count );
 
         bbp_update_forum_subforum_count( $f1 );