Changeset 6848 for trunk/src/includes/topics/functions.php

Timestamp:

08/09/2018 07:53:28 PM (7 years ago)

Author:

johnjamesjacoby

Message:

Tests: get all post type/status counts using bbp_get_child_counts().

• Fix a broken test, and improve a few others
• Update several count() instances that were doing expensive _ids() counts
• Strategically bust the bbpress_posts query cache group on updates

This change improves general performance and count reliability by ensuring the accuracy of forum/topic/reply relationship totals.

File:

• trunk/src/includes/topics/functions.php (modified) (3 diffs)

trunk/src/includes/topics/functions.php

@@ -833 +833 @@
         bbp_update_topic_walker( $topic_id, $last_active, $forum_id, 0, false );
     }
+
+    // Bump the custom query cache
+    wp_cache_set( 'last_changed', microtime(), 'bbpress_posts' );
 }
 
@@ -888 +891 @@
             if ( bbp_is_forum( $ancestor ) ) {
 
+                // Get the forum
+                $forum = bbp_get_forum( $ancestor );
+
                 // Update the forum
                 bbp_update_forum( array(
-                    'forum_id'           => $ancestor,
+                    'forum_id'           => $forum->ID,
+                    'post_parent'        => $forum->post_parent,
                     'last_topic_id'      => $topic_id,
                     'last_reply_id'      => $reply_id,
@@ -984 +991 @@
 
     // Get reply count.
-    $public_reply_count = count( bbp_get_public_child_ids( $topic_id, bbp_get_reply_post_type() ) );
+    $public_reply_count = bbp_get_public_child_count( $topic_id, bbp_get_reply_post_type() );
 
     // Topic status.