Changeset 6848 for trunk/src/includes/replies/functions.php

Timestamp:

08/09/2018 07:53:28 PM (7 years ago)

Author:

johnjamesjacoby

Message:

Tests: get all post type/status counts using bbp_get_child_counts().

• Fix a broken test, and improve a few others
• Update several count() instances that were doing expensive _ids() counts
• Strategically bust the bbpress_posts query cache group on updates

This change improves general performance and count reliability by ensuring the accuracy of forum/topic/reply relationship totals.

File:

• trunk/src/includes/replies/functions.php (modified) (4 diffs)

trunk/src/includes/replies/functions.php

@@ -99 +99 @@
     if ( bbp_is_reply_published( $reply_id ) ) {
         bbp_increase_topic_reply_count( $topic_id );
-        bbp_increase_forum_reply_count( $reply_id );
+        bbp_increase_forum_reply_count( $forum_id );
 
     // If the reply isn't public only update the topic reply hidden count.
@@ -856 +856 @@
         bbp_update_reply_walker( $reply_id, $last_active_time, $forum_id, $topic_id, false );
     }
+
+    // Bump the custom query cache
+    wp_cache_set( 'last_changed', microtime(), 'bbpress_posts' );
 }
 
@@ -1002 +1005 @@
 
     // Update the forum ID
-    $forum_id = bbp_update_forum_id( $reply_id, $forum_id );
+    $retval = bbp_update_forum_id( $reply_id, $forum_id );
 
     // Filter & return
-    return (int) apply_filters( 'bbp_update_reply_forum_id', $forum_id, $reply_id );
+    return (int) apply_filters( 'bbp_update_reply_forum_id', $retval, $reply_id, $forum_id );
 }
 
@@ -1045 +1048 @@
 
     // Update the topic ID
-    $topic_id = bbp_update_topic_id( $reply_id, $topic_id );
+    $retval = bbp_update_topic_id( $reply_id, $topic_id );
 
     // Filter & return
-    return (int) apply_filters( 'bbp_update_reply_topic_id', $topic_id, $reply_id );
+    return (int) apply_filters( 'bbp_update_reply_topic_id', $retval, $reply_id, $topic_id );
 }