Changeset 6848 for trunk/src/includes/forums/functions.php

Timestamp:

08/09/2018 07:53:28 PM (7 years ago)

Author:

johnjamesjacoby

Message:

Tests: get all post type/status counts using bbp_get_child_counts().

• Fix a broken test, and improve a few others
• Update several count() instances that were doing expensive _ids() counts
• Strategically bust the bbpress_posts query cache group on updates

This change improves general performance and count reliability by ensuring the accuracy of forum/topic/reply relationship totals.

File:

• trunk/src/includes/forums/functions.php (modified) (8 diffs)

trunk/src/includes/forums/functions.php

@@ -75 +75 @@
     // Update the forum and hierarchy
     bbp_update_forum( array(
-        'forum_id' => $forum_id
+        'forum_id'    => $forum_id,
+        'post_parent' => $forum_data['post_parent']
     ) );
 
@@ -99 +100 @@
      */
     do_action( 'bbp_insert_forum', (int) $forum_id );
+
+    // Bump the last changed cache
+    wp_cache_set( 'last_changed', microtime(), 'bbpress_posts' );
 
     // Return forum_id
@@ -1367 +1371 @@
 
     // Get the topic's replies.
-    $replies = bbp_get_public_child_ids( $topic_id, bbp_get_reply_post_type() );
-    $count   = count( $replies );
+    $count = bbp_get_public_child_count( $topic_id, bbp_get_reply_post_type() );
 
     // If we're unapproving, set count to negative.
@@ -1593 +1596 @@
     $forum_id = bbp_get_forum_id( $forum_id );
 
+    // Maybe query for counts
     if ( empty( $subforums ) ) {
-        $subforums = count( bbp_forum_query_subforum_ids( $forum_id ) );
+        $subforums = bbp_get_public_child_count( $forum_id, bbp_get_forum_post_type() );
     }
 
@@ -1629 +1633 @@
 
     // Get total topics for this forum
-    $topics = (int) count( bbp_forum_query_topic_ids( $forum_id ) );
+    $topics = bbp_get_public_child_count( $forum_id, bbp_get_topic_post_type() );
 
     // Calculate total topics in this forum
@@ -1729 +1733 @@
     $topic_ids   = bbp_forum_query_topic_ids( $forum_id );
     if ( ! empty( $topic_ids ) ) {
-        $query = new WP_Query( array(
-            'fields'          => 'ids',
-            'post_parent__in' => $topic_ids,
-            'post_status'     => bbp_get_public_status_id(),
-            'post_type'       => bbp_get_reply_post_type(),
-            'posts_per_page'  => -1,
-
-            // Performance
-            'nopaging'               => true,
-            'suppress_filters'       => true,
-            'update_post_term_cache' => false,
-            'update_post_meta_cache' => false,
-            'ignore_sticky_posts'    => true,
-            'no_found_rows'          => true
-        ) );
-        $reply_count = ! empty( $query->posts ) ? count( $query->posts ) : 0;
-        unset( $query );
+        $reply_count = bbp_get_public_child_count( $forum_id, bbp_get_reply_post_type() );
     }
 
@@ -1788 +1776 @@
     ), 'update_forum' );
 
+    // Update the forum parent
+    bbp_update_forum_id( $r['forum_id'], $r['post_parent'] );
+
     // Last topic and reply ID's
     bbp_update_forum_last_topic_id( $r['forum_id'], $r['last_topic_id'] );
@@ -1821 +1812 @@
         ) );
     }
+
+    // Bump the custom query cache
+    wp_cache_set( 'last_changed', microtime(), 'bbpress_posts' );
 }