Changeset 6827 for trunk/src/includes/topics/functions.php

Timestamp:

07/05/2018 06:03:38 AM (7 years ago)

Author:

johnjamesjacoby

Message:

Counts: Introduce a cacheable parent/type/status wrapper, filter helpers.

This change introduces a common query function for totalling up all counts by type & status, and caching the results for later usages. By doing this, we can avoid running multiple queries for the same public or non-public counts.

Also uses bbp_number_not_negative() in a few places where negative counts are never allowed.

File:

• trunk/src/includes/topics/functions.php (modified) (2 diffs)

trunk/src/includes/topics/functions.php

@@ -2471 +2471 @@
 
     // Get replies of topic if not passed
-    if ( empty( $reply_count ) ) {
-        $reply_count = bbp_get_public_child_count( $topic_id, bbp_get_reply_post_type() );
-    }
-
-    $reply_count = (int) $reply_count;
+    $reply_count = empty( $reply_count )
+        ? bbp_get_public_child_count( $topic_id, bbp_get_reply_post_type() )
+        : (int) $reply_count;
 
     update_post_meta( $topic_id, '_bbp_reply_count', $reply_count );
@@ -2501 +2499 @@
 
     // Get replies of topic
-    if ( empty( $reply_count ) ) {
-        $statuses    = bbp_get_non_public_topic_statuses();
-        $post_status = "'" . implode( "','", $statuses ) . "'";
-        $bbp_db      = bbp_db();
-        $query       = $bbp_db->prepare( "SELECT COUNT(ID) FROM {$bbp_db->posts} WHERE post_parent = %d AND post_status IN ( {$post_status} ) AND post_type = %s", $topic_id, bbp_get_reply_post_type() );
-        $reply_count = $bbp_db->get_var( $query );
-    }
-
-    $reply_count = (int) $reply_count;
+    $reply_count = empty( $reply_count )
+        ? bbp_get_non_public_child_count( $topic_id, 'reply' )
+        : (int) $reply_count;
 
     update_post_meta( $topic_id, '_bbp_reply_count_hidden', $reply_count );