Changeset 6815 for trunk/src/includes/extend/buddypress/notifications.php

Timestamp:

04/23/2018 05:05:30 AM (8 years ago)

Author:

johnjamesjacoby

Message:

BuddyPress: tweak notifications item IDs to provide a bit more context.

This change also fixes a bug with hierarchical reply notifications.

Props jpolakovic. Fixes #2834.

File:

• trunk/src/includes/extend/buddypress/notifications.php (modified) (1 diff)

trunk/src/includes/extend/buddypress/notifications.php

@@ -153 +153 @@
     );
 
-    // Notify the topic author if not the current reply author
-    if ( $author_id !== $topic_author_id ) {
+    // Notify the topic author if not the current reply author
+    if ( $author_id !== $topic_author_id ) {
         $args['secondary_item_id'] = $secondary_item_id ;
 
         bp_notifications_add_notification( $args );
-    }
-
-    // Notify the immediate reply author if not the current reply author
-    if ( ! empty( $reply_to ) && ( $author_id !== $reply_to_item_id ) ) {
-        $args['secondary_item_id'] = $reply_to_item_id ;
+    }
+
+    // Notify the immediate reply author if not the current reply author
+    if ( ! empty( $reply_to ) && ( $author_id !== $reply_to_item_id ) ) {
+        $args['user_id']           = $reply_to_item_id;
+        $args['secondary_item_id'] = $topic_author_id;
 
         bp_notifications_add_notification( $args );
-    }
+    }
 }