Changeset 6791 for trunk/src/includes/topics/functions.php

Timestamp:

03/29/2018 06:03:12 PM (7 years ago)

Author:

johnjamesjacoby

Message:

Admin: improve topic/reply row-action UX.

This change includes more improvements to how topics and replies are toggled from an admin area list-table:

• Move "Empty Spam" buttons to their own actions div
• Allow spam/trash/approve/unapprove from any other status, so topics/replies can be more freely moved around
• Add public/non-public functions for replies to match topics

See #1799.

File:

• trunk/src/includes/topics/functions.php (modified) (4 diffs)

trunk/src/includes/topics/functions.php

@@ -2736 +2736 @@
 
     // Get previous topic status meta
+    $status       = bbp_get_closed_status_id();
     $topic_status = get_post_meta( $topic_id, '_bbp_status', true );
 
     // Bail if already closed and topic status meta exists
-    if ( bbp_get_closed_status_id() === $topic->post_status && ! empty( $topic_status ) ) {
+    if ( $status === $topic->post_status && ! empty( $topic_status ) ) {
         return false;
     }
 
     // Set status meta public
-    $topic_status = bbp_get_public_status_id();
+    $topic_status = $topic->post_status;
 
     // Execute pre close code
@@ -2753 +2754 @@
 
     // Set closed status
-    $topic->post_status = bbp_get_closed_status_id();
+    $topic->post_status = $status;
 
     // Toggle revisions off as we are not altering content
@@ -3171 +3172 @@
 
     // Set publish status
-    $topic->post_status = bbp_get_public_status_id();
+    $topic->post_status = $status;
 
     // No revisions
@@ -3205 +3206 @@
     $status = bbp_get_pending_status_id();
 
-    // Bail if already pending
-    if ( $status === $topic->post_status ) {
+    // Bail if already unapproved
+    if ( ! bbp_is_topic_public( $topic_id ) ) {
         return false;
     }