Changeset 6790 for trunk/src/includes/topics/functions.php

Timestamp:

03/27/2018 07:38:26 PM (7 years ago)

Author:

johnjamesjacoby

Message:

Admin: improve topic/reply row-action UX.

This change includes a few improvements to how topics and replies are toggled from an admin area list-table:

• Make approve & not-spam links green to match comments UI
• More specifically target admin area links to avoid conflicts with other post types
• Make "Approve" a blanket "publish" action, meaning it will always publish a topic/reply even from spam or trash
• Make sure "Not Spam" will restore to "pending" if it was previously not published
• Bump CSS version

See #1799.

File:

• trunk/src/includes/topics/functions.php (modified) (5 diffs)

trunk/src/includes/topics/functions.php

@@ -2853 +2853 @@
     }
 
+    // Get new status
+    $status = bbp_get_spam_status_id();
+
     // Bail if topic is spam
-    if ( bbp_get_spam_status_id() === $topic->post_status ) {
+    if ( $status === $topic->post_status ) {
         return false;
     }
@@ -2865 +2868 @@
 
     // Set post status to spam
-    $topic->post_status = bbp_get_spam_status_id();
+    $topic->post_status = $status;
 
     // Empty the topic of its tags
@@ -3156 +3159 @@
     }
 
+    // Get new status
+    $status = bbp_get_public_status_id();
+
     // Bail if already approved
-    if ( bbp_get_pending_status_id() !== $topic->post_status ) {
+    if ( $status === $topic->post_status ) {
         return false;
     }
@@ -3196 +3202 @@
     }
 
+    // Get new status
+    $status = bbp_get_pending_status_id();
+
     // Bail if already pending
-    if ( bbp_get_pending_status_id() === $topic->post_status ) {
+    if ( $status === $topic->post_status ) {
         return false;
     }
@@ -3205 +3214 @@
 
     // Set pending status
-    $topic->post_status = bbp_get_pending_status_id();
+    $topic->post_status = $status;
 
     // No revisions