Changeset 6790 for trunk/src/includes/admin/topics.php

Timestamp:

03/27/2018 07:38:26 PM (7 years ago)

Author:

johnjamesjacoby

Message:

Admin: improve topic/reply row-action UX.

This change includes a few improvements to how topics and replies are toggled from an admin area list-table:

• Make approve & not-spam links green to match comments UI
• More specifically target admin area links to avoid conflicts with other post types
• Make "Approve" a blanket "publish" action, meaning it will always publish a topic/reply even from spam or trash
• Make sure "Not Spam" will restore to "pending" if it was previously not published
• Bump CSS version

See #1799.

File:

• trunk/src/includes/admin/topics.php (modified) (3 diffs)

trunk/src/includes/admin/topics.php

@@ -589 +589 @@
                 check_admin_referer( 'approve-topic_' . $topic_id );
 
-                $is_approve = bbp_is_topic_pending( $topic_id );
-                $message    = ( true === $is_approve )
-                    ? 'approved'
-                    : 'unapproved';
-                $success    = ( true === $is_approve )
+                $is_approve = bbp_is_topic_published( $topic_id );
+                $message    = ( false === $is_approve )
+                    ? 'unapproved'
+                    : 'approved';
+                $success    = ( false === $is_approve )
                     ? bbp_approve_topic( $topic_id )
                     : bbp_unapprove_topic( $topic_id );
@@ -788 +788 @@
             'closed',
             'spam',
+            'unspam',
             'trash',
             'untrash',
@@ -1011 +1012 @@
             $spam_uri = wp_nonce_url( add_query_arg( array( 'topic_id' => $topic->ID, 'action' => 'bbp_toggle_topic_spam' ), remove_query_arg( array( 'bbp_topic_toggle_notice', 'topic_id', 'failed', 'super' ) ) ), 'spam-topic_'  . $topic->ID );
             if ( bbp_is_topic_spam( $topic->ID ) ) {
-                $actions['spam'] = '<a href="' . esc_url( $spam_uri ) . '" title="' . esc_attr__( 'Mark the topic as not spam', 'bbpress' ) . '">' . esc_html__( 'Not spam', 'bbpress' ) . '</a>';
+                $actions['unspam'] = '<a href="' . esc_url( $spam_uri ) . '" title="' . esc_attr__( 'Mark the topic as not spam', 'bbpress' ) . '">' . esc_html__( 'Not Spam', 'bbpress' ) . '</a>';
             } else {
                 $actions['spam'] = '<a href="' . esc_url( $spam_uri ) . '" title="' . esc_attr__( 'Mark this topic as spam',    'bbpress' ) . '">' . esc_html__( 'Spam',     'bbpress' ) . '</a>';