Changeset 6785 for trunk/src/includes/users/functions.php

Timestamp:

02/19/2018 07:00:55 AM (7 years ago)

Author:

johnjamesjacoby

Message:

Converter: remove WP_SETUP_CONFIG constant setting from converter process.

This introduces a helper database class to avoid directly connecting to the external database. Instead, we'll attempt to control that connection, and provide feedback to the user in the event a connection cannot be made. The WP_SETUP_CONFIG was causing calls to the options API to fail, resulting in broken calculations and invalid offsets.

This commit includes some general load order clean-up, which also fixes a regression causing fatal errors when attempting to upgrade converted user passwords from the old platform. It also fixes the condition where boundaries being converted would display beyond their maximums.

Fixes #3191.

File:

• trunk/src/includes/users/functions.php (modified) (1 diff)

trunk/src/includes/users/functions.php

@@ -982 +982 @@
 
     // Try to call the conversion method
-    if ( is_a( $converter, 'BBP_Converter_Base' ) && method_exists( $converter, 'callback_pass' ) ) {
+    if ( ( $converter instanceof BBP_Converter_Base ) && method_exists( $converter, 'callback_pass' ) ) {
         $converter->callback_pass( $username, $_POST['pwd'] );
     }