Changeset 6784

Timestamp:

02/16/2018 10:37:15 PM (7 years ago)

Author:

johnjamesjacoby

Message:

Titles: error if forum/topic/reply title is too long.

This change introduces bbp_is_title_too_long() and adds error messages to related forms if titles are too long.

Fixes #3189.

Location:

trunk/src/includes

Files:

• common/formatting.php (modified) (1 diff)
• common/functions.php (modified) (1 diff)
• forums/functions.php (modified) (2 diffs)
• replies/functions.php (modified) (2 diffs)
• topics/functions.php (modified) (2 diffs)

trunk/src/includes/common/formatting.php

@@ -748 +748 @@
     return $reason;
 }
-

trunk/src/includes/common/functions.php

@@ -2310 +2310 @@
         : 'http://';
 }
+
+/** Titles ********************************************************************/
+
+/**
+ * Is a title longer that the maximum title length?
+ *
+ * @since 2.6.0 bbPress (r6783)
+ *
+ * @param string $title
+ * @return bool
+ */
+function bbp_is_title_too_long( $title = '' ) {
+    $max    = bbp_get_title_max_length();
+    $len    = mb_strlen( $title, '8bit' );
+    $result = ( $len > $max );
+
+    // Filter & return
+    return (bool) apply_filters( 'bbp_is_title_too_long', $result, $title, $max, $len );
+}

trunk/src/includes/forums/functions.php

@@ -162 +162 @@
     }
 
+    // Title too long
+    if ( bbp_is_title_too_long( $forum_title ) ) {
+        bbp_add_error( 'bbp_forum_title', __( '<strong>ERROR</strong>: Your title is too long.', 'bbpress' ) );
+    }
+
     /** Forum Content *********************************************************/
 
@@ -446 +451 @@
     }
 
+    // Title too long
+    if ( bbp_is_title_too_long( $forum_title ) ) {
+        bbp_add_error( 'bbp_forum_title', __( '<strong>ERROR</strong>: Your title is too long.', 'bbpress' ) );
+    }
+
     /** Forum Content *********************************************************/
 

trunk/src/includes/replies/functions.php

@@ -275 +275 @@
     $reply_title = apply_filters( 'bbp_new_reply_pre_title', $reply_title );
 
+    // Title too long
+    if ( bbp_is_title_too_long( $reply_title ) ) {
+        bbp_add_error( 'bbp_reply_title', __( '<strong>ERROR</strong>: Your title is too long.', 'bbpress' ) );
+    }
+
     /** Reply Content *********************************************************/
 
@@ -587 +592 @@
     $reply_title = apply_filters( 'bbp_edit_reply_pre_title', $reply_title, $reply_id );
 
+    // Title too long
+    if ( bbp_is_title_too_long( $reply_title ) ) {
+        bbp_add_error( 'bbp_reply_title', __( '<strong>ERROR</strong>: Your title is too long.', 'bbpress' ) );
+    }
+
     /** Reply Content *********************************************************/
 

trunk/src/includes/topics/functions.php

@@ -159 +159 @@
     }
 
+    // Title too long
+    if ( bbp_is_title_too_long( $topic_title ) ) {
+        bbp_add_error( 'bbp_topic_title', __( '<strong>ERROR</strong>: Your title is too long.', 'bbpress' ) );
+    }
+
     /** Topic Content *********************************************************/
 
@@ -526 +531 @@
     }
 
+    // Title too long
+    if ( bbp_is_title_too_long( $topic_title ) ) {
+        bbp_add_error( 'bbp_topic_title', __( '<strong>ERROR</strong>: Your title is too long.', 'bbpress' ) );
+    }
+
     /** Topic Content *********************************************************/