Changeset 6772 for trunk/src/includes/admin/topics.php

Timestamp:

01/23/2018 11:26:56 PM (9 years ago)

Author:

johnjamesjacoby

Message:

Admin: enforce row-action order for forums, topics, and replies.

This change introduces a known (and filterable) sort-order to row-action keys, allowing for a more logical flow to better match Posts, Pages, and other WordPress core objects.

With slight variations, the flow is: Edit, Stick(to front), Un/approve, Open/Close, Delete/Trash, Spam, View.

Previous to this change, these row_actions() filters were only appending or overwriting keys, which introduced an unnecessary administration variation with no real benefit.

File:

• trunk/src/includes/admin/topics.php (modified) (3 diffs)

trunk/src/includes/admin/topics.php

@@ -777 +777 @@
 
         /**
+         * Returns an array of keys used to sort row actions
+         *
+         * @since 2.6.0 bbPress (r6771)
+         *
+         * @return array
+         */
+        private function get_row_action_sort_order() {
+
+                // Filter & return
+                return (array) apply_filters( 'bbp_admin_topics_row_action_sort_order', array(
+                        'edit',
+                        'stick',
+                        'approved',
+                        'unapproved',
+                        'closed',
+                        'spam',
+                        'trash',
+                        'untrash',
+                        'delete',
+                        'view'
+                ) );
+        }
+
+        /**
          * Returns an array of notice toggles
          *
@@ -930 +954 @@
          * @since 2.0.0 bbPress (r2485)
          *
-         * @param array $actions Actions
-         * @param array $topic Topic object
+         * @param array  $actions Actions
+         * @param object $topic Topic object
+         *
          * @return array $actions Actions
          */
-        public function row_actions( $actions, $topic ) {
-
+        public function row_actions( $actions = array(), $topic = false ) {
+
+                // Disable quick edit (too much to do here)
                 unset( $actions['inline hide-if-no-js'] );
 
@@ -1014 +1040 @@
                 }
 
-                return $actions;
+                // Sort & return
+                return $this->sort_row_actions( $actions );
+        }
+
+        /**
+         * Sort row actions by key
+         *
+         * @since 2.6.0
+         *
+         * @param array $actions
+         *
+         * @return array
+         */
+        private function sort_row_actions( $actions = array() ) {
+
+                // Return value
+                $retval = array();
+
+                // Known row actions, in sort order
+                $known_actions = $this->get_row_action_sort_order();
+
+                // Sort known actions, and keep any unknown ones
+                foreach ( $known_actions as $key ) {
+                        if ( isset( $actions[ $key ] ) ) {
+                                $retval[ $key ] = $actions[ $key ];
+                                unset( $actions[ $key ] );
+                        }
+                }
+
+                // Combine & return
+                return $retval + $actions;
         }