Changeset 6745 for trunk/src/includes/replies/template.php

Timestamp:

11/29/2017 12:46:17 AM (7 years ago)

Author:

johnjamesjacoby

Message:

URLs: Audit the usage of trailingslashit().

This change ensures that trailing slashes are only used at the end of URLs where they're expected, and avoids adding slashes at the end of URLs when permalinks are configured not to include them.

See #3181.

File:

• trunk/src/includes/replies/template.php (modified) (2 diffs)

trunk/src/includes/replies/template.php

@@ -459 +459 @@
         // Don't include pagination if on first page
         if ( 1 >= $reply_page ) {
-            $url = trailingslashit( $topic_url ) . $reply_hash;
+            $url = user_trailingslashit( $topic_url ) . $reply_hash;
 
         // Include pagination
@@ -466 +466 @@
             // Pretty permalinks
             if ( bbp_use_pretty_urls() ) {
-                $url = trailingslashit( $topic_url ) . trailingslashit( bbp_get_paged_slug() ) . trailingslashit( $reply_page ) . $reply_hash;
+                $url = trailingslashit( $topic_url ) . trailingslashit( bbp_get_paged_slug() ) . $reply_page;
+                $url = user_trailingslashit( $url ) . $reply_hash;
 
             // Yucky links