Changeset 6745 for trunk/src/includes/common/template.php

Timestamp:

11/29/2017 12:46:17 AM (8 years ago)

Author:

johnjamesjacoby

Message:

URLs: Audit the usage of trailingslashit().

This change ensures that trailing slashes are only used at the end of URLs where they're expected, and avoids adding slashes at the end of URLs when permalinks are configured not to include them.

See #3181.

File:

• trunk/src/includes/common/template.php (modified) (2 diffs)

trunk/src/includes/common/template.php

@@ -2054 +2054 @@
         // Pretty permalinks
         if ( bbp_use_pretty_urls() ) {
+
+            // Run through home_url()
             $url = trailingslashit( bbp_get_root_url() . bbp_get_view_slug() ) . $view;
             $url = user_trailingslashit( $url );
@@ -2306 +2308 @@
         // Do we want to include a link to home?
         if ( ! empty( $r['include_home'] ) || empty( $r['home_text'] ) ) {
-            $crumbs[] = '<a href="' . trailingslashit( home_url() ) . '" class="bbp-breadcrumb-home">' . $r['home_text'] . '</a>';
+            $crumbs[] = '<a href="' . esc_url( home_url() ) . '" class="bbp-breadcrumb-home">' . $r['home_text'] . '</a>';
         }