Skip to:
Content

bbPress.org

Changeset 6722


Ignore:
Timestamp:
10/10/2017 05:21:08 PM (9 years ago)
Author:
johnjamesjacoby
Message:

Formatting: Use mb_substr() where appropriate.

This change ensures that strings which are known to contain or allow for multibyte characters are allowed to do so (in excerpts and a few server globals.)

Fixes #3170. Props it4life.

Location:
trunk/src/includes
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/src/includes/common/formatting.php

    r6649 r6722  
    729729    $reason = (string) $reason;
    730730
    731     // Format reason for proper display
     731    // Bail if reason is empty
    732732    if ( empty( $reason ) ) {
    733733        return $reason;

  • trunk/src/includes/replies/template.php

    r6719 r6722  
    596596
    597597        if ( ! empty( $length ) && ( $excerpt_length > $length ) ) {
    598             $excerpt  = substr( $excerpt, 0, $length - 1 );
     598            $excerpt  = mb_substr( $excerpt, 0, $length - 1 );
    599599            $excerpt .= '…';
    600600        }

  • trunk/src/includes/topics/template.php

    r6719 r6722  
    705705
    706706        if ( ! empty( $length ) && ( $excerpt_length > $length ) ) {
    707             $excerpt  = substr( $excerpt, 0, $length - 1 );
     707            $excerpt  = mb_substr( $excerpt, 0, $length - 1 );
    708708            $excerpt .= '…';
    709709        }

  • trunk/src/includes/users/functions.php

    r6706 r6722  
    164164function bbp_current_author_ua() {
    165165    $retval = ! empty( $_SERVER['HTTP_USER_AGENT'] )
    166         ? substr( $_SERVER['HTTP_USER_AGENT'], 0, 254 )
     166        ? mb_substr( $_SERVER['HTTP_USER_AGENT'], 0, 254 )
    167167        : '';
    168168
Note: See TracChangeset for help on using the changeset viewer.