Changeset 6677

Timestamp:

09/05/2017 02:31:26 AM (8 years ago)

Author:

johnjamesjacoby

Message:

Converter: Add toggle to show/hide the database password contents.

This change provides a relatively sane middle-ground for insecure content warnings in the converter, by providing a button to toggle the password field back and forth to a text field. Ideally, in the future, there will be a legitimate way to do this.

Trunk, for 2.6. See #3153.

Location:

trunk/src

Files:

• bbpress.php (modified) (1 diff)
• includes/admin/assets/css/admin.css (modified) (1 diff)
• includes/admin/assets/js/converter.js (modified) (1 diff)
• includes/admin/settings.php (modified) (1 diff)

trunk/src/bbpress.php

@@ -204 +204 @@
         /** Versions **********************************************************/
 
-        $this->version    = '2.6-rc-6622';
+        $this->version    = '2.6-rc-6677';
         $this->db_version = '262';
 

trunk/src/includes/admin/assets/css/admin.css

@@ -482 +482 @@
 }
 
+.bbp-converter-db-password-wrapper {
+    display: inline-block;
+    position: relative;
+}
+
+#_bbp_converter_db_pass::-webkit-credentials-auto-fill-button {
+    display: none;
+    visibility: hidden;
+    pointer-events: none;
+    position: absolute;
+    right: 0;
+}
+
+button.bbp-db-pass-toggle {
+    border: none;
+    background: #fff;
+    position: absolute;
+    right: 3px;
+    top: 3px;
+    padding: 0;
+    margin: 0;
+    cursor: pointer;
+    color: #aaa;
+    height: 25px;
+    width: 25px;
+    font: 400 20px/1 dashicons !important;
+}
+
+button.bbp-db-pass-toggle:hover {
+    color: #888;
+}
+button.bbp-db-pass-toggle.text:after {
+    content: '\f530';
+}
+button.bbp-db-pass-toggle.password:after {
+    content: '\f177';
+}
+
+@media screen and ( max-width: 782px ) {
+    .bbp-converter-db-password-wrapper {
+        width: 100%;
+    }
+
+    button.bbp-db-pass-toggle {
+        height: 35px;
+        width: 35px;
+        font: 400 20px/1 dashicons !important;
+    }
+}
+
 /* Tools */
 

trunk/src/includes/admin/assets/js/converter.js

@@ -10 +10 @@
         restart  = $( '#_bbp_converter_restart' ),
         status   = $( '#bbp-converter-status'   ),
-        settings = $( '#bbp-converter-settings' );
+        settings = $( '#bbp-converter-settings' ),
+        password = $( '#_bbp_converter_db_pass' ),
+        toggle   = $( '.bbp-db-pass-toggle'     );
+
+    /**
+     * Show/hide db password button toggle
+     *
+     * @since 2.6.0 bbPress (r6676)
+     *
+     * @param {element} e
+     */
+    toggle.on( 'click', function( e ) {
+        password.attr( 'type' ) === 'password'
+            ? password.attr( 'type', 'text' )
+            : password.attr( 'type', 'password' );
+
+        toggle
+            .toggleClass( 'password' )
+            .toggleClass( 'text' );
+
+        e.preventDefault();
+    });
 
     /**

trunk/src/includes/admin/settings.php

@@ -1601 +1601 @@
 ?>
 
-    <input name="_bbp_converter_db_pass" id="_bbp_converter_db_pass" type="password" class="code" value="<?php bbp_form_option( '_bbp_converter_db_pass' ); ?>" autocomplete="off" <?php bbp_maybe_admin_setting_disabled( '_bbp_converter_db_pass' ); ?> />
+    <span class="bbp-converter-db-password-wrapper">
+        <input name="_bbp_converter_db_pass" id="_bbp_converter_db_pass" type="password" class="code" value="<?php bbp_form_option( '_bbp_converter_db_pass' ); ?>" autocomplete="off" <?php bbp_maybe_admin_setting_disabled( '_bbp_converter_db_pass' ); ?> />
+        <button type="button" class="bbp-db-pass-toggle password">
+            <span class="screen-reader-text"><?php esc_html_e( 'Toggle', 'bbpress' ); ?></span>
+            <span class="toggle-indicator" aria-hidden="true"></span>
+        </button>
+    </span>
     <label for="_bbp_converter_db_pass"><?php esc_html_e( 'Password for the above database user', 'bbpress' ); ?></label>