Changeset 6670 for trunk/src/includes/admin/converters/phpBB.php

Timestamp:

08/27/2017 11:24:00 PM (8 years ago)

Author:

johnjamesjacoby

Message:

Converter: more OOP, specifically for the BBCode parser.

This change introduces a bbcode_parser_properties array to the base converter, allowing custom BBCode parser properties to be passed into the parent method via the child, minimizing the amount of code in each individual forum converter.

Trunk, for 2.6.

File:

• trunk/src/includes/admin/converters/phpBB.php (modified) (7 diffs)

trunk/src/includes/admin/converters/phpBB.php

@@ -21 +21 @@
      *
      */
-    function __construct() {
+    public function __construct() {
         parent::__construct();
-        $this->setup_globals();
     }
 
@@ -30 +29 @@
      */
     public function setup_globals() {
+
+        // Setup smiley URL & path
+        $this->bbcode_parser_properties = array(
+            'smiley_url' => false,
+            'smiley_dir' => false
+        );
 
         /** Forum Section *****************************************************/
@@ -832 +837 @@
 
     /**
-     * Translate the forum type from phpBB v3.x numeric's to WordPress's strings.
+     * Translate the forum type from phpBB v3.x numerics to WordPress's strings.
      *
      * @param int $status phpBB v3.x numeric forum type
@@ -852 +857 @@
 
     /**
-     * Translate the forum status from phpBB v3.x numeric's to WordPress's strings.
+     * Translate the forum status from phpBB v3.x numerics to WordPress's strings.
      *
      * @param int $status phpBB v3.x numeric forum status
@@ -872 +877 @@
 
     /**
-     * Translate the topic status from phpBB v3.x numeric's to WordPress's strings.
+     * Translate the topic status from phpBB v3.x numerics to WordPress's strings.
      *
      * @param int $status phpBB v3.x numeric topic status
@@ -892 +897 @@
 
     /**
-     * Translate the topic sticky status type from phpBB 3.x numeric's to WordPress's strings.
+     * Translate the topic sticky status type from phpBB 3.x numerics to WordPress's strings.
      *
      * @param int $status phpBB 3.x numeric forum type
@@ -1018 +1023 @@
 
         // Parse out any bbCodes in $field with the BBCode 'parser.php'
-        require_once bbpress()->admin->admin_dir . 'parser.php';
-        $bbcode = BBCode::getInstance();
-        $bbcode->enable_smileys = false;
-        $bbcode->smiley_regex   = false;
-        return html_entity_decode( $bbcode->Parse( $field ) );
+        return parent::callback_html( $field );
     }
 }