Changeset 6670 for trunk/src/includes/admin/classes/class-bbp-converter-base.php

Timestamp:

08/27/2017 11:24:00 PM (8 years ago)

Author:

johnjamesjacoby

Message:

Converter: more OOP, specifically for the BBCode parser.

This change introduces a bbcode_parser_properties array to the base converter, allowing custom BBCode parser properties to be passed into the parent method via the child, minimizing the amount of code in each individual forum converter.

Trunk, for 2.6.

File:

• trunk/src/includes/admin/classes/class-bbp-converter-base.php (modified) (5 diffs)

trunk/src/includes/admin/classes/class-bbp-converter-base.php

@@ -91 +91 @@
     public $clean = false;
 
+    /**
+     * @var array Custom BBCode class properties in a key => value format
+     */
+    public $bbcode_parser_properties = array();
+
     /** Methods ***************************************************************/
 
@@ -98 +103 @@
     public function __construct() {
         $this->init();
+        $this->setup_globals();
     }
 
@@ -106 +112 @@
      */
     private function init() {
+
+        /** BBCode Parse Properties *******************************************/
+
+        // Setup smiley URL & path
+        $this->bbcode_parser_properties = array(
+            'smiley_url' => includes_url( 'images/smilies' ),
+            'smiley_dir' => '/' . WPINC . '/images/smilies'
+        );
 
         /** Sanitize Options **************************************************/
@@ -250 +264 @@
         );
     }
+
+    /**
+     * Setup global values
+     */
+    public function setup_globals() {}
 
     /**
@@ -1128 +1147 @@
         $bbcode = BBCode::getInstance();
 
-        // Setup smiley URL & path
-        $bbcode->smiley_url = includes_url( 'images/smilies' );
-        $bbcode->smiley_dir = '/' . WPINC . '/images/smilies';
+        // Pass BBCode properties to the parser
+        foreach ( $this->bbcode_parser_properties as $prop => $value ) {
+            $bbcode->{$prop} = $value;
+        }
 
         return html_entity_decode( $bbcode->Parse( $field ) );